http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11173 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 --- Comment #1 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Created attachment 28374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28374&action=edit Bug 12294 : Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 --- Comment #2 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28374|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29151&action=edit [SIGNED-OFF] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Copied test plan from comment. No errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29151|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29652&action=edit [PASSED QA] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with <br /> in printed html file as <br /> is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with <br /> at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one <br /> at each end of line * in html file, <br /> is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one <br /> at each end of line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Copied test plan from comment. No errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Sophie! Note: I'll add a reference to this in the release notes as Kyle proposed. -- You are receiving this mail because: You are watching all bug changes.