[Bug 14038] New: SQLHelper replacement - C4::Members::Search - nl-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Bug ID: 14038 Summary: SQLHelper replacement - C4::Members::Search - nl-search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: jonathan.druart@biblibre.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com, magnus@enger.priv.no members/nl-search.pl currently uses C4::Members::Search. To get rid of SQLHelper, we should not use this subroutine anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12633 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38306&action=edit Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38306|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 38665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38665&action=edit Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Signed-off-by: Magnus Enger <magnus@enger.priv.no> Searching works the same with and without the patch. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- QA team: This patch can only really be tested by a Norwegian library system vendor, because you need all sorts of passwords and secret handshakes... I think what can be done is testing for regressions, e.g. that normal patron search works as expected with NorwegianPatronDBEnable = Disable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38665|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38694&action=edit [PASSED QA] Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Signed-off-by: Magnus Enger <magnus@enger.priv.no> Searching works the same with and without the patch. Thanks Jonathan! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Code touched by this patch is specific to the Norwegian library card feature - no regressions found and trusting Magnus as a tester here (have to... ;) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org