http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|useless code in |useless code in |acqui/basket.pl |acqui/basket.pl ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38316|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38712&action=edit Bug 10913: The delete basket confirmation page is never displayed This condition is never reached, the confirmation to delete a basket is done with a popup in the template. Test plan: Confirm you don't find any regression when creation/editing and deleting a basket. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I didn't create or edit. However, the only perl script that uses the template is acqui/basket.pl and the only place delete_confirm is set in acqui/basket.pl is in that code which is only called if del_basket actually existed anywhere else, which it doesn't. I did have two baskets, one with two transfers from the first, so I transferred one back, and then proceeded to test the two delete buttons in the modal. No issues. Cancel (to close the modal) works too. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38712|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38714&action=edit [PASSED QA] Bug 10913: The delete basket confirmation page is never displayed This condition is never reached, the confirmation to delete a basket is done with a popup in the template. Test plan: Confirm you don't find any regression when creation/editing and deleting a basket. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: I didn't create or edit. However, the only perl script that uses the template is acqui/basket.pl and the only place delete_confirm is set in acqui/basket.pl is in that code which is only called if del_basket actually existed anywhere else, which it doesn't. I did have two baskets, one with two transfers from the first, so I transferred one back, and then proceeded to test the two delete buttons in the modal. No issues. Cancel (to close the modal) works too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.