https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148972|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148976&action=edit Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148976|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149354&action=edit Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply clean to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.