[Bug 33345] New: On-site checkout checkbox does not work since issue date using flatpickr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Bug ID: 33345 Summary: On-site checkout checkbox does not work since issue date using flatpickr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Since Bug 30718, date due uses flatpickr. The JavaScript code setting due date via on-site checkout checkbox needs to be adapted. Sort of like Bug 30717. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30717 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 148786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148786&action=edit Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr WIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- There are other places setting 'duedatespec' input, but they are hidden so not with flatpickr : koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: $("input[name=duedatespec]:hidden").val('[% HIGHHOLDS.returndate | html %]'); koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: $("input[name=restoreduedatespec]:hidden").val('highholds_empty'); koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: $("input[name=restoreduedatespec]:hidden").val('[% duedatespec | html %]'); koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: $("input[name=duedatespec]:hidden").val(''); koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt: $("input[name=duedatespec]:hidden").val('[% checkout_info.HIGHHOLDS.returndate | html %]'); koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: if ($('#duedatespec').val().length === 0) { koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt: var date_due = flatpickr.parseDate( $('#duedatespec').val(), flatpickr_datetime_string ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148786|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 148787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148787&action=edit Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr Since Bug 30718, date due uses flatpickr. The JavaScript code setting due date via on-site checkout checkbox needs to be adapted. Sort of like Bug 30717. This patch renames the variable sent to template 'today_due_date_and_time' to avoid confusion with variable 'todaysdate' used in other templates. Test plan : 1) Enable system preference 'OnSiteCheckouts' 2) Go to a patron circulation page /cgi-bin/koha/circ/circulation.pl 3) Click on settings icon inside barcode input => Check due date input is empty 4) Click on 'On-site checkout' => Check due date input is filled with today date at 23:59 5) Fill barcode input and do check-out 6) Check due date is correct -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148787|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 149298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149298&action=edit Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr Since Bug 30718, date due uses flatpickr. The JavaScript code setting due date via on-site checkout checkbox needs to be adapted. Sort of like Bug 30717. This patch renames the variable sent to template 'today_due_date_and_time' to avoid confusion with variable 'todaysdate' used in other templates. Test plan : 1) Enable system preference 'OnSiteCheckouts' 2) Go to a patron circulation page /cgi-bin/koha/circ/circulation.pl 3) Click on settings icon inside barcode input => Check due date input is empty 4) Click on 'On-site checkout' => Check due date input is filled with today date at 23:59 5) Fill barcode input and do check-out 6) Check due date is correct Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. If I understand this correctly, if OnSiteCheckouts is enabled: 1.1 Go to check out an item for a patron 1.2 Click on the settings icon in the barcode input field 1.3 Click the tick box next to 'On-site checkouts' 1.4 It should automatically fill in the 'Specify due date' field with today's date and 23:59 as the time 1.5 Before the patch is applied, it doesn't (when it should) 1.6 After the patch is applied, it does (which is what is expected) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Verified that this restores the previous behavior (tested in 20.11). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149298|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149363&action=edit Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr Since Bug 30718, date due uses flatpickr. The JavaScript code setting due date via on-site checkout checkbox needs to be adapted. Sort of like Bug 30717. This patch renames the variable sent to template 'today_due_date_and_time' to avoid confusion with variable 'todaysdate' used in other templates. Test plan : 1) Enable system preference 'OnSiteCheckouts' 2) Go to a patron circulation page /cgi-bin/koha/circ/circulation.pl 3) Click on settings icon inside barcode input => Check due date input is empty 4) Click on 'On-site checkout' => Check due date input is filled with today date at 23:59 5) Fill barcode input and do check-out 6) Check due date is correct Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Missing 22.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org