[Bug 20447] New: Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

19 Mar 2018 19 Mar '18

2:18 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Bug ID: 20447 Summary: Add support for MARC holdings records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: ere.maijala@helsinki.fi QA Contact: testopia@bugs.koha-community.org RFC: https://wiki.koha-community.org/wiki/MARC_Holdings_Records_RFC This is placeholder for upcoming activity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

19 Mar 19 Mar

2:19 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/MARC_Holdings_Rec | |ords_RFC --- Comment #1 from Ere Maijala <ere.maijala@helsinki.fi> --- This will obsolete bug 2797. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Apr 1 Apr

4:27 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

5 Apr 5 Apr

5:05 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #3 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 73703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73703&action=edit Initial holdings support -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

5:07 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

5:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ere.maijala@helsinki.fi |ity.org | Status|NEW |In Discussion --- Comment #5 from Ere Maijala <ere.maijala@helsinki.fi> --- Initial development is complete. Here's a full patch for the brave to try out. You will need to run dbix schema update and the database update. Without changing settings there should be no change in behavior. Holdings support is enabled only by setting preference SummaryHoldings to "Use". I consider this quite feature-complete apart from the following: - terminal utilities for importing and exporting holdings are still missing - some tests should be added - existing tests should be verified - look and feel may need refinement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Jun 27 Jun

2:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

28 Jun 28 Jun

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

4 Jul 4 Jul

1:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #8 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 76670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76670&action=edit Sample MARCXML file containing biblios with interleaved holdings -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:27 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:27 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #10 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 76672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76672&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Jul 6 Jul

3:16 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:16 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76672|0 |1 is obsolete| | --- Comment #12 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 76736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76736&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Aug 27 Aug

2:14 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:14 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #14 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 78179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78179&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:14 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #15 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 78180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78180&action=edit Bug 20447: Include basic summary holdings in the OAI-PMH responses. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 If include_items is set in oai conf, also basic location information from holdings records is included in the returned MARC records. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Sep 14 Sep

11:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

15 Sep 15 Sep

6:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #19 from Ere Maijala <ere.maijala@helsinki.fi> --- Note that what's currently displayed in OPAC from holdings is pretty basic and can be extended as necessary. What's displayed is controlled by the framework, and the fields currently available are public_note, summary, supplements and indexes. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:48 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Sep 16 Sep

12:30 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #20 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 78907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78907&action=edit Bug 20447: Ignore holdings records in staff UI when staging records Importing holdings is not a typical action and can be done with bulk import if necessary. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Sep 25 Sep

3:50 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #21 from Hugo Agud <hagud@orex.es> --- The patch appies fine. I have been able to import the marxcml file I have been able to export the marcxml file I am able to turn on summary holding on syspref I am able to see the marc holdings on the intraner BUT I am not able to see the marc holdings at the opac I think the marc framework that works with holdings should be 'fixed' review mandatory fields and duplicables fields... I have duplicated 852 and I guett an error DBIx::Class::Schema::source(): Can't find source for HoldingsMetadata at /home/vagrant/kohaclone/Koha/Objects.pm line 341 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 PENDING CHECKING OAI thanks a lot for this patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:01 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #22 from Ere Maijala <ere.maijala@helsinki.fi> --- Hugo, did you run the databse updates (perl installer/data/mysql/updatedatabase.pl) and DBIx class updates (perl misc/devel/update_dbix_class_files.pl ...)? That'll be required for things to work properly. I'm asking because I don't get an error with multiple 852 fields, and that's actually a repeatable field according to the standard. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Sep 26 Sep

12:07 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #23 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 79403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79403&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework, and that's disabled in the UI so it must be done in the database. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:06 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #24 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 79413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79413&action=edit Bug 20447: Add missing fields to the holdings framework Adds fields 337, 338, 347, 5xx and 84x. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Sep 27 Sep

3:47 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #25 from Hugo Agud <hagud@orex.es> --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20447: MARC Holdings support Using index info to reconstruct a base tree... M Koha/Schema/Result/Deleteditem.pm M Koha/Schema/Result/Item.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging Koha/Schema/Result/Item.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Item.pm Auto-merging Koha/Schema/Result/Deleteditem.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Deleteditem.pm Failed to merge in the changes. Patch failed at 0001 Bug 20447: MARC Holdings support The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20447-MARC-Holdings-support-B8w5Re.patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Sep 28 Sep

12:42 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:42 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:42 p.m.

10:55 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

11:05 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #45 from Ere Maijala <ere.maijala@helsinki.fi> --- Latest version contains the following fixes: - Add missing 0xx fields to the holdings framework - Fix the documentation links (question marks) in the MARC editor - Fix title and breadcrumb when modifying a holdings record - Include more fields in the call number to display - Fix Items tab name when holdings are enabled - Handle holdings when moving items from a biblio to another -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:49 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Oct 18 Oct

2:45 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:45 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80321|0 |1 is obsolete| | --- Comment #47 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 80824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80824&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:45 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:45 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:45 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:49 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #51 from Ere Maijala <ere.maijala@helsinki.fi> --- The latest version adds ccode column to holdings for parity with items location fields. Also upgrade script no longer contains framework data duplicated from the default framework sql and after a lot of deliberation branch code has been moved from 852$a to 852$b and location from 852$b to 852$c by default so that 852$a can be reserved for an ISIL code or such. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Oct 26 Oct

12:08 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:08 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80824|0 |1 is obsolete| | --- Comment #53 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 81265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81265&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:08 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:08 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:08 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

29 Oct 29 Oct

12:35 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Nov 27 Nov

2:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81265|0 |1 is obsolete| | --- Comment #58 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 82670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82670&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

29 Dec 29 Dec

4:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #62 from Michal Denar <black23@gmail.com> --- Hi Ere, I tested patches and import seem be ok. But Test fails: t/db_dependent/Exporter/Record.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`holdings`, CONSTRAINT `holdings_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for Statement "INSERT INTO holdings SET biblionumber = ?, biblioitemnumber = ?, frameworkcode = ?, holdingbranch = ?, location = ?, ccode = ?, callnumber = ?, suppress = ?, datecreated = NOW() " with ParamValues: 0='442', 1=441, 2='', 3="Location", 4=undef, 5=undef, 6="Tb | 1973", 7=0] at /home/vagrant/kohaclone/C4/Holdings.pm line 503. ERROR in _koha_add_holding INSERT INTO holdings SET biblionumber = ?, biblioitemnumber = ?, frameworkcode = ?, holdingbranch = ?, location = ?, ccode = ?, callnumber = ?, suppress = ?, datecreated = NOW() Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`holdings`, CONSTRAINT `holdings_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at /home/vagrant/kohaclone/C4/Holdings.pm line 509. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`holdings_metadata`, CONSTRAINT `holdings_metadata_fk_1` FOREIGN KEY (`holding_id`) REFERENCES `holdings` (`holding_id`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `holdings_metadata` ( `format`, `holding_id`, `marcflavour`, `metadata`) VALUES ( ?, ?, ?, ? )" with ParamValues: 0='marcxml', 1='442', 2='MARC21', 3="<?xml version="1.0" encoding="UTF-8"?> Can You give me feedback? Thank You Mike -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Dec 31 Dec

1 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82670|0 |1 is obsolete| | --- Comment #64 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 83551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83551&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

28 Jan 28 Jan

5:42 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | --- Comment #74 from Josef Moravec <josef.moravec@gmail.com> --- So, started the first QA run ;) First of all, I really like this enhancement and would to see it in Koha. But this need some more work I think, first some not critical and easy to fix: - System preference SummaryHoldings is missing in db updates - Holdings marc framework is missing from db update - Schema files should be attached in its own patch - I do not like using subfield "V" as default for linking item to holding, uppercase letters for subfields are not possible in marc21 standard But, the main problem I see here is C4::Holdings module - C4 namespace is deprecated, and should not be used for new modules, you always should add the new modules into Koha namespace and use objects if possible and if it does make sense, of course. You already have Koha::Holdings and Koha::Holdings::Metadatas, so you should add new routines here (in the Koha::Objects(s) manner). See also bug 22144, that's the way the holdings, holding::metadatas and its marc record object should be linked together too. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Jan 29 Jan

8:52 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

20 Feb 20 Feb

4:12 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

4:13 p.m.

4:53 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:53 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #77 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 85368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85368&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:53 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #78 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 85369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85369&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:53 p.m.

7:59 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #87 from Ere Maijala <ere.maijala@helsinki.fi> --- One thing that could be done would be to decouple the MARC editor from addbiblio so that the code could be re-used. I'll see if that's something that could be done with not too high impact. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:53 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Feb 22 Feb

10:59 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21280 --- Comment #88 from Ere Maijala <ere.maijala@helsinki.fi> --- I'll work in Bug 21280 to unify the MARC editors in biblios and authorities. I don't consider it blocking, but if it happened that it would be accepted, I would update the editor here to use the common stuff. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Mar 1 Mar

3:37 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:37 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:37 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85418|0 |1 is obsolete| | --- Comment #91 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 85908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85908&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:37 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

4 Mar 4 Mar

3:12 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85908|0 |1 is obsolete| | --- Comment #95 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 85996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85996&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:22 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5 Mar 5 Mar

2:50 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #98 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Comment on attachment 85994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994 Bug 20447: MARC Holdings support Review of attachment 85994: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=85994) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +1563,5 @@

...

}

+ #---- holdings + if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "holdings" ) { + my $holding = Koha::Holdings->find( $value );

does the find need "deleted_on => undef" as a parameter in order to not care about deleted holdings? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #99 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Comment on attachment 85994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994 Bug 20447: MARC Holdings support Review of attachment 85994: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=85994) ----------------------------------------------------------------- ::: C4/Items.pm @@ +1705,5 @@

...

+ holdingbranch => $oldHolding->{'holdingbranch'}, + location => $oldHolding->{'location'}, + callnumber => $oldHolding->{'callnumber'}, + suppress => $oldHolding->{'suppress'}, + deleted_on => undef

if deleted_on is not needed / is undef by default this can be removed -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:05 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20271 --- Comment #100 from Ere Maijala <ere.maijala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #97)

...

Why is there deleted_on on in both holdings and holdings_metadata tables? Why is it not enough to have it just in holdings?

Because that's how it's done also for biblios in bug 20271. There's at least one practical upside: it allows one to fetch a metadata record without joining with the base table. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:07 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #101 from Ere Maijala <ere.maijala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #98)

...

Comment on attachment 85994 [details] [review] Bug 20447: MARC Holdings support

Review of attachment 85994 [details] [review]: -----------------------------------------------------------------

::: C4/Biblio.pm @@ +1563,5 @@

...
}

+ #---- holdings + if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "holdings" ) { + my $holding = Koha::Holdings->find( $value );

does the find need "deleted_on => undef" as a parameter in order to not care about deleted holdings?

It allows one to fetch a holdings record by ID even if it's deleted. I believe it makes sense since otherwise it would be possible, at least in theory, for an item to point to a deleted holdings record without it showing. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #102 from Ere Maijala <ere.maijala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #99)

...

Comment on attachment 85994 [details] [review] Bug 20447: MARC Holdings support

Review of attachment 85994 [details] [review]: -----------------------------------------------------------------

::: C4/Items.pm @@ +1705,5 @@

...
+ holdingbranch => $oldHolding->{'holdingbranch'}, + location => $oldHolding->{'location'}, + callnumber => $oldHolding->{'callnumber'}, + suppress => $oldHolding->{'suppress'}, + deleted_on => undef

if deleted_on is not needed / is undef by default this can be removed

It tries to find an existing holdings record for the item to be attached to. Deleted holdings do not qualify, so the filter is needed. However, I just realized that the search terms can match multiple records which would cause find() to fail. I need to revise that. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:14 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #103 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Ere Maijala from comment #100)

...

(In reply to Joonas Kylmälä from comment #97)

...
Why is there deleted_on on in both holdings and holdings_metadata tables? Why is it not enough to have it just in holdings?

Because that's how it's done also for biblios in bug 20271. There's at least one practical upside: it allows one to fetch a metadata record without joining with the base table.

#1 rule in my database course was always use the normal form for databases. It feels wrong to have the data in one place: twice the possibility of having bugs and also taking twice as much space. I read quickly https://stackoverflow.com/questions/2623852/why-are-joins-bad-when-consideri... and in the end the performance difference might not be that big. I would like you to provide performance benchmarks if we are going to use the non-normalized way. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #104 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Joonas Kylmälä from comment #103)

...

#1 rule in my database course was always use the normal form for databases. It feels wrong to have the data in one place: twice the possibility of having bugs and also taking twice as much space. I read quickly https://stackoverflow.com/questions/2623852/why-are-joins-bad-when- considering-scalability and in the end the performance difference might not be that big. I would like you to provide performance benchmarks if we are going to use the non-normalized way.

Here is a few pages of reasoning why we should use the normal form: https://mariadb.com/kb/en/library/database-normalization/ (unless there is a significant performance gain) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #105 from Ere Maijala <ere.maijala@helsinki.fi> --- I'm aware of that, but I'm not making the call here. I think it would be better to continue discussion about the deleted_on field in the metadata tables in bug 20271. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

5 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #112 from Michal Denar <black23@gmail.com> --- Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm Auto-merging Koha/Schema/Result/Biblio.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #113 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Michal Denar from comment #112)

...

Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm Auto-merging Koha/Schema/Result/Biblio.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20447: DBIX schema changes

Mike, these files could be easily regeneretad, just omit this one patch and run command 'dbic' on kohadevbox -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Mar 29 Mar

noon

11:48 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #119 from Michal Denar <black23@gmail.com> --- Hi Ere, tests passed, but I'm not able to import attached files: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 0 MARC bibliographic records and 0 holdings records done in 0.012 seconds Any ideas? Thank you. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Apr 3 Apr

8:54 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #120 from Ere Maijala <ere.maijala@helsinki.fi> --- A couple of simple checks first: check that you have holdings.xml in the current directory and that it's valid xml. bulkmarcimport doesn't have very good error checking and it will just report 0 records if it doesn't find the file or can't read it. For what it's worth, here are my results: $ xmllint -noout holdings.xml $ misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML ..... 5 MARC bibliographic records and 3 holdings records done in 1.711 seconds If you are still unable to make it work, I'll need to recheck with kohadevbox. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:11 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #121 from Michal Denar <black23@gmail.com> --- Hi Ere, sorry my fault., no holdings.xml on devbox :-( I'll next round... Thanks to Josef for kick. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:35 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:35 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87307|0 |1 is obsolete| | Attachment #87308|0 |1 is obsolete| | Attachment #87309|0 |1 is obsolete| | Attachment #87310|0 |1 is obsolete| | --- Comment #122 from Michal Denar <black23@gmail.com> --- Created attachment 87346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87346&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:36 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #123 from Michal Denar <black23@gmail.com> --- Created attachment 87347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87347&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:36 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #124 from Michal Denar <black23@gmail.com> --- Created attachment 87348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87348&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:36 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #125 from Michal Denar <black23@gmail.com> --- Created attachment 87349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87349&action=edit Bug 20447: DBIX schema changes Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Apr 17 Apr

5:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #126 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 87346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87346 Bug 20447: MARC Holdings support Review of attachment 87346: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=87346) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +2828,5 @@

...

$itemnumbers = [] unless defined $itemnumbers;

+ if ( !$skip_holdings && C4::Context->preference('SummaryHoldings') && !@$itemnumbers ) { + require Koha::Holdings;

You don't need this require ::: C4/Items.pm @@ +1690,5 @@

...

AND biblionumber = ? |, undef, $tobiblioitem, $tobiblio, $itemnumber, $frombiblio ); if ($return == 1) { + # Check if the moved item is attached to a holdings record + my $item = my $item = Koha::Items->find($itemnumber);

double "my $item" ::: C4/Search.pm @@ +2252,5 @@

...

}

+ # Fetch summary holdings + if (C4::Context->preference('SummaryHoldings')) { + $summary_holdings = Koha::Holdings->search({ biblionumber => $oldbiblio->{biblionumber}, deleted_on => undef })->unblessed;

why do you unbless here? ::: Koha/Holding.pm @@ +53,5 @@

...

+ my ($self) = @_; + + $self->{_metadata} ||= Koha::Holdings::Metadatas->find({ holding_id => $self->id }); + + return $self->{_metadata};

Should be changed, according to bug 22407, see https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-orient... You should use something like my $metadata = $self->_result->metadata; return Koha::Holdings::Metadata->_new_from_dbic($metadata); @@ +111,5 @@

...

+ my ($self) = @_; + + $self->{_items} ||= Koha::Items->search( { holding_id => $self->holding_id() } ); + + return wantarray ? $self->{_items}->as_list : $self->{_items};

PERL15 rule applies here too ::: Koha/Template/Plugin/Holdings.pm @@ +71,5 @@

...

+ my $sth = C4::Context->dbh->prepare($query); + $sth->execute($holding->{'holdingbranch'}); + my $b = $sth->fetchrow_hashref(); + push @parts, $b->{'branchname'} if $b; + $sth->finish();

Why do you use sql instead of relation method like $holding->library ? ::: catalogue/detail.pl @@ +194,5 @@

...

+# Summary holdings +my $summary_holdings; +if (C4::Context->preference('SummaryHoldings')) { + $summary_holdings = Koha::Holdings->search({ biblionumber => $biblionumber, deleted_on => undef })->unblessed;

Why do you unbless? ::: t/db_dependent/Koha/Holding.t @@ +22,5 @@

...

+use t::lib::TestBuilder; + +use C4::Biblio; + +use Koha::BiblioFramework;

Singular class is imported through plural class, it is not needed to be used explicitaly. ::: t/db_dependent/Koha/Holdings.t @@ +22,5 @@

...

+use t::lib::TestBuilder; + +use C4::Biblio; + +use Koha::BiblioFramework;

Not needed to use singular class -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:04 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #127 from Josef Moravec <josef.moravec@gmail.com> --- Started QA, found some first issues: When editing holding marc record, i am able to change framework to default and acquisition, is it intended? The holdings marc editor need to be upgraded to new style introduce by bug 22045. Could be done in own bug report or on bug 21280 I think. QA test tools report: FAIL C4/Biblio.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/ImportBatch.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/Items.pm FAIL valid "my" variable $item masks earlier declaration in same statement "my" variable $item masks earlier declaration in same statement FAIL C4/Search.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/XSLT.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Exporter/Record.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Holdings.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/OAI/Server/ListBase.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/OAI/Server/Repository.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Template/Plugin/Holdings.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL admin/marc_subfields_structure.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL catalogue/detail.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL catalogue/showmarc.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/addholding.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/additem.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/value_builder/marc21_field_008_holdings.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/value_builder/marc21_leader_holdings.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc FAIL filters missing_filter at line 14 ( <li><a id="newholding" href="/cgi-bin/koha/cataloguing/addholding.pl?biblionumber=[% biblionumber %]#addholding">New holdings record</a></li>) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 210 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#editholding"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 210 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#editholding"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 211 ( <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/cataloguing/addholding.pl?op=delete&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]"><i class="fa fa-eraser"></i> Delete</a>) missing_filter at line 211 ( <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/cataloguing/addholding.pl?op=delete&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]"><i class="fa fa-eraser"></i> Delete</a>) missing_filter at line 212 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem.pl?biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#additema"><i class="fa fa-plus"></i> Add item</a>) missing_filter at line 212 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem.pl?biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#additema"><i class="fa fa-plus"></i> Add item</a>) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addholding.tt FAIL filters wrong_html_filter at line 358 ( › Edit <a href="/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=[% biblionumber | html %]">[% title | html %] [% IF ( author ) %] by [% author | html %][% END %] (Record #[% biblionumber | html %])</a>) wrong_html_filter at line 359 ( › <a href="/cgi-bin/koha/cataloguing/addholding.pl?biblionumber=[% biblionumber | html %]">Holdings</a>) wrong_html_filter at line 457 ( <li><a href="#tab[% BIG_LOO.number | html %]XX">[% BIG_LOO.number | html %]</a></li>) missing_filter at line 469 ( <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to Expand this Tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag %]</a>) missing_filter at line 471 ( <span class="tagnum" title="[% innerloo.tag_lib %]">[% innerloo.tag | html %]</span>) missing_filter at line 553 ( [% subfield_loo.marc_lib %]) missing_filter at line 578 ( [% mv.javascript %]) missing_filter at line 582 ( <textarea cols="70" rows="4" id="[%- mv.id | html -%]" name="[%- mv.name | html -%]" class="input_marceditor" tabindex="1">[%- mv.value -%]</textarea>) FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 11) forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 376) FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008_holdings.tt FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 167) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader_holdings.tt FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 83) FAIL misc/batchRebuildHoldingsTables.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL misc/export_records.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL misc/migration_tools/bulkmarcimport.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL opac/opac-detail.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL t/db_dependent/Exporter/Record.t FAIL valid "my" variable $item masks earlier declaration in same statement FAIL t/db_dependent/Koha/Holding.t FAIL valid "my" variable $item masks earlier declaration in same statement FAIL t/db_dependent/Koha/Holdings.t FAIL valid "my" variable $item masks earlier declaration in same statement FAIL tools/export.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL tools/stage-marc-import.pl FAIL valid "my" variable $item masks earlier declaration in same statement -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Apr 25 Apr

1:41 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

28 Apr 28 Apr

10:28 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9442 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 May 8 May

2:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

10:56 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:56 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #135 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Joonas Kylmälä from comment #134)

...

This patch set would break cataloguing/merge.pl since there is no patch to move holdings to a different bibliographic record. I have moved this back to "In Discussion" because I think this needs to be fixed before merging this patch set.

Hi Joonas, thx for testing. Setting to Failed QA is better in this case. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Jul 23 Jul

3:12 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #136 from Ere Maijala <ere.maijala@helsinki.fi> --- Joonas, was that an assumption or a verified problem? There's code in Items::MoveItemFromBiblio that does its best to handle holdings. A holdings record cannot be moved if an item is moved, but the mechanism tries to make sure there's a suitable holdings record used or added in the destination biblio. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88753|0 |1 is obsolete| | --- Comment #139 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 91745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91745&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

24 Jul 24 Jul

9:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

...

Joonas, was that an assumption or a verified problem? There's code in Items::MoveItemFromBiblio that does its best to handle holdings. A holdings record cannot be moved if an item is moved, but the mechanism tries to make sure there's a suitable holdings record used or added in the destination biblio.

I probably noticed the problem only in the code when I commented but try the following test case and you see the problem happens for real: 1) Create new record with item and a holdings record. Don't attach the holding to the item. 2) create another record with no items or holdings records 3) In cataloguing search (More -> Cataloging) make such search that you find both records 4) Select both of them and click "Merge selected". Select record with no items or holdings as there reference record (the one that will be kept) 5) After the merge is done notice that the holdings record didn't transfer to the merged record. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:11 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #144 from Ere Maijala <ere.maijala@helsinki.fi> --- Ok, thanks, I'll fix.. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

28 Aug 28 Aug

9:12 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #146 from Ere Maijala <ere.maijala@helsinki.fi> --- Note to self: make sure there's also an index on the timestamp column. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Aug 29 Aug

1:57 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #147 from David Cook <dcook@prosentient.com.au> --- (In reply to Ere Maijala from comment #146)

...

Note to self: make sure there's also an index on the timestamp column.

+1000 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Oct 22 Oct

2:28 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #153 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- browser-strings.inc will be removed by bug 23884. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Jan 23 Jan

1:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99145|0 |1 is obsolete| | --- Comment #171 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 99178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99178&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

8:52 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

8:54 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #179 from Ere Maijala <ere.maijala@helsinki.fi> --- Added a minimal patch to include holding_id in the item definition of the REST API. I'll defer actual API functionality to a later bug. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

27 Feb 27 Feb

10:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24751 [Bug 24751] REST API: CRUD endpoints for holdings records -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

13 Apr 13 Apr

6:24 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 May 12 May

8:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

8:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99177|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

15 May 15 May

10:01 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #181 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 99235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99235 Bug 20447: MARC Holdings support Review of attachment 99235: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=99235) ----------------------------------------------------------------- Hi Ere, I read through the code and have some notes/questions Overall, I think it's great enhancement and I really like this to be part of Koha. ::: C4/Search.pm @@ +2242,5 @@

...

}

+ # Fetch summary holdings + if (C4::Context->preference('SummaryHoldings')) { + $summary_holdings = Koha::Holdings->search({ biblionumber => $oldbiblio->{biblionumber}, deleted_on => undef });

Maybe something like $biblio->holdings? ::: Koha/Biblio.pm @@ +520,5 @@

...

+ +sub holdings { + my ($self) = @_; + + $self->{_holdings} ||= Koha::Holdings->search( { biblionumber => $self->biblionumber } );

use relation and new_from_dbic? ::: Koha/Holding.pm @@ +23,5 @@

...

+use Carp; + +use C4::Charset; +use C4::Log; +

are all imports needed? @@ +138,5 @@

...

+ + return + wantarray + ? Koha::Items->_new_from_dbic($items_rs)->as_list + : Koha::Items->_new_from_dbic($items_rs);

do we really need this duality? @@ +166,5 @@

...

+ my $guard = C4::Context->dbh->{AutoCommit} ? $schema->txn_scope_guard() : undef; + + my $result = $self->SUPER::store(); + + return $result unless $result;

Should it be just 'return unless $result'? ::: Koha/Holdings.pm @@ +25,5 @@

...

+use C4::Biblio; +use C4::Charset; +use C4::Context; +use Koha::Database; +use Koha::Holding;

Are all imports needed? ::: Koha/Holdings/Metadata.pm @@ +34,5 @@

...

+=cut + +=head3 record + +my @record = $metadata->record($params);

there are no params handled in method 'record' ::: catalogue/detail.pl @@ +432,3 @@

...

C4::Search::enabled_staff_search_views, + materials => $materials_flag, + show_summary_holdings => C4::Context->preference('SummaryHoldings') ? 1 : 0,

You could use template plugin for getting value of a syspref and then you don't need to pass this variable to template ::: cataloguing/addholding.pl @@ +151,5 @@

...

+=cut + +sub CreateKey { + return int(rand(1000000)); +}

Maybe Koha::Token would be better to use instead of this sub, but could be leaved to other bug report, as this pattern is in more files now. ::: cataloguing/value_builder/marc21_field_008_holdings.pl @@ +22,5 @@

...

+use C4::Auth; +use CGI qw ( -utf8 ); +use C4::Context; + +use C4::Search;

Do you need C4::Search ? @@ +39,5 @@

...

+ my $function_name = $params->{id}; + my $dateentered = date_entered(); + my $res = " +<script type=\"text/javascript\"> +//<![CDATA[

type parameter and CDATA should not be used ::: cataloguing/value_builder/marc21_leader_holdings.pl @@ +29,5 @@

...

+ my ( $params ) = @_; + my $function_name = $params->{id}; + my $res = " +<script type=\"text/javascript\"> +//<![CDATA[

Type parameter and CDATA should not be used ::: koha-tmpl/intranet-tmpl/prog/css/addholding.css @@ +139,5 @@

...

+ +.yui-gf .yui-u { + width: 79.2%; +} +

Are there still yui classes? ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addholding.tt @@ +6,5 @@

...

+[% INCLUDE 'doc-head-close.inc' %] +[% Asset.js("lib/hc-sticky.js") | $raw %] +[% Asset.js("js/cataloging.js") | $raw %] +[% INCLUDE 'strings.inc' %] +[% Asset.js("js/browser.js") | $raw %]

Even javascript included by Asset plugin should be at end of template And you need to set variable footerjs, like: [% SET footerjs = 1 %] (And macro block - see bellow) @@ +287,5 @@

...

+</div> +</div> +</div> + +<script>

Scripts should be in enclosed by [% MACRO jsinclude BLOCK %] ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008_holdings.tt @@ +3,5 @@

...

+<title>Koha › Holdings › 008 builder</title> +[% INCLUDE 'doc-head-close.inc' %] +</head> +<body id="cat_marc21_field_008_holdings" class="cat" style="padding:1em;"> +<h3> 008 Fixed-length data elements</h3>

There is white space just after <h3> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:07 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #182 from Ere Maijala <ere.maijala@helsinki.fi> --- Thanks Josef, I'll address your comments when I'm done rebasing. It proved to be a bit more work than before since the MARC 21 default framework was changed to YAML. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 May 19 May

12:20 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:20 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:20 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99238|0 |1 is obsolete| | --- Comment #186 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 105071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105071&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

12:22 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

22 May 22 May

1:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105071|0 |1 is obsolete| | --- Comment #192 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 105262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105262&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #194 from Ere Maijala <ere.maijala@helsinki.fi> --- I've now addressed Josef's comments apart from the ones listed below (for a reason):

...

::: C4/Search.pm @@ +2242,5 @@

...
}

+ # Fetch summary holdings + if (C4::Context->preference('SummaryHoldings')) { + $summary_holdings = Koha::Holdings->search({ biblionumber => $oldbiblio->{biblionumber}, deleted_on => undef });

Maybe something like $biblio->holdings?

I didn't change this since it would require fetching the biblio record for each result, and since we don't currently do that, it would have been extra work required just to get the holdings. I added a comment noting that.

...

::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addholding.tt @@ +6,5 @@

...
+[% INCLUDE 'doc-head-close.inc' %] +[% Asset.js("lib/hc-sticky.js") | $raw %] +[% Asset.js("js/cataloging.js") | $raw %] +[% INCLUDE 'strings.inc' %] +[% Asset.js("js/browser.js") | $raw %]

Even javascript included by Asset plugin should be at end of template

And you need to set variable footerjs, like: [% SET footerjs = 1 %] (And macro block - see bellow)

addholding.tt mirrors addbiblio.tt, and addbiblio.tt uses js plugins that don't support footerjs. I updated addholding.tt according to changes in addbiblio.tt, but I left the structure intact so that it's easier to compare and update the files. It might be possible in a follow-up to merge some parts of the separate templates. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Jun 19 Jun

11:17 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Jun 22 Jun

9:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

14 Aug 14 Aug

15 Aug 15 Aug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #227 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Rebased. The issue with deletion still exists so keeping FQA status. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:54 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:54 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:54 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:54 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109698|0 |1 is obsolete| | --- Comment #231 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 109706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109706&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Michal Denar <black23@gmail.com> Trivial changes in test to fix rebase conflict Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:55 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

2:55 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

10:51 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #239 from Michal Denar <black23@gmail.com> --- Created attachment 109715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109715&action=edit Bug 20447: (follow-up) Add required metadata field when creating holdings Since metadata column is mandatory in the holdings_metadata table we need to define it already when it is first created instead of creating it first and updating the column immediately after. This fixes the following error during holdings record creation: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a default value at /kohadevbox/koha/Koha/Objects.pm line 114 Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Sep 8 Sep

6:38 a.m.

bugzilla-daemon＠bugs.koha-community.org

12:04 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109720|0 |1 is obsolete| | --- Comment #252 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 109744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109744&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Michal Denar <black23@gmail.com> Trivial changes in test to fix rebase conflict Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:04 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

8:09 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

8:09 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

8:10 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109768|0 |1 is obsolete| | --- Comment #265 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 109877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109877&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Michal Denar <black23@gmail.com> Trivial changes in test to fix rebase conflict Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:10 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

8:10 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109770|0 |1 is obsolete| | --- Comment #267 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 109879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109879&action=edit Bug 20447: (follow-up) Add required metadata field when creating holdings Since metadata column is mandatory in the holdings_metadata table we need to define it already when it is first created instead of creating it first and updating the column immediately after. This fixes the following error during holdings record creation: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a default value at /kohadevbox/koha/Koha/Objects.pm line 114 Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:12 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #268 from Ere Maijala <ere.maijala@helsinki.fi> --- Fixed a rebase issue that lost a block added in bug 20667 from Koha/Schema/Result/Item.pm. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

15 Sep 15 Sep

6:46 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #269 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 110115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110115&action=edit Bug 20447: (follow-up) Prevent internal server error with Attach item feature If one tried to use the "Edit -> Attach item" feature in biblio detail.pl page then the following error would come if the item was not attached to any holdings record: "DBIC result _type isn't of the _type Holding" This fix prevents the error by skipping the creation of Holding object if the result set is empty. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Sep 16 Sep

1:39 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #270 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 110174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110174&action=edit Bug 20447: (follow-up) Fix holding_branch getter to handle null This fix avoids an internal server error when holdingbranch column is empty in the database. This could happen e.g. when there's a problem with the framework's Koha field mapping. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Sep 18 Sep

8:07 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

8:08 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

8:10 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #279 from Ere Maijala <ere.maijala@helsinki.fi> --- Reverted changes to obsolete nb-NO framework sql. Carried over the sign-offs. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Sep 21 Sep

bugzilla-daemon＠bugs.koha-community.org

12 Oct 12 Oct

2:23 p.m.

bugzilla-daemon＠bugs.koha-community.org

3:15 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

2:54 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #310 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 112575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112575&action=edit Bug 20447: (follow-up) Add required metadata field when creating holdings Since metadata column is mandatory in the holdings_metadata table we need to define it already when it is first created instead of creating it first and updating the column immediately after. This fixes the following error during holdings record creation: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a default value at /kohadevbox/koha/Koha/Objects.pm line 114 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:59 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #311 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Rebased. However, there are some QA script failures, not sure if everything is caused by these patches but these should be investigated one by one and then after fixing or making sure they are not caused by these patches let's move back to Needs signoff. These patches need also a test plan. FAIL t/lib/TestBuilder.pm OK critic OK forbidden patterns OK git manipulation FAIL pod OK pod coverage OK spelling OK valid FAIL installer/data/mysql/updatedev.pl FAIL critic OK file permissions OK forbidden patterns OK git manipulation OK pod OK spelling OK valid FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag FAIL Koha/Schema/Result/HoldingsMetadata.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Schema/Result/Holding.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

30 Oct 30 Oct

2:13 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #312 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Adding default indicator field value for example to field 852 through the settings in Home › Administration › MARC frameworks › Default holdings framework (HLD) doesn't work. After setting the default value for indicator and go to a biblio graphic record page to create a new holdings record and go to the tab where 852 is then the indicator value is not populated with the default value I set. Setting of default indicator value works correctly with the bibliographic record editing. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Nov 10 Nov

3 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #313 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Comment on attachment 112570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112570 Bug 20447: MARC Holdings support Review of attachment 112570: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=112570) ----------------------------------------------------------------- ::: cataloguing/addholding.pl @@ +686,5 @@

...

+ author => $biblio->author +); + +$template->param( + frameworks => Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }),

Arrays given as template params needs to be references to the array. This should be something like frameworks => \@frameworks instead (where @frameworks is the result of the search). This caused the cataloguing frameworks not to show up in the MARC holdings editor. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Nov 11 Nov

9:18 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

13 Nov 13 Nov

10:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #314 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- This patch set causes following error in error logs:

...

Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/cataloguing/additem.pl line 242.

...

242 $authorised_lib{$holding->{holding_id}} = $holding->{holding_id} . ' ' . $holding->{holdingbranch} . ' ' . $holding->{location} . ' ' . $holding->{ccode} . ' ' . $holding->{callnumber};

Before using the values in string one should check whether the string is defined. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

7 Dec 7 Dec

1:59 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #330 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Currently adding permissions items_batchdel items_batchmod is required if one wants to include piece of JavaScript that will bring up confirmation box for the deletion of holdings records. This also depends on the StaffDetailItemSelection syspref. The librarian without those permissions can already delete holdings so these permissions should not be required to just bring up the confirmation box for deletion. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Jan 18 Jan

22 Jan 22 Jan

bugzilla-daemon＠bugs.koha-community.org

24 Jan 24 Jan

11:57 a.m.

1:46 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #355 from Andrew Nugged <nugged@gmail.com> --- Created attachment 115729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115729&action=edit Bug 20447: (Follow-up) Regenerate DBIX schema to match with latest DB state -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

11:41 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #374 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- I got reports that Advanced editor mode doesn't work with holdings but it works with biblios. Probably should aim for feature parity here. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Mar 17 Mar

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116805|0 |1 is obsolete| | Attachment #116806|0 |1 is obsolete| | Attachment #116807|0 |1 is obsolete| | Attachment #116808|0 |1 is obsolete| | Attachment #116809|0 |1 is obsolete| | Attachment #116810|0 |1 is obsolete| | Attachment #116811|0 |1 is obsolete| | Attachment #116812|0 |1 is obsolete| | --- Comment #375 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118382&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #376 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118383&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. https://bugs.koha-community.org/show_bug.cgi?id=22690 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #377 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118385&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. https://bugs.koha-community.org/show_bug.cgi?id=22690 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #378 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118386&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. https://bugs.koha-community.org/show_bug.cgi?id=22690 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #379 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118387&action=edit Bug 20447: (follow-up) Add required metadata field when creating holdings Since metadata column is mandatory in the holdings_metadata table we need to define it already when it is first created instead of creating it first and updating the column immediately after. This fixes the following error during holdings record creation: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a default value at /kohadevbox/koha/Koha/Objects.pm line 114 https://bugs.koha-community.org/show_bug.cgi?id=22690 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #380 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118388&action=edit Bug 20447: (follow-up) Correctly list all holdings frameworks in editor The Template Toolkit expects a ref to array and we passed the array instead. It caused the listing of holdings frameworks not to show when there was more than one holdings framework defined. To test: 1) Apply patch 2) Make 3 copies of the default HLD framework 3) Go to a biblio page and create new holding 4) Click Settings in the editor page and notice all 3 frameworks are now listed in the drop-down menu -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #381 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118389&action=edit Bug 20447: Don't use GROUP by when fetching authorised values for editor The syntax is invalid SQL. The original intent was probably to remove duplicates from the holdings record marc editor but it would have actually removed then the other instances of the wanted authorised values from the list. Now we show all the authorised values that should be possible to select and yes, if you set the same description (lib field) for two different authorised values in the same category then you cannot distinguish them from each other. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:53 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #382 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118390&action=edit Bug 20447: DBIX schema changes https://bugs.koha-community.org/show_bug.cgi?id=22690 Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118382|0 |1 is obsolete| | Attachment #118383|0 |1 is obsolete| | Attachment #118385|0 |1 is obsolete| | Attachment #118386|0 |1 is obsolete| | Attachment #118387|0 |1 is obsolete| | Attachment #118388|0 |1 is obsolete| | Attachment #118389|0 |1 is obsolete| | Attachment #118390|0 |1 is obsolete| | --- Comment #383 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118397&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #384 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118398&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #385 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118399&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #386 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118400&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #387 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118401&action=edit Bug 20447: (follow-up) Add required metadata field when creating holdings Since metadata column is mandatory in the holdings_metadata table we need to define it already when it is first created instead of creating it first and updating the column immediately after. This fixes the following error during holdings record creation: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a default value at /kohadevbox/koha/Koha/Objects.pm line 114 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #388 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118402&action=edit Bug 20447: (follow-up) Correctly list all holdings frameworks in editor The Template Toolkit expects a ref to array and we passed the array instead. It caused the listing of holdings frameworks not to show when there was more than one holdings framework defined. To test: 1) Apply patch 2) Make 3 copies of the default HLD framework 3) Go to a biblio page and create new holding 4) Click Settings in the editor page and notice all 3 frameworks are now listed in the drop-down menu -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #389 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118403&action=edit Bug 20447: Don't use GROUP by when fetching authorised values for editor The syntax is invalid SQL. The original intent was probably to remove duplicates from the holdings record marc editor but it would have actually removed then the other instances of the wanted authorised values from the list. Now we show all the authorised values that should be possible to select and yes, if you set the same description (lib field) for two different authorised values in the same category then you cannot distinguish them from each other. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #390 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118404&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118397|0 |1 is obsolete| | Attachment #118398|0 |1 is obsolete| | Attachment #118399|0 |1 is obsolete| | Attachment #118400|0 |1 is obsolete| | Attachment #118401|0 |1 is obsolete| | Attachment #118402|0 |1 is obsolete| | Attachment #118403|0 |1 is obsolete| | Attachment #118404|0 |1 is obsolete| | --- Comment #391 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118405&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #392 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118406&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #393 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118407&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #394 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118408&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #395 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118409&action=edit Bug 20447: (follow-up) Add required metadata field when creating holdings Since metadata column is mandatory in the holdings_metadata table we need to define it already when it is first created instead of creating it first and updating the column immediately after. This fixes the following error during holdings record creation: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a default value at /kohadevbox/koha/Koha/Objects.pm line 114 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #396 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118410&action=edit Bug 20447: (follow-up) Correctly list all holdings frameworks in editor The Template Toolkit expects a ref to array and we passed the array instead. It caused the listing of holdings frameworks not to show when there was more than one holdings framework defined. To test: 1) Apply patch 2) Make 3 copies of the default HLD framework 3) Go to a biblio page and create new holding 4) Click Settings in the editor page and notice all 3 frameworks are now listed in the drop-down menu -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #397 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118411&action=edit Bug 20447: Don't use GROUP by when fetching authorised values for editor The syntax is invalid SQL. The original intent was probably to remove duplicates from the holdings record marc editor but it would have actually removed then the other instances of the wanted authorised values from the list. Now we show all the authorised values that should be possible to select and yes, if you set the same description (lib field) for two different authorised values in the same category then you cannot distinguish them from each other. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #398 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118412&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:37 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #399 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Rebased. Still the issues mentioned in previous comments remaining. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118405|0 |1 is obsolete| | Attachment #118406|0 |1 is obsolete| | Attachment #118407|0 |1 is obsolete| | Attachment #118408|0 |1 is obsolete| | Attachment #118409|0 |1 is obsolete| | Attachment #118410|0 |1 is obsolete| | Attachment #118411|0 |1 is obsolete| | Attachment #118412|0 |1 is obsolete| | --- Comment #400 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118429&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #401 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118430&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #402 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118431&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #403 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118432&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #404 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118433&action=edit Bug 20447: (follow-up) Add required metadata field when creating holdings Since metadata column is mandatory in the holdings_metadata table we need to define it already when it is first created instead of creating it first and updating the column immediately after. This fixes the following error during holdings record creation: DBIx::Class::Storage::DBI::_dbh_execute(): Field 'metadata' doesn't have a default value at /kohadevbox/koha/Koha/Objects.pm line 114 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:52 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #405 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118434&action=edit Bug 20447: (follow-up) Correctly list all holdings frameworks in editor The Template Toolkit expects a ref to array and we passed the array instead. It caused the listing of holdings frameworks not to show when there was more than one holdings framework defined. To test: 1) Apply patch 2) Make 3 copies of the default HLD framework 3) Go to a biblio page and create new holding 4) Click Settings in the editor page and notice all 3 frameworks are now listed in the drop-down menu -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:53 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #406 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118435&action=edit Bug 20447: Don't use GROUP by when fetching authorised values for editor The syntax is invalid SQL. The original intent was probably to remove duplicates from the holdings record marc editor but it would have actually removed then the other instances of the wanted authorised values from the list. Now we show all the authorised values that should be possible to select and yes, if you set the same description (lib field) for two different authorised values in the same category then you cannot distinguish them from each other. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:53 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #407 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 118436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118436&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:54 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #408 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Just did a major rebase for addholding.pl and addholding.tt based on the addbiblio.tt and addbiblio.pl. Rebased on top of Bug 21986, 14662, 20477, 9701, 21172, 20128, 22748, 22721, 7882, 8643, 16314, 27578, and 8976. Note: the patch set was already rebased partly to bug 7882 by someone (Maybe Ere) but the part for -foreach my $tag (@tab_data) { +foreach my $tag (sort @tab_data) { was missed. - Bug 8643 I only managed to partly rebase here because the change was so big, so I only did the same changes to addholding.pl but they would need to be done in addholding.tt as well for the warning prompt to show up when saving, now it only higlight the field as important. I think we cannot just copy&paste addbiblio.tt as addholding.tt so we need to get back to this later. - "Bug 25728: Create AV when cataloguing a bibliographic record" was not backported, too complicated. - Would be good to refactor the addholding.{pl,tt}, additem.{pl,tt}, addbiblio.{pl,tt} so the rebases won't be too hard. - I didn't confirm whether the rebase for bug 8976 is working, just added the same changes as there was for addbiblio.pl. The indicator issue is now resolved (because it was due to incorrect rebase earlier). The QA warnings and the warning in error log are still to be resolved. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Mar 18 Mar

9:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #409 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Selecting holding record in http://localhost:8081/cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1&biblionumber=248 page doesn't work. The dropdown menu for "k - Holdings record" is empty. It should be populated with the holdings records in the biblio record we are doing the order for. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Mar 19 Mar

2:02 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #420 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- QA tool failures are now fixed. But please note:

...

FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint The new column (suppress) for table holdings is using BOOLEAN as type, must be TINYINT(1) instead, see the SQL12 coding guideline

This is false positive, the QA script matches the word "Boolean" in SQL *comment* which says "Boolean indicating whether [...]". and also

...

FAIL Koha/Schema/Result/Holding.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666

seems false positive as well? The warning mentioned in comment 314 doesn't happen anymore. Not sure where it got fixed, maybe Koha::Object handling or DBIX stuff changed. Before setting this to NSO I think we want to fix the neworderempty.pl page mentioned in comment 409. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Mar 29 Mar

9:50 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #421 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Emptying 852$h subfield of holdings record doesn't empty the linked db entry in holdings.callnumber column. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Mar 31 Mar

1:16 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #422 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Currently when modifying a biblio in koha the old biblio revision is stored in action logs:

...

logaction( "CATALOGUING", "MODIFY", $biblionumber, "biblio BEFORE=>" . $newrecord->as_formatted );

This does not happen now with the holdings patches here. It used to be included in this patch set but the re-worked version of this (the holdings patches were originally made in C4/Holdings.pm) doesn't do this logging. It only logs "holdings" to the info field:

...

logaction('CATALOGUING', $action, $self->holding_id(), 'holding')

-- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Apr 7 Apr

bugzilla-daemon＠bugs.koha-community.org

14 Apr 14 Apr

2:43 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #445 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 119570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119570&action=edit Bug 20447: Return all Koha fields even if the value is empty The database columns are updated using the koha field values returned by this subroutine and if we don't return all of them (even the empty ones) the holdings table's database columns won't get emptied. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:43 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #446 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 119571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119571&action=edit Bug 20447: Return valid koha field values The legal values for holdings.suppress koha field are 0 and 1. This makes sure that illegal values cannot be returned. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Apr 17 Apr

3:02 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #447 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is FQA still correct here ? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Apr 19 Apr

3:45 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #448 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Katrin Fischer from comment #447)

...

Is FQA still correct here ?

Yes. There are some problems in mentioned in the earlier comments, at least the holdings being broken in acquisitions item adding. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 May 6 May

12:24 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #449 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- A new bug found: The holdings editor doesn't load by default the frameworkcode template defined in holdings.frameworkcode column, it always loads HLD / default framework regardless of this value. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

9:52 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #462 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Rebased the first patch "Bug 20447: MARC Holdings support". -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 May 22 May

4:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #463 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could this be a good addition to the road map? I think it would be a candidate for early integration next release. https://annuel.framapad.org/p/koha_21.11_roadmap -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 May 24 May

8:15 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #464 from Ere Maijala <ere.maijala@helsinki.fi> --- Katrin, Yes, that'd be great. If it was on the roadmap I'm sure I could allocate a bit more resources to any required cleanup and fixes as required. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:30 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #465 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ere Maijala from comment #464)

...

Katrin, Yes, that'd be great. If it was on the roadmap I'm sure I could allocate a bit more resources to any required cleanup and fixes as required.

You can put it on the road map :) See Jonathan's email from today on the mailing list. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:24 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #466 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Summary of remaining tasks to do: 1. The holdings editor doesn't load by default the frameworkcode template defined in holdings.frameworkcode column, it always loads HLD / default framework regardless of this value. 2. Holdings selection being broken in acquisitions item adding (the list is not populated). 3. Currently when modifying a biblio in koha the old biblio revision is stored in action logs:

...

logaction( "CATALOGUING", "MODIFY", $biblionumber, "biblio BEFORE=>" . $newrecord->as_formatted );

...

logaction('CATALOGUING', $action, $self->holding_id(), 'holding')

4. Verify if we need this or not: "- "Bug 25728: Create AV when cataloguing a bibliographic record" was not backported, too complicated." (from comment #408) 5. Squash some of the patches / follow-ups. Other notes: "Emptying 852$h subfield of holdings record doesn't empty the linked db entry in holdings.callnumber column." from comment #421 is fixed with "Return valid koha field values patch". -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 May 25 May

26 May 26 May

bugzilla-daemon＠bugs.koha-community.org

2:16 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

11:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

11:46 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24857 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:48 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #494 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm also wondering how this bug relates to bug 24857. The 'volumes' level added there appears to be at a similar level, though a totally different approach, to the record level introduced here. I'm wondering if the follow-on work that utilises Volumes could actually be achieved using holdings level records as an alternative.. I'm weary of having two very similar features added around the same time doing nearly the same thing but in entirely different ways.. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28715 [Bug 28715] Allow placing a hold for first item in a particular holding. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #495 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd love to see bug 28715 taken care of once this is pushed.. it feels like a real end goal for many of the competing bugs like this at the moment. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:38 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Jul 16 Jul

3:09 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #496 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Starting a new script (addholding.pl) copying addbiblio.pl was not the best idea ;) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:50 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #497 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Provide a full test plan and release notes please. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

3 Aug 3 Aug

9:30 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214 [Bug 8214] Create a bound with function -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Aug 16 Aug

3:16 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #521 from Ere Maijala <ere.maijala@helsinki.fi> --- Eww... As far as I can see, bug 24857 looks like a subset of proper holdings records. It's a lot of semi-duplicate work... I'll pick up from where Joonas got things. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 Aug 23 Aug

11:22 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

11:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

11:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

11:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123058|0 |1 is obsolete| | --- Comment #525 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 124015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124015&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

11:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

11:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

11:25 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #529 from Ere Maijala <ere.maijala@helsinki.fi> --- Martin, should be working now. Joonas did most of the work, and I fixed a typo in "Fixes for bug 17600" patch and holdings XML creation for XSLT. ALso rebased to fix expected test counts. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Sep 3 Sep

4:04 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Bug 20447 depends on bug 22690, which changed state. Bug 22690 Summary: Merging records with many items too slow (Elasticsearch) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Sep 6 Sep

1:07 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #530 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Ere Maijala from comment #521)

...

Eww... As far as I can see, bug 24857 looks like a subset of proper holdings records. It's a lot of semi-duplicate work...

I'll pick up from where Joonas got things.

There are a whole set of bugs around item grouping at the moment.. all doing similar things but not exactly the same. * The volumes one, which has now been renamed to 'Item groups' for clarity is for grouping items within a bib record so you can place a group level hold. * The bundles one is for grouping items from different bibs into a new bib for loaning as a set with automatic withdrawal from normal circulation otherwise. I'm not entirely sure I'm close enough to MARC Holdings to know how/where it is used or how it may overlap, be a superset or subset of the other two bugs. There's also been lots of work to improve our handling of Component Parts and Volume linked records (i.e. 773 and friends) See bug 11175. I'll try to take another look at this soon but my brain is a bit of a mess trying to distinguish between all these features. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:56 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11175 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28854 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24860 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

16 Sep 16 Sep

12:04 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #532 from Ere Maijala <ere.maijala@helsinki.fi> --- Martin, As far as I can see, bundles is a different but useful case. However, it seems that bug 24857 is kind of a subset of what holdings records would be (if properly embraced), though as there's no RFC or much more information on how the item groups work, I can't say for sure. What I can say is that it doesn't make sense to have two methods that allow for grouping items in a bib. The main advantage of holdings records compared to item groups is that they can also exist without items and provide useful summary holdings information about items that have not been individually catalogued. And since holdings records are a standard thing among MARC records, there are other systems that support them as well. Since item groups has passed QA, I assume it's to be merged soon. At this point I'll have to reconsider what to do here. I'm must admit that I'm somewhat discombobulated (yes, I finally got to use the word!) as to how to proceed. It might be possible to make summary holdings work with item groups without making a complete mess, but the relationship between the two will need a lot of work. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #533 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Ere Maijala from comment #532)

...

Since item groups has passed QA, I assume it's to be merged soon. At this point I'll have to reconsider what to do here. I'm must admit that I'm somewhat discombobulated (yes, I finally got to use the word!) as to how to proceed. It might be possible to make summary holdings work with item groups without making a complete mess, but the relationship between the two will need a lot of work.

Did you raise your points on that bug too? Without knowing all details, this sounds like a serious argument to postpone pushing that one?

...

discombobulated

I was so confused that I had to lookup that one ;) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:12 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #534 from Ere Maijala <ere.maijala@helsinki.fi> --- (In reply to Marcel de Rooy from comment #533)

...

Did you raise your points on that bug too? Without knowing all details, this sounds like a serious argument to postpone pushing that one?

I've now added a comment to raise awareness. I'd like to keep the discussion in one place, though. And I'm not quite sure how to approach this all.

...

...
discombobulated

I was so confused that I had to lookup that one ;)

Ha! :D -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:35 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #535 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Indeed.. this is a very complicated set of features and I agree we certainly need to think about them as a complimentary pair. Tomas is keen to talk and help this area move forward too having taken over the Item groups piece. My hope is we can come up with some way of achieving the best for everyone. I have my doubts as to whether the Item groups stuff will be pushed this cycle.. I couldn't fail it in due conscience as it all works well enough and I couldn't see that it would block this work.. but I can definitely see how they are competitive and thus this needs taking into context before final push. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Sep 17 Sep

9:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

9:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

9:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

9:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124015|0 |1 is obsolete| | --- Comment #539 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 124947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124947&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

9:44 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

9:44 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

9:45 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #543 from Ere Maijala <ere.maijala@helsinki.fi> --- Rebased and fixed displaying of holdings records in OPAC results when there are no items. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:42 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #544 from Ere Maijala <ere.maijala@helsinki.fi> --- (In reply to Martin Renvoize from comment #535)

...

Indeed.. this is a very complicated set of features and I agree we certainly need to think about them as a complimentary pair.

Tomas is keen to talk and help this area move forward too having taken over the Item groups piece. My hope is we can come up with some way of achieving the best for everyone. I have my doubts as to whether the Item groups stuff will be pushed this cycle.. I couldn't fail it in due conscience as it all works well enough and I couldn't see that it would block this work.. but I can definitely see how they are competitive and thus this needs taking into context before final push.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #554 from Andrew Nugged <nugged@gmail.com> --- I did rebase because changes in Bug 29135 messed up with this a lot, Ere, please check behind me. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Oct 14 Oct

5:43 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #555 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126296&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Oct 16 Oct

12:22 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #556 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126391&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:22 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #557 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126392&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:20 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

1:20 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #559 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126395&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #560 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126396&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #561 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126397&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #562 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126398&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #563 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126399&action=edit Bug 20447: Fixes for bug 17600 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #564 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126400&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:21 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #565 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126401&action=edit Bug 20447: (QA follow-up) Unify SQL queries formatting -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:22 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #566 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126402&action=edit Bug 20447: (QA follow-up) Change 3 pushes to `() x 3` for readability -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:22 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #567 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126403&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:22 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #568 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126404&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:22 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #569 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126405&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:24 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #570 from Andrew Nugged <nugged@gmail.com> --- Rebase was because of changes in the Bug 29135 and further, now I added patches and fixes, and rebased finally for patches to be consistent on the current master. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:26 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #571 from Andrew Nugged <nugged@gmail.com> --- ... and did some obsoletion for attachment-useless messages. Now it's easy to QA if this will even be (I am sure it will :) ). Also, I think we need to put 11175 as "this 20447 based on 11175", I have too many conflicts when I gluing both together on my preproduction branch, and I know how to glue them so I can make this (rebase on top of 11175). Martin: let's put 11175 as dependency here? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Oct 26 Oct

10:17 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

10:17 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #573 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126933&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:17 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #574 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126934&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:17 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #575 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126935&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #576 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126936&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #577 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126937&action=edit Bug 20447: Fixes for bug 17600 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #578 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126938&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #579 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126939&action=edit Bug 20447: (QA follow-up) Unify SQL queries formatting -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #580 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126940&action=edit Bug 20447: (QA follow-up) Change 3 pushes to `() x 3` for readability -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:18 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #581 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126941&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:19 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #582 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126942&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:19 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #583 from Andrew Nugged <nugged@gmail.com> --- Created attachment 126943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126943&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:24 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #584 from Andrew Nugged <nugged@gmail.com> --- Bug 11175 in master, so I rebased this one to be aligned with the latest master now. Note for Ere/Martin: additem.pl "sub generate_subfield_form" part with "elsif ( $subfieldlib->{authorised_value} eq "holdings" )" block moved to Koha::UI::Form::Builder::Item -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Oct 28 Oct

12:08 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #585 from Andrew Nugged <nugged@gmail.com> --- Created attachment 127040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127040&action=edit Bug 20447: (QA follow-up) Fix full-path call for xml_escape -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Nov 29 Nov

3:40 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #586 from Andrew Nugged <nugged@gmail.com> --- Created attachment 128079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128079&action=edit Bug 20447: (QA follow-up) Remove undef warnings and add UX note Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/Koha/UI/Form/Builder/Item.pm line 255. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Dec 1 Dec

4:03 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #587 from Andrew Nugged <nugged@gmail.com> --- Created attachment 128131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128131&action=edit Bug 20447: (QA follow-up) wrong include place for Koha::Holdings -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #588 from Andrew Nugged <nugged@gmail.com> --- Created attachment 128134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128134&action=edit Bug 20447: (QA follow-up) undefined $mode warning remove When POST /intranet/cataloguing/addholding.pl happens from any /cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Feb 16 Feb

9:12 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #589 from Michal Denar <black23@gmail.com> --- Andrew, can you update this bug on top of master? Thanks -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Feb 17 Feb

6:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #590 from Andrew Nugged <nugged@gmail.com> --- yes, also I have two more small bug fixes related. Will do both things tonight -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Feb 18 Feb

3:41 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

bugzilla-daemon＠bugs.koha-community.org

3:41 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #592 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130777&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #593 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130778&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #594 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130779&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #595 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130780&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #596 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130781&action=edit Bug 20447: Fixes for bug 17600 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:42 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #597 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130782&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #598 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130783&action=edit Bug 20447: (QA follow-up) Unify SQL queries formatting -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #599 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130784&action=edit Bug 20447: (QA follow-up) Change 3 pushes to `() x 3` for readability -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #600 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130785&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #601 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130786&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:43 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #602 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130787&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:44 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #603 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130788&action=edit Bug 20447: (QA follow-up) Fix full-path call for xml_escape -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:44 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #604 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130789&action=edit Bug 20447: (QA follow-up) Remove undef warnings and add UX note Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/Koha/UI/Form/Builder/Item.pm line 255. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:44 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #605 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130790&action=edit Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:44 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #606 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130791&action=edit Bug 20447: (QA follow-up) undefined $mode warning remove When POST /intranet/cataloguing/addholding.pl happens from any /cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:47 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:47 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #607 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130792&action=edit Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= we don't have 'framework' param parsed in addholding.pl -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:47 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #608 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130793&action=edit Bug 20447: (QA follow-up) bugfix: holding_id not transferred down from params and not taken into account -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:47 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #609 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130794&action=edit Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:47 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #610 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130795&action=edit Bug 20447: (QA follow-up) UX improvement: values merge point requested to be invisible by customers, i.e. no pipe separate char between (librarians said they using it also for copy-pasting, and it confuses patrons because they read roman numbers with this -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:47 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #611 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130796&action=edit Bug 20447: (QA follow-up) Warning suppression, tab might be undefined (sidenote: probably tags->subfields->tabs structures should be defined more) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:48 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #612 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130797&action=edit Bug 20447: (QA follow-up) bugfix: undefined holding_id in code after storing to db not allows for interface to go back to newly created holding -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:48 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #613 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130798&action=edit Bug 20447: (QA follow-up) Warning removal: undef param 'sep' expected to be string in further processing -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3:48 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #614 from Andrew Nugged <nugged@gmail.com> --- Created attachment 130799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130799&action=edit Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. Note / bigger bug: this happened only for first added item, all next other items in same basket were added without sending biblionumber as in original Koha code: so, this is very suspicious change without any person to explain why. This rolled-back code looks like unfinished feature or mistake. So I will leave this comment especially for future checks, if extension or this feature development will be needed. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #623 from Andrew Nugged <nugged@gmail.com> --- Rebased. Also all recent bugfixes and QA followups I had published. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Mar 8 Mar

2:23 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #624 from Nick Clemens <nick@bywatersolutions.com> --- Testing this alongside 24857 I do not think these are conflicting features - there could be more tie in between them, but the use cases are very different. The RFC here says this is largely for serial/multipart items - and it works well for that. It supports MARC for import/export and displays in the results, and adds info, even if no items are present Bug 24857 is largely aimed at monographic records - allowing libraries to internally and easily create groups of items that can then be dealt with as a group for holds. It does not require additional cataloging, nor do they display, they are logical groupings for holds purposes (with bug 24860) I don't believe a library would want to implement both features at the same time, if there was call for that then they could be more integrated (connect holding to group or vice versa) but I think as base features both stand alone -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130776|0 |1 is obsolete| | Attachment #130777|0 |1 is obsolete| | Attachment #130778|0 |1 is obsolete| | Attachment #130779|0 |1 is obsolete| | Attachment #130780|0 |1 is obsolete| | Attachment #130781|0 |1 is obsolete| | Attachment #130782|0 |1 is obsolete| | Attachment #130783|0 |1 is obsolete| | Attachment #130784|0 |1 is obsolete| | Attachment #130785|0 |1 is obsolete| | Attachment #130786|0 |1 is obsolete| | Attachment #130787|0 |1 is obsolete| | Attachment #130788|0 |1 is obsolete| | Attachment #130789|0 |1 is obsolete| | Attachment #130790|0 |1 is obsolete| | Attachment #130791|0 |1 is obsolete| | Attachment #130800|0 |1 is obsolete| | Attachment #130801|0 |1 is obsolete| | Attachment #130802|0 |1 is obsolete| | Attachment #130803|0 |1 is obsolete| | Attachment #130804|0 |1 is obsolete| | Attachment #130805|0 |1 is obsolete| | Attachment #130806|0 |1 is obsolete| | Attachment #130807|0 |1 is obsolete| | --- Comment #625 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131458&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:29 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #626 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131459&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #627 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131460&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #628 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131461&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #629 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131462&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #630 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131463&action=edit Bug 20447: Fixes for bug 17600 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:30 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #631 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131464&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #632 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131465&action=edit Bug 20447: (QA follow-up) Unify SQL queries formatting Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #633 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131466&action=edit Bug 20447: (QA follow-up) Change 3 pushes to `() x 3` for readability Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #634 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131467&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #635 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131468&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #636 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131469&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:31 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #637 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131470&action=edit Bug 20447: (QA follow-up) Fix full-path call for xml_escape Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #638 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131471&action=edit Bug 20447: (QA follow-up) Remove undef warnings and add UX note Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/Koha/UI/Form/Builder/Item.pm line 255. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #639 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131472&action=edit Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #640 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131473&action=edit Bug 20447: (QA follow-up) undefined $mode warning remove When POST /intranet/cataloguing/addholding.pl happens from any /cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #641 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131474&action=edit Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= we don't have 'framework' param parsed in addholding.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #642 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131475&action=edit Bug 20447: (QA follow-up) bugfix: holding_id not sent down from params and was not taken into account Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #643 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131476&action=edit Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #644 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131477&action=edit Bug 20447: (QA follow-up) UX improvement: merge point of values should be invisible. This is requested by customers, i.e. no pipe separate char between (librarians said they using it also for copy-pasting, and it confuses patrons because they read roman numbers with this | wrongly) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #645 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131478&action=edit Bug 20447: (QA follow-up) Warning suppression tab might be undefined (sidenote: probably tags->subfields->tabs structures should be defined more) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:33 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #646 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131479&action=edit Bug 20447: (QA follow-up) bugfix: undefined holding_id in code on store After saving to DB code didn't get back "last inserted ID" so wasn't able to allow for interface to go back to newly created holding ID Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #647 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131480&action=edit Bug 20447: (QA follow-up) Warning removal: undef param 'sep' expected to be string in further processing Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #648 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131481&action=edit Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. Note / bigger bug: this happened only for first added item, all next other items in same basket were added without sending biblionumber as in original Koha code: so, this is very suspicious change without any person to explain why. This rolled-back code looks like unfinished feature or mistake. So I will leave this comment especially for future checks, if extension or this feature development will be needed. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:34 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #649 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131482&action=edit Bug 20447: (follow-up) Get frameworks as list Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Apr 24 Apr

11:56 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #650 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- At the moment this patch set doesn't apply, but it might make sense to wait with the rebase until 22.05 is out the door and then make a focused effort. Unfortunately we only have a week now until soft feature freeze and I feel this would be too huge to get tested well in this timeframe :( Applying: Bug 20447: MARC Holdings support Using index info to reconstruct a base tree... M C4/Biblio.pm M C4/ImportBatch.pm M C4/Items.pm M C4/Search.pm M C4/XSLT.pm M Koha/Biblio.pm M Koha/Item.pm M catalogue/detail.pl M cataloguing/additem.pl M installer/data/mysql/kohastructure.sql M installer/data/mysql/mandatory/auth_val_cat.sql M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt M koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl M t/db_dependent/Koha/Biblio.t M t/db_dependent/Koha/Item.t M t/lib/TestBuilder.pm M tools/stage-marc-import.pl Falling back to patching base and 3-way merge... Auto-merging tools/stage-marc-import.pl Auto-merging t/lib/TestBuilder.pm Auto-merging t/db_dependent/Koha/Item.t Auto-merging t/db_dependent/Koha/Biblio.t Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging installer/data/mysql/mandatory/auth_val_cat.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging cataloguing/additem.pl Auto-merging catalogue/detail.pl Auto-merging Koha/Item.pm Auto-merging Koha/Biblio.pm CONFLICT (content): Merge conflict in Koha/Biblio.pm Auto-merging C4/XSLT.pm Auto-merging C4/Search.pm Auto-merging C4/Items.pm Auto-merging C4/ImportBatch.pm Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20447: MARC Holdings support hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20447-MARC-Holdings-support-BYfeaD.patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 May 4 May

9:51 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #651 from Andrew Nugged <nugged@gmail.com> --- I will rebase, this one is in our production so it's important. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Aug 28 Aug

12:07 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #652 from Andrew Nugged <nugged@gmail.com> --- I am now doing intermediate rebase, this one will go on tag v22.04.05 (commit hash 75372f012b4ecc321a0658f22ae4f3700502f018). Intermediate, because in the next step after below pre-rebase (pre- because not yet on current master), I plan to squash and re-factor TOO BIG to debug and do future rebasings code, and this will help us to rebase & sign off much cleaner code later. And also, it will include 7 more (!) bug fixes patches over the current state of the things above. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:17 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131458|0 |1 is obsolete| | Attachment #131459|0 |1 is obsolete| | Attachment #131460|0 |1 is obsolete| | Attachment #131461|0 |1 is obsolete| | Attachment #131462|0 |1 is obsolete| | Attachment #131463|0 |1 is obsolete| | Attachment #131464|0 |1 is obsolete| | Attachment #131465|0 |1 is obsolete| | Attachment #131466|0 |1 is obsolete| | Attachment #131467|0 |1 is obsolete| | Attachment #131468|0 |1 is obsolete| | Attachment #131469|0 |1 is obsolete| | Attachment #131470|0 |1 is obsolete| | Attachment #131471|0 |1 is obsolete| | Attachment #131472|0 |1 is obsolete| | Attachment #131473|0 |1 is obsolete| | Attachment #131474|0 |1 is obsolete| | Attachment #131475|0 |1 is obsolete| | Attachment #131476|0 |1 is obsolete| | Attachment #131477|0 |1 is obsolete| | Attachment #131478|0 |1 is obsolete| | Attachment #131479|0 |1 is obsolete| | Attachment #131480|0 |1 is obsolete| | Attachment #131481|0 |1 is obsolete| | Attachment #131482|0 |1 is obsolete| | --- Comment #653 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139865&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Co-authored-by: Andrew Nugged <nugged@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:17 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #654 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139866&action=edit Bug 20447: Add holding_id to REST API item definition Allows items to be properly returned, including the holding_id field. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:17 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #655 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139867&action=edit Bug 20447: Add a batch rebuild script for holdings table This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:17 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #656 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139868&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:17 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #657 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139869&action=edit Bug 20447: (QA follow-up) Update for bug 26703 Reverse the title element content as per updated guidelines. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:18 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #658 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139870&action=edit Bug 20447: Fixes for bug 17600 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:18 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #659 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139871&action=edit Bug 20447: DBIX schema changes Rebased-by: Andrew Nugged <nugged@gmail.com> Rebased-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:18 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #660 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139872&action=edit Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:18 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #661 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139873&action=edit Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:18 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #662 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139874&action=edit Bug 20447: (QA follow-up) Fix framework switching bug Form's parameter never used because $record was always defined, with new or with existing holding, but always. Fixed by adding incoming $holding_id presence check. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:19 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #663 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139875&action=edit Bug 20447: (QA follow-up) Fix full-path call for xml_escape Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:19 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #664 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139876&action=edit Bug 20447: (QA follow-up) Remove undef warnings and add UX note Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/Koha/UI/Form/Builder/Item.pm line 255. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:19 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #665 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139877&action=edit Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:19 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #666 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139878&action=edit Bug 20447: (QA follow-up) undefined $mode warning remove When POST /intranet/cataloguing/addholding.pl happens from any /cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:19 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #667 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139879&action=edit Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= we don't have 'framework' param parsed in addholding.pl Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:19 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #668 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139880&action=edit Bug 20447: (QA follow-up) bugfix: holding_id not sent down from params and was not taken into account Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:20 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #669 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139881&action=edit Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:20 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #670 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139882&action=edit Bug 20447: (QA follow-up) UX improvement: merge point of values should be invisible. This is requested by customers, i.e. no pipe separate char between (librarians said they using it also for copy-pasting, and it confuses patrons because they read roman numbers with this | wrongly) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:20 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #671 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139883&action=edit Bug 20447: (QA follow-up) Warning suppression tab might be undefined (sidenote: probably tags->subfields->tabs structures should be defined more) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:20 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #672 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139884&action=edit Bug 20447: (QA follow-up) bugfix: undefined holding_id in code on store After saving to DB code didn't get back "last inserted ID" so wasn't able to allow for interface to go back to newly created holding ID Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:20 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #673 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139885&action=edit Bug 20447: (QA follow-up) Warning removal: undef param 'sep' expected to be string in further processing Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:21 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #674 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139886&action=edit Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. Note / bigger bug: this happened only for first added item, all next other items in same basket were added without sending biblionumber as in original Koha code: so, this is very suspicious change without any person to explain why. This rolled-back code looks like unfinished feature or mistake. So I will leave this comment especially for future checks, if extension or this feature development will be needed. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:21 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #675 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139887&action=edit Bug 20447: (follow-up) Get frameworks as list Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:21 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #676 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139888&action=edit Bug 20447: (QA follow-up) Fix compatibility to 22.05 Fix to conform with 22.05 Koha::Object's 'search' wantarray removal ( https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 ) -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:21 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #677 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139889&action=edit Bug 20447: (QA follow-up) Fix atomic update to be more idempotent Fix atomic update not to add bad ACQ 952k row into marc_subfield_structure when no ACQ present at all -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:21 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #678 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139890&action=edit Bug 20447: (QA follow-up) Whitespaces in .css file fixes -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:21 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #679 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139891&action=edit Bug 20447: (QA follow-up) .css file alignment as in addbiblio.css -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:22 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #680 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139892&action=edit Bug 20447: (QA follow-up) detail.tt rebase cimpatibility fixes -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:22 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #681 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139893&action=edit Bug 20447: (QA follow-up) addholding.tt rebase compatibility fixes -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:22 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #682 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139894&action=edit Bug 20447: (QA follow-up) Show blocking full-screen error if biblio record removed elsewhere (biblio id not found). Rebased-by: Andrew Nugged <nugged@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:40 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #683 from Andrew Nugged <nugged@gmail.com> --- Now I will combine changes into less scattered code and a smaller number of patches (also because I am now co-authoring this task for a while). Because so many patches patch other patches :) and evolutionary old master branch compatibility changes should be just in 1st commit, so this burden is mostly impossible to rebase over the current master (but we need to). This should help. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:06 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139865|0 |1 is obsolete| | Attachment #139866|0 |1 is obsolete| | Attachment #139867|0 |1 is obsolete| | Attachment #139868|0 |1 is obsolete| | Attachment #139869|0 |1 is obsolete| | Attachment #139870|0 |1 is obsolete| | Attachment #139871|0 |1 is obsolete| | Attachment #139872|0 |1 is obsolete| | Attachment #139873|0 |1 is obsolete| | Attachment #139874|0 |1 is obsolete| | Attachment #139875|0 |1 is obsolete| | Attachment #139876|0 |1 is obsolete| | Attachment #139877|0 |1 is obsolete| | Attachment #139878|0 |1 is obsolete| | Attachment #139879|0 |1 is obsolete| | Attachment #139880|0 |1 is obsolete| | Attachment #139881|0 |1 is obsolete| | Attachment #139882|0 |1 is obsolete| | Attachment #139883|0 |1 is obsolete| | Attachment #139884|0 |1 is obsolete| | Attachment #139885|0 |1 is obsolete| | Attachment #139886|0 |1 is obsolete| | Attachment #139887|0 |1 is obsolete| | Attachment #139888|0 |1 is obsolete| | Attachment #139889|0 |1 is obsolete| | Attachment #139890|0 |1 is obsolete| | Attachment #139891|0 |1 is obsolete| | Attachment #139892|0 |1 is obsolete| | Attachment #139893|0 |1 is obsolete| | Attachment #139894|0 |1 is obsolete| | --- Comment #684 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139895&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Smaller notes to task parts (batch rebuild script): --- Includes misc/batchRebuildHoldingsTables.pl: a batch rebuild script for holdings table which can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. --- End of smaller notes Sponsored-by: The National Library of Finland Co-authored-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Co-authored-by: Andrew Nugged <nugged@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:07 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #685 from Andrew Nugged <nugged@gmail.com> --- Created attachment 139896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139896&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:10 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #686 from Andrew Nugged <nugged@gmail.com> --- All intermediate patches were obsoleted and merged into the final solution, as explained in comment #683 (this is for history to note how it was before): 139865 - Bug 20447: MARC Holdings support 139866 - Bug 20447: Add holding_id to REST API item definition 139867 - Bug 20447: Add a batch rebuild script for holdings table 139868 - Bug 20447: Add import/export support for holdings 139869 - Bug 20447: (QA follow-up) Update for bug 26703 139870 - Bug 20447: Fixes for bug 17600 139871 - Bug 20447: DBIX schema changes 139872 - Bug 20447: (QA follow-up) SummaryHoldings preferences should be 1/0 139873 - Bug 20447: (QA follow-up) Remove warning when frameworkcode is undef 139874 - Bug 20447: (QA follow-up) Fix framework switching bug 139875 - Bug 20447: (QA follow-up) Fix full-path call for xml_escape 139876 - Bug 20447: (QA follow-up) Remove undef warnings and add UX note 139877 - Bug 20447: (QA follow-up) include Koha::Holdings where needed (and remove uses where don't) 139878 - Bug 20447: (QA follow-up) undefined $mode warning remove 139879 - Bug 20447: (QA follow-up) typo, framework= should be frameworkcode= 139880 - Bug 20447: (QA follow-up) bugfix: holding_id not sent down from params 139881 - Bug 20447: (QA follow-up) bugfix: itemcallnumber pref wasn't taken into account 139882 - Bug 20447: (QA follow-up) UX improvement: merge point of values should be invisible. 139883 - Bug 20447: (QA follow-up) Warning suppression 139884 - Bug 20447: (QA follow-up) bugfix: undefined holding_id in code on store 139885 - Bug 20447: (QA follow-up) Warning removal: undef 139886 - Bug 20447: (QA follow-up) Bugfix: Do not force first item for acqorder from biblionumber, but use framework. 139887 - Bug 20447: (follow-up) Get frameworks as list 139888 - Bug 20447: (QA follow-up) Fix compatibility to 22.05 139889 - Bug 20447: (QA follow-up) Fix atomic update to be more idempotent 139890 - Bug 20447: (QA follow-up) Whitespaces in .css file fixes 139891 - Bug 20447: (QA follow-up) .css file alignment as in addbiblio.css 139892 - Bug 20447: (QA follow-up) detail.tt rebase cimpatibility fixes 139893 - Bug 20447: (QA follow-up) addholding.tt rebase compatibility fixes 139894 - Bug 20447: (QA follow-up) Show blocking full-screen error if biblio record removed elsewhere (biblio id not found). -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2:14 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #687 from Andrew Nugged <nugged@gmail.com> --- The above is still based on tag v22.04.05 (commit hash 75372f012b4ecc321a0658f22ae4f3700502f018). Now I am doing rebase to the latest master. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Jan 31 Jan

9:31 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

30 Jun 30 Jun

10:46 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #688 from Michal Denar <black23@gmail.com> --- Any news? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

15 Aug 15 Aug

2:02 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com | |, | |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:31 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #694 from Andrii Nugged <nugged@gmail.com> --- PerlKohaCon.fi talk by this topic: " ... about Holdings what are those and how they are used when items are not enough: in our case in the National Library in Finland. Why do we need to have Holdings and then something about Holdings in Koha in general, and what kind of improvements we do need to use those better ones, ... " is here: https://www.youtube.com/watch?v=d2i1dW9CKAs&list=PLa9kvrI3VLf7ZvLvJk9EtlnF2OVETvddm&index=20 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

16 Dec 16 Dec

12:23 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #695 from Andrii Nugged <nugged@gmail.com> --- (In reply to Michal Denar from comment #688) Michal, can you check this: https://wiki.koha-community.org/wiki/Road_map_24.05#Project_proposals -> Project proposals -> Add support for MARC holdings records. Others who are also interested in this feature appear: we need more supporters in one week there, so if there is enough support, this ticket will be included in the 24.05 plan. Please sign in there. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Dec 18 Dec

8:01 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Apr 11 Apr

4:57 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |laurence.rault@biblibre.com --- Comment #696 from Laurence Rault <laurence.rault@biblibre.com> --- merge conflicts in applying in ktd -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9 May 9 May

4:19 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:58 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 JillDye <j.dye@nms.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.dye@nms.ac.uk -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

19 Aug 19 Aug

9:46 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #697 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #691)

...

I believe it would be better to focus on this one right after the release and try to get it pushed early for 24.05.

Looks like that didn't happen. Maybe 24.11? What is the status here, apart from "Patch does not apply"? Is anyone willing to rebase/update the patches? As far as I can see, there are already signoffs from the current QAM and another member of the QA team, so this should not be too far off from passing QA, if the patches could be updated? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:52 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #698 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Magnus Enger from comment #697)

...

(In reply to Katrin Fischer from comment #691)

...
I believe it would be better to focus on this one right after the release and try to get it pushed early for 24.05.

Looks like that didn't happen. Maybe 24.11?

What is the status here, apart from "Patch does not apply"? Is anyone willing to rebase/update the patches? As far as I can see, there are already signoffs from the current QAM and another member of the QA team, so this should not be too far off from passing QA, if the patches could be updated?

Yes, I think in order to make this to happen we a joint effort of the patch writers, tester and QA team. As it's been sitting for a while, we certainly want to do another run through before pushing. I am open to do it still, but we need to hurry up. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Sep 11 Sep

3:59 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #699 from Andrii Nugged <nugged@gmail.com> --- OKAY! I will publish this week rebased and adopted to 24.05 and then the current "main" (24.06/11) compatible code. Then, there is the list of "TODO"s (leftovers and weak parts) which I will note here. Then I want the community to help us to clean up and push it to QA-quality-passed code. Working now. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:07 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #700 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Have you been in touch with with some people about coordinating testing and QA? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Sep 12 Sep

11:35 a.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #701 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrii, I have given this some thought and after checking in with QA manager and others: * It is a big feature and wasn't put on the roadmap for 24.11. At the moment we have a backlog of features that are waiting for testing and QA and ongoing roadmap projects to finish. It is too late for the 24.11 cycle. * The code for this is many years old now and doesn't follow current coding standards and best practices. This needs to be tackled first before an integration will be feasible. * You need to ensure there is enough commitment from different parties in the community to make sure this can be seen through. This means getting commitment from parties outside your institution for testing and QA. This is also important as we need to ensure that there is a long term commitment on maintaining the feature. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Nov 21 Nov

3:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 Aug 4 Aug

6:25 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 ashley.day@rcm.ac.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ashley.day@rcm.ac.uk -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10 Feb 10 Feb

11:32 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Jun 26 Jun

12:01 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8214 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214 [Bug 8214] Create a bound with function -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:01 p.m.

New subject: [Bug 20447] Add support for MARC holdings records

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8214 -- You are receiving this mail because: You are watching all bug changes.

Age (days ago)

3039

Last active (days ago)

List overview

Download

766 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org