[Bug 40542] New: Add `cancellation_reason` to holds strings embed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Bug ID: 40542 Summary: Add `cancellation_reason` to holds strings embed Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Bug 33568 introduced the `Koha::Hold->strings_map` method which is only used for embedding srings in the biblios endpoint. The holds-related endpoint themselves don't use it. We should add `+strings` for using it in bug 40530. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on| |33568 Blocks| |40530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40530 [Bug 40530] Show hold cancellation reason in patron holds history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184810&action=edit Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184811&action=edit Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40543 [Bug 40543] pickup_library.branchname embed wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184810|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 184836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184836&action=edit Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184811|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 184837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184837&action=edit Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Bug 40542 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40543 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40543 [Bug 40543] pickup_library.branchname embed wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184836|0 |1 is obsolete| | Attachment #184837|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184881&action=edit Bug 40542: Add cancellation_reason to Koha::Hold->strings_map This patch adds the mentioned AV to the returned strings structure. It also adds tests for the method. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184882&action=edit Bug 40542: Add strings embed to holds-related endpoints This patch makes holds endpoints be allowed to embed strings. To test: 1. Use your favourite REST tool to hit /api/v1/holds 2. Add the `x-koha-embed: +strings` header. => FAIL: The API rejects because it is not equiped with the feature. 3. Apply this patches 4. Run: $ ktd --shell k$ yarn api:bundle k$ koha-plack --restart kohadev 5. Repeat 2 => SUCCESS: It works! 6. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This is causing KohaTable/PendingHolds_spec.ts tests to fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 185074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185074&action=edit Bug 40542: (40174 follow-up) Skip _strings for object creation Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | Status|Needs documenting |Pushed to oldstable --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #12)
Enhancement not pushed to 24.11.x
Ah but needed for Bug 40530 so I backport Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> ---
Pushed to 24.11.x for 24.11.09
Note that this patch is not backported because Bug 40174 not in 24.11.x : Bug 40542: (40174 follow-up) Skip _strings for object creation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40542 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #16 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- The API is self documenting. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org