[Bug 38544] New: OPAC Modal auth should not exist when OPAC auth is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Bug ID: 38544 Summary: OPAC Modal auth should not exist when OPAC auth is disabled Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org When OPAC auth is disabled (system preference opacuserlogin), the modal auth should not exist in HTML. The access to opac-user.pl shows a message and not auth form. But this has been detected by a security check. So better not have this form in modal. Looks like it is missing : [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC Modal auth should not |OPAC Modal login should not |exist when OPAC auth is |exist when OPAC login is |disabled |disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 175002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175002&action=edit Bug 38544: OPAC Modal login not generated when OPAC login is disabled When OPAC login is disabled (system preference opacuserlogin), the modal login should not exist in HTML. Note the access to opac-user.pl shows a message and not auth form. You may look at commit with : git diff --ignore-space-change Test plan : 1.1) Set system preference opacuserlogin to "Allow" 1.2) Go to OPAC main page 1.3) Check you see in source : div id="loginModal" 1.4) Click on "Log in to your account" 1.5) Check you see the modal login 2.1) Set system preference opacuserlogin to "Don't allow" 2.2) Go to OPAC main page 2.3) Check you do not see in source : div id="loginModal" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175002|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 175014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175014&action=edit Bug 38544: OPAC Modal login not generated when OPAC login is disabled When OPAC login is disabled (system preference opacuserlogin), the modal login should not exist in HTML. Note the access to opac-user.pl shows a message and not auth form. You may look at commit with : git diff --ignore-space-change Test plan : 1.1) Set system preference opacuserlogin to "Allow" 1.2) Go to OPAC main page 1.3) Check you see in source : div id="loginModal" 1.4) Click on "Log in to your account" 1.5) Check you see the modal login 2.1) Set system preference opacuserlogin to "Don't allow" 2.2) Go to OPAC main page 2.3) Check you do not see in source : div id="loginModal" Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- While the "Splinter Review" looks scary, if you do a "git show -w", you'll see it really is just a very simple 2-3 line change, which does exactly what it says it's going to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- And if I'd actually read the commit message, I would've seen that Frido already suggested something like that haha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Cook from comment #4)
And if I'd actually read the commit message, I would've seen that Frido already suggested something like that haha.
Great it helped ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175014|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175295&action=edit Bug 38544: OPAC Modal login not generated when OPAC login is disabled When OPAC login is disabled (system preference opacuserlogin), the modal login should not exist in HTML. Note the access to opac-user.pl shows a message and not auth form. You may look at commit with : git diff --ignore-space-change Test plan : 1.1) Set system preference opacuserlogin to "Allow" 1.2) Go to OPAC main page 1.3) Check you see in source : div id="loginModal" 1.4) Click on "Log in to your account" 1.5) Check you see the modal login 2.1) Set system preference opacuserlogin to "Don't allow" 2.2) Go to OPAC main page 2.3) Check you do not see in source : div id="loginModal" Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC Modal login should not |OPAC modal login should not |exist when OPAC login is |exist when OPAC login is |disabled |disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes the OPAC login release notes| |dialog box from the HTML | |when logging into the OPAC | |is turned off | |(opacuserlogin system | |preference), rather than | |just making it not visible. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Fridolin, This patchset conflicts when cherry-picked from 24.11.x to 24.05.x --- kohadev-koha@kohadevbox:koha(24.05.x)$ git cherry-pick 89c88244089bb9ede369d04541f73b91987efb9d Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc error: could not apply 89c88244089... Bug 38544: OPAC Modal login not generated when OPAC login is disabled hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ git status On branch 24.05.x You are currently cherry-picking commit 89c88244089. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Unmerged paths: (use "git add <file>..." to mark resolution) both modified: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc no changes added to commit (use "git add" and/or "git commit -a") kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ --- Could we please have a 24.05.x rebased patch attached to this bug report? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38544 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org