[Bug 38659] New: Cannot set a new suggestion manager when editing a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Bug ID: 38659 Summary: Cannot set a new suggestion manager when editing a suggestion Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38183 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38183 [Bug 38183] Can't set suggestion manager when there are multiple tabs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Bug 38183 didn't create the problem but it didn't help fix it either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175339&action=edit Bug 38659: Fix select_manager function when there are no tabs To test: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one. 6. APPLY PATCH 7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion. 8. Go through the test plan on Bug 38659. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175339|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175346&action=edit Bug 38659: Fix select_manager function when there are no tabs To test: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one. 6. APPLY PATCH 7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion. 8. Go through the test plan on Bug 38183. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather@bywatersolutions.co | |m --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 38539 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175346|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175568&action=edit Bug 38659: Fix select_manager function when there are no tabs To test: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one. 6. APPLY PATCH 7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion. 8. Go through the test plan on Bug 38183. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Bug 38659 depends on bug 38183, which changed state. Bug 38183 Summary: Can't set suggestion manager when there are multiple tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38183 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixing editing release notes| |suggestions in the staff | |interface so that you can | |now change the suggestion | |manager. Previously, you | |could select the new | |suggestion manager, but the | |managed by field wasn't | |updated or saved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com --- Comment #7 from Laura O'Neil <laura@bywatersolutions.com> --- Can this patch be backported to 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixing editing |This fixing editing release notes|suggestions in the staff |suggestions in the staff |interface so that you can |interface so that you can |now change the suggestion |now change the suggestion |manager. Previously, you |manager. (You could select |could select the new |the new suggestion manager, |suggestion manager, but the |but the managed by field |managed by field wasn't |wasn't updated or saved.) |updated or saved. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Sheri Waite <swaite@marshallpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |swaite@marshallpl.org --- Comment #8 from Sheri Waite <swaite@marshallpl.org> --- My staff would love it if this could be backported to 24.11. Or could this patch be applied to my Koha now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Sheri Waite from comment #8)
My staff would love it if this could be backported to 24.11. Or could this patch be applied to my Koha now?
Bug fixes are usually backported, but it's always good to know that there is interest for the RMaint when thy make the final decision. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixing editing |This fixes editing release notes|suggestions in the staff |suggestions so that you can |interface so that you can |change the suggestion |now change the suggestion |manager in the staff |manager. (You could select |interface. Previously, you |the new suggestion manager, |could select a new |but the managed by field |suggestion manager, but the |wasn't updated or saved.) |managed by field wasn't | |updated or saved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Lucas, When I cherry-pick this patch from 24.11.x to 24.05.x it conflicts (see below): --- kohadev-koha@kohadevbox:koha(24.05.x)$ git cherry-pick 65c1d6ccf8d76e919db2fb18977e4299dbb297b2 Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt error: could not apply 65c1d6ccf8d... Bug 38659: Fix select_manager function when there are no tabs hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ git status On branch 24.05.x You are currently cherry-picking commit 65c1d6ccf8d. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Unmerged paths: (use "git add <file>..." to mark resolution) both modified: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Untracked files: --- Could you please attach a 24.05.x patch to this bug report? Thanks in advance, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38659 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org