http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |philippe.blouin@inlibro.com Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |simith.doliveira@inlibro.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understand DefaultNoticeFee - but I am not sure about putting a variable for the notices system into a system preference. Wouldn't it be better if the library could just add the note as part of the notice configuration in the text? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #3 from simith.doliveira@inlibro.com --- Created attachment 34335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34335&action=edit Bug 12769 - Notice fee management -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34335|0 |1 is obsolete| | --- Comment #5 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 36318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36318&action=edit Bug 12769 - Notice fee management -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #8 from Ahmed Sfayhi <ahmed.sfayhi@inlibro.com> --- Created attachment 36504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36504&action=edit Bug 12769 - Display fee in notice fee -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eskaaren@yahoo.no --- Comment #10 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- I get this when trying to apply the patch to an up to date branch: pplying: Bug 12769 - Notice fee management fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 12769 - Notice fee management Is there any dependency not listed or perhaps the patch must be rebased? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- See reasons in comment #11 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36351|0 |1 is obsolete| | Attachment #36504|0 |1 is obsolete| | --- Comment #13 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39900&action=edit Bug 12769 - Notice fee management Created an atomic update .sql file. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #16 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39918&action=edit Bug 12769 - Follow up to comments 14 & 15 The scripts now check if the variable is defined. As for 0 and NULL in the letter's fee column: If the fee is NULL, we use the default value stored in the system preference. If the syspref is 0 or NULL the patron is not charged. If the fee is 0, we use that value and the fine is not created. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #18 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Hi Maxime, I am trying to test this to sign off and the patch is applied and database updated. However when I follow the test plan there is never set any fines. The accountlines table is not populated and there are not any entries there from before. Do you have any advice for troubleshooting this/testing further? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #20 from Eivin Giske Skaaren <eivin@sysmystic.com> --- The scripts are not failing but they don´t actually do anything. So all scenarios are failing for me at this point..

Check that the EnhancedMessaging syspref On.

Do you mean the EnhancedMessagingPreferences? It can be set to Allow or Don´t allow. I have tested with both.

Check that the patron has these notices activated : Advance notice, Item Due

There are mostly dashes shown in the table in Patron messaging preferences. The only thing that can be selected is days in advance for Advance notice. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #22 from Eivin Giske Skaaren <eivin@sysmystic.com> --- (In reply to Maxime Beaulieu from comment #21) Thanks for the suggestion. The values are there in the message_attributes table. The problem is that the checkboxes are missing. I have now confirmed that it must be some problem with the vagrant devbox. I set up a completely new installation and got the same problem. I checked on another installation that I had done manually on a server and there the checkboxes exist. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #24 from Eivin Giske Skaaren <eivin@sysmystic.com> --- (In reply to Maxime Beaulieu from comment #23)

(In reply to Eivin Giske Skaaren from comment #22)

Check the message_transports table.

insert into `message_transports` (`message_attribute_id`, `message_transport_type`, `is_digest`, `letter_module`, `letter_code`) values (1, 'email', 0, 'circulation', 'DUE'), (1, 'email', 1, 'circulation', 'DUEDGST'), (2, 'email', 0, 'circulation', 'PREDUE'), (2, 'email', 1, 'circulation', 'PREDUEDGST'),

Yes that made some checkboxes appear. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39919|0 |1 is obsolete| | --- Comment #26 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 40082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40082&action=edit Bug 12769 - Follow up to comments 14 & 15 Removed useless change in previous patch Test scenario 1: OK Test scenario 2: OK Test scenario 3: OK Test scenario 4: OK Test scenario 5: OK Some notes: In test scenario 3 I noticed that running the cron scripts several times would add several fines for the same items due/overdue. I did not test for this during the other scenarios. If an item is checked out without having a branch selected in the staff client the branchcode will be set to NO_LIBRARY and then no fines will be triggered when running the scripts. Signed-off-by: Eivin Giske Skaaren <eivin@sysmystic.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |corinne.flacher-david@bibli | |bre.com, | |gaetan.boisson@biblibre.com | |, | |jonathan.druart@biblibre.co | |m, | |paul.poulain@biblibre.com Status|Signed Off |In Discussion --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- I developed something similar for a BibLibre's customer some years ago. I added the "fee" value to the overduerules table, which, I think, is much more flexible. For instance, you could specify different fee for a given notice. Your way could add flexibility, it will be possible to add fees for something else than overdue notices. But I am not sure where it could apply. My concern is that the field will be display for all notices but will only be take into account in few cases. Putting in discussion and ccing some BibLibre guys. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #29 from Charles Farmer <charles.farmer@inlibro.com> --- Since June, did the BibLibre team had any chance to test/review/give their opinion on the matter? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #30 from Eivin Giske Skaaren <eivin@sysmystic.com> --- (In reply to Charles Farmer from comment #29)

Since June, did the BibLibre team had any chance to test/review/give their opinion on the matter?

+1 Since this is a sponsored patch the need is real. What can be done to make progress here? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #33 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Charles Farmer from comment #32)

Bug 14666's assignee is uninterested in looking elsewhere for his needs.

Scratch that, there was a misunderstanding in the other thread :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #35 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- ---Short Version--- Do we want to be able to charge users on arbitrary notifications, and if we do, are we willing to provide users with a design that will require maintaining all the different variants of the notifications? ---Long Prose--- I went and read the RFC mentioned at the top of this thread first, which seems to be where the initial requirement was expressed. Bug 14666 is obviously trying to achieve something quite similar. I see two possibilities: - The requirement is to charge on notifications for late documents, something that indeed cannot be done in Koha right now. That is my understanding of the RFC actually, but I didn't write it, and I don't know the sponsor;). I have had libraries asking me how to have a one time charge when patrons have late documents. Koha makes some complicated calculations regarding each document and the number of days late, according to the circulation matrix, which definitely doesn't fit everyone's needs, and which will generate odd amounts for fines. My point is that there clearly is a need to be able to charge a simple one time amount to patrons with late documents. If this is the only scenario for the requirement, then I think adding this possibility at the notification level is a bad idea. It makes it difficult to charge different amounts for different patron categories or different libraries since you will have to edit different notifications for these, I find the "notices and slips" tool quite complicated already, while the "overdue status trigger" tool is very clear. It also makes it possible to charge for notifications for which I cannot see the need, like PREDUE. There are other notifications for which I think "fair enough, why not", like "hold available for pick up", but frankly none of them make as much sense to me as the overdue notices (and I don't see myself needing this anytime soon). - But maybe that is precisely the requirement, to be able to charge users on arbitrary notifications and not just for late items. If this is the case then in the current design libraries who want to manage different fine amounts for different patron categories / libraries combinations for overdue notices will have to deal with having a really long list of notifications to maintain, since they will have one for each combination of patron category / library for which the amount is different. If the wording has to change in the notification, all of them will need to be edited. This adds up with the different notifications for each stage (1st reminder, 2nd reminder, etc.), so it will be a lot of lines in the tool. So I would say the question is: do we want to be able to charge users on arbitrary notifications, and if we do, are we willing to provide users with a design that will require maintaining all the different variants of the notifications? The BibLibre development (bug 14666) is not about charging for arbitrary notifications. You have my opinion on the above question ;) InLibro and the Halland County Library should give their input and we'll see how to move forward! (Although I work for BibLibre, I am not in charge of the development on bug 14666. So if the answer is that the need is to send notifications for arbitrary notifications, I will not block the proposed functionality: it is possible to achieve our needs with it. I just think the interface is going to make it painful. I will ask Stéphane Delaye to give his opinion here though.) -- You are receiving this mail because: You are watching all bug changes.