[Bug 12752] New: OVERDUE notice mis-labeled as "Hold Available for Pickup"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Bug ID: 12752 Summary: OVERDUE notice mis-labeled as "Hold Available for Pickup" Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The letter with code OVERDUE for 'all branches' and message transport type 'phone' has the name "Hold Available for Pickup". There are no other notices with code 'OVERDUE', however there is a letter marked 'ODUE'. This notice can be seen at the bywater demo site (username bywater/password bywater): http://intranet.bywatersolutions.com/cgi-bin/koha/tools/letter.pl and here: http://intranet.bywatersolutions.com/cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=OVERDUE select * from letter where code='OVERDUE'\G *************************** 1. row *************************** module: circulation code: OVERDUE branchcode: name: Hold Available for Pickup is_html: 0 title: Overdue Notice (phone notice) content: Your item is overdue message_transport_type: phone Thsi notice should be deleted; if a default overdue phone notice is needed, it should be added under the code 'ODUE'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's a problem with the database update not setting a variable correctly I think, we ran into this too, but lost sight of it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Actually ODUE is Overdue - this notice is new and not needed. I've been deleting it from most installs. Nicole -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 --- Comment #3 from Barton Chittenden <barton@bywatersolutions.com> --- This became an issue at one of our partner consortia; this database row needs to be deleted before it causes more problems: The library had several additional OVERDUE notices: select module, code, branchcode, name, is_html, title, message_transport_type from letter where code='OVERDUE'; +-------------+---------+------------+----------------------------------+---------+--------------------------------+------------------------+ | module | code | branchcode | name | is_html | title | message_transport_type | +-------------+---------+------------+----------------------------------+---------+--------------------------------+------------------------+ | circulation | OVERDUE | | Item Past Due Alert (2nd Notice) | 0 | Library Item(s) Past Due Alert | email | | circulation | OVERDUE | | Printable Hold notice | 0 | Overdue Notice (phone notice) | phone | | circulation | OVERDUE | XYZZY | Item Past Due Alert (2nd Notice) | 0 | Library Item(s) Past Due Alert | email | | circulation | OVERDUE | ABCDEF | Item Past Due Alert | 0 | Library Item(s) Past Due Alert | email | | circulation | OVERDUE | FOOOBARB | Item Past Due Alert (2nd Notice) | 0 | Library Item(s) Past Due Alert | email | +-------------+---------+------------+----------------------------------+---------+--------------------------------+------------------------+ This caused confusion, because a) The OVERDUE/"All libraries" notice with name "Printable Hold notice" did *not* show as a distinct letter on tools/letter.pl b) tools/overduerules.pl shows available letters by 'letter.name', but only the letter code is stored in the overduerules table. This also points the the necessity of adding a primary key to the letters table, as noted in bug 13215. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13215 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 --- Comment #4 from Heather Braum <hbraum@nekls.org> --- Bug 15007 will add a primary key id to the letter table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11867 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This has certainly been caused by 3.15.00.041 (bug 11867). The structure of the letter table is not ideal, it should be split into 2 tables to normalised it. I don't know how we could fix this issue as a script cannot know what is the correct name of the letter. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the problem might be here: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mys... $name is explicitly set for the HOLD messages, but never updates for the other messages later on: 8363 my $name = $dbh->selectcol_arrayref(q| 8364 SELECT name FROM letter WHERE code="HOLD" 8365 |); 8366 $name = $name->[0]; So $name is also used for PREDUE and OVERDUE Maybe we could fix that database update - and then also do a database update looking at the code/module and change accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org