[Bug 22080] New: Easier translation of ElasticSearch mappings page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Bug ID: 22080 Summary: Easier translation of ElasticSearch mappings page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Actual translation of ElasticSearch mappings page contains a huge block : %s %s An error occurred when updating mappings (%s). %s An error occurred when deleting the existing mappings. Nothing has been changed! (search field %s with mapping %s.) %s Invalid field weight "%s", must be a positive decimal number. %s An error occurred when updating Elasticsearch index mappings: %s. %s Index "%s" needs to be reindexed %s Index "%s" needs to be recreated %s Mappings updated successfully. %s Mappings have been reset successfully. %s %s %s I propose to add <span> to split into several translation blocks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 83705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83705&action=edit Bug 22080 - Easier translation of ElasticSearch mappings page Actual translation of ElasticSearch mappings page contains a huge block with a lot of %s. It makes translation hard. This patch adds <span> to split into several translation blocks. Test plan : 1) Compare page with and without patch, check the only difference is span tags. 2) Check HTML is OK with patch. 3) Update a PO file and see new translation blocks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr, | |julian.maurice@biblibre.com --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Isn't it a good place to use new translation mechanism introduced by bug #15395 (thanks Julian)? A sample usage is available on bug #21789. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Frédéric Demians from comment #2)
Isn't it a good place to use new translation mechanism introduced by bug #15395 (thanks Julian)? A sample usage is available on bug #21789.
Absolutely. Fridolin, please look at https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_con... to see how to do it (or ask me directly ;)) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 [Bug 15395] Internationalization: plural forms, context, and more -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83705|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Comment on attachment 83705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83705 Bug 22080 - Easier translation of ElasticSearch mappings page I'm creating a new patch with new translate system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 83791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83791&action=edit Bug 22080: [DO NOT PUSH] test code This code is not generate all messages to template : koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 83792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83792&action=edit Bug 22080: Easier translation of ElasticSearch mappings page Actual translation of ElasticSearch mappings page contains a huge block with a lot of %s. It makes translation hard. This patch uses new method from Bug 15395 to split into several translation blocks. Test plan : 1) Apply patch "Bug 22080: [DO NOT PUSH] test code" 2) Apply this patch 3) Enable ElasticSearch in SearchEngine preference 4) Go to Administration > Search engine configuration 5) Check page is OK 6) Update the PO files of a language : perl translate update xx-YY 7) Write translation strings in misc/translator/po/xx-YY-messages.po 8) Install translation : perl translate install xx-YY 9) Check translated page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #5)
Created attachment 83791 [details] [review] Bug 22080: [DO NOT PUSH] test code
This code is not generate all messages to template : koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/ mappings.tt
To make the strings easy to see in template, I've added this code to the perl page. Of course, don't sign it nor push it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Frédéric Demians from comment #2)
Isn't it a good place to use new translation mechanism introduced by bug #15395 (thanks Julian)? A sample usage is available on bug #21789.
This mechanism is great, thanks a lot Julian and Frédéric :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83792|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85012&action=edit Bug 22080: Easier translation of ElasticSearch mappings page Actual translation of ElasticSearch mappings page contains a huge block with a lot of %s. It makes translation hard. This patch uses new method from Bug 15395 to split into several translation blocks. Test plan : 1) Apply patch "Bug 22080: [DO NOT PUSH] test code" 2) Apply this patch 3) Enable ElasticSearch in SearchEngine preference 4) Go to Administration > Search engine configuration 5) Check page is OK 6) Update the PO files of a language : perl translate update xx-YY 7) Write translation strings in misc/translator/po/xx-YY-messages.po 8) Install translation : perl translate install xx-YY 9) Check translated page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well for me.. signing off.. As a side note, I 'think' the qa script may need updating for the new translation stuff.. currently with this patch it yields: ``` FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt FAIL filters missing_filter at line 92 ( [% t("Mappings updated successfully.") %]) missing_filter at line 94 ( [% t("Mappings have been reset successfully.") %]) missing_filter at line 81 ( [% t("An error occurred when deleting the existing mappings. Nothing has been changed!") %]) ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83791|0 |1 is obsolete| | Attachment #85012|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85441&action=edit Bug 22080: [DO NOT PUSH] test code This code is not generate all messages to template : koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85441|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85442&action=edit Bug 22080: [DO NOT PUSH] test code This code is not generate all messages to template : koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85443&action=edit Bug 22080: Easier translation of ElasticSearch mappings page Actual translation of ElasticSearch mappings page contains a huge block with a lot of %s. It makes translation hard. This patch uses new method from Bug 15395 to split into several translation blocks. Test plan : 1) Apply patch "Bug 22080: [DO NOT PUSH] test code" 2) Apply this patch 3) Enable ElasticSearch in SearchEngine preference 4) Go to Administration > Search engine configuration 5) Check page is OK 6) Update the PO files of a language : perl translate update xx-YY 7) Write translation strings in misc/translator/po/xx-YY-messages.po 8) Install translation : perl translate install xx-YY 9) Check translated page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 85444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85444&action=edit Bug 22080: (QA Follow-up) Add filters Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- skipping this ES patch in 18.05.x, if I am wrong let me know -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- No problem, its just for translation -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org