[Bug 20658] New: Move template JavaScript to the footer: Installer and onboarding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Bug ID: 20658 Summary: Move template JavaScript to the footer: Installer and onboarding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the installer and onboarding templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 74851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74851&action=edit Bug 20658: Move template JavaScript to the footer: Installer and onboarding This patch updates the installer and onboarding templates so that JavaScript is included in the footer instead of the header. A new include file is added, installer-intranet-bottom.inc, so that only required JS is being loaded. Some markup changes are included to improve validity. To test, apply the patch and start with a blank Koha database. Run through the installer and onboarding processes and confirm that there are no problems. Check especially JS-related interactions like datepickers and fields which are validated via JS, like the password inputs. NOTE: The qa tool will flag this patch for not using the Asset plugin, but it doesn't work correctly for installer files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74851|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 78910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78910&action=edit Bug 20658: Move template JavaScript to the footer: Installer and onboarding This patch updates the installer and onboarding templates so that JavaScript is included in the footer instead of the header. A new include file is added, installer-intranet-bottom.inc, so that only required JS is being loaded. Some markup changes are included to improve validity. To test, apply the patch and start with a blank Koha database. Run through the installer and onboarding processes and confirm that there are no problems. Check especially JS-related interactions like datepickers and fields which are validated via JS, like the password inputs. NOTE: The qa tool will flag this patch for not using the Asset plugin, but it doesn't work correctly for installer files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78910|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 78912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78912&action=edit Bug 20658: Move template JavaScript to the footer: Installer and onboarding This patch updates the installer and onboarding templates so that JavaScript is included in the footer instead of the header. A new include file is added, installer-intranet-bottom.inc, so that only required JS is being loaded. Some markup changes are included to improve validity. To test, apply the patch and start with a blank Koha database. Run through the installer and onboarding processes and confirm that there are no problems. Check especially JS-related interactions like datepickers and fields which are validated via JS, like the password inputs. NOTE: The qa tool will flag this patch for not using the Asset plugin, but it doesn't work correctly for installer files. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- html filters have been removed in the include file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79300&action=edit Bug 20658: (follow-up) Fix for QA: Add missing html filters This patch adds missing filters to the installer header and footer include files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA script is quite unhappy, can you please check? OK koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc OK filters OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/includes/installer-intranet-bottom.inc OK filters FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 4) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 1) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 2) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 3) forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 5) OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/installer/auth.tt OK filters OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt OK filters OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/installer/step2.tt OK filters OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt OK filters OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt OK filters OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt OK filters FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 132) OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt OK filters FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 116) OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt OK filters FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 52) OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found FAIL koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt OK filters FAIL forbidden patterns forbidden pattern: Do *not* include full path to js files, use the Asset TT plugin (bug 20538) (line 139) OK git manipulation OK spelling OK tt_valid FAIL valid_template : filter not found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79300|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81504&action=edit Bug 20658: (follow-up) Fix for QA: Add missing html filters This patch adds missing filters to the installer header and footer include files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 22309 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78912|0 |1 is obsolete| | Attachment #81504|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85404&action=edit Bug 20658: Move template JavaScript to the footer: Installer and onboarding This patch updates the installer and onboarding templates so that JavaScript is included in the footer instead of the header. A new include file is added, installer-intranet-bottom.inc, so that only required JS is being loaded. Some markup changes are included to improve validity. To test, apply the patch and start with a blank Koha database. Run through the installer and onboarding processes and confirm that there are no problems. Check especially JS-related interactions like datepickers and fields which are validated via JS, like the password inputs. NOTE: The qa tool will flag this patch for not using the Asset plugin, but it doesn't work correctly for installer files. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85405&action=edit Bug 20658: (follow-up) Fix for QA: Add missing html filters This patch adds missing filters to the installer header and footer include files. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- I still see the QA errors related to paths, can we not use Asset here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Nick Clemens from comment #11)
I still see the QA errors related to paths, can we not use Asset here?
I don't think so, Asset needs to read version from system preference, but can't because database does not exist yet (at least in first steps) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #12)
(In reply to Nick Clemens from comment #11)
I still see the QA errors related to paths, can we not use Asset here?
I don't think so, Asset needs to read version from system preference, but can't because database does not exist yet (at least in first steps)
Is this correct? Why not Koha::version() instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #13)
(In reply to Josef Moravec from comment #12)
(In reply to Nick Clemens from comment #11)
I still see the QA errors related to paths, can we not use Asset here?
I don't think so, Asset needs to read version from system preference, but can't because database does not exist yet (at least in first steps)
Is this correct? Why not Koha::version() instead?
I agree, but it's for another bug report I think... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22451 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Pushed for QA --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Opened bug 22451 and switched back to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 [Bug 22451] Asset plugin is using the version from the DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |trivial Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- cant apply to 18.05.x if this is need please rebase. thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment #18)
cant apply to 18.05.x if this is need please rebase.
I don't think it's necessary to backport this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #20 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Indeed, its really minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org