[Bug 36106] New: Port default PREDUE and DUE notices to Template Toolkit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Bug ID: 36106 Summary: Port default PREDUE and DUE notices to Template Toolkit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Blocks: 15278 The following notices need to be updated to use Template Toolkit syntax: DUE (email) DUE (sms) PREDUE (email) PREDUE (sms) These ones should be fairly straightforward. All four notices have nearly identical content, so it makes sense to group them together. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I am assuming will be retain the ability to use <<item.content>> ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 --- Comment #2 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Yup, this is just about updating the default notice text (and making sure the notices support the item content via TT if they don't already), not deprecating <<items.content>> on the back end. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa from comment #2)
Yup, this is just about updating the default notice text (and making sure the notices support the item content via TT if they don't already), not deprecating <<items.content>> on the back end.
Great! Thanks, Emily! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 165591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165591&action=edit Bug 36106: Adjust DUE and PREDUE notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Leave Digests only unchecked Advance notice - Select 1 day in advance - Check SMS - Check Email - Leave Digests only unchecked 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out an item 7. Set a custom due date for tomorrow and check out another item 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165591|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166415&action=edit Bug 36106: Adjust DUE and PREDUE notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Leave Digests only unchecked Advance notice - Select 1 day in advance - Check SMS - Check Email - Leave Digests only unchecked 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out an item 7. Set a custom due date for tomorrow and check out another item 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, thanks Emily. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The default notice release notes| |templates for advance | |notice and item due | |notifications now use | |modern Template Toolkit | |rather than the old custom | |syntax. This will only | |affect new installations, | |unless the library chooses | |to reset their notices to | |the default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36106 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32211 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org