https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38134 Bug ID: 38134 Summary: Koha::Items::filter_by_for_hold does not work Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We noticed that the place hold button is often incorrecty missing in the detail view in the staff interface after upgrading to 23.11.09. This is due to the number of holdable items is incorrectly determined to be 0. But the method filter_by_for_hold incorrectly assumes that Koha::CirculationRules->get_effective_rule can be used to filter on rule value: my $default_rule = Koha::CirculationRules->get_effective_rule( { rule_name => 'holdallowed', rule_value => 'not_allowed', } ); But it cannot: print Dumper($default_rule->unblessed); $VAR1 = { 'categorycode' => undef, 'id' => 268, 'itemtype' => undef, 'branchcode' => undef, 'rule_name' => 'holdallowed', 'rule_value' => 'from_any_library' }; Bug 29087 introduced this change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.