[Bug 9177] New: Duplicate patron: Prepopulated fields ar cleared when setting cursor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Bug ID: 9177 Summary: Duplicate patron: Prepopulated fields ar cleared when setting cursor Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 13790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13790&action=edit Screenshot Duplicate patron - prepopulated fields cleared How to reproduce: 1) Go to a patron's detail page 2) Click "Duplicate" 3) On the screen, click in one of the prepopulated fields, e.g. Surname or City Result: The field is cleared. Expected: Cursor is set without clearing the field. Is this a bug or is it by design? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This is by design. I think the idea is that you don't click those fields if the data is correct. If the data is incorrect you want to replace it, so clearing is helpful. It's easy to see the downside: If you use the keyboard to navigate through the form you'll end up clearing all the existing data. I don't know that I've ever used the duplicate feature in production, but I would think that downside is pretty significant, not to mention being an accessibility problem for users who can't use a mouse. Is this a feature we really need to keep? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It feels like unexpected behaviour to me - might be more irritating than helpful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33460&action=edit Bug 9177 - Duplicate patron: Prepopulated fields ar cleared when setting cursor When adding a duplicated patron record some fields are prepopulated from the original patron record. Focusing your cursor on these fields automatically clears them. This works well if you assume that the user only focuses on fields which should be changed. This works badly if you consider that a user might want to tab between all fields. I think the disadvantages outweigh the minor benefit of not having to delete the contents of a field. This patch removes the clearing action. To test, apply the patch and duplicate an existing patron record. Tabbing through the entry fields should not result in the contents of those fields being cleared. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33460|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33722&action=edit Bug 9177 - Duplicate patron: Prepopulated fields ar cleared when setting cursor When adding a duplicated patron record some fields are prepopulated from the original patron record. Focusing your cursor on these fields automatically clears them. This works well if you assume that the user only focuses on fields which should be changed. This works badly if you consider that a user might want to tab between all fields. I think the disadvantages outweigh the minor benefit of not having to delete the contents of a field. This patch removes the clearing action. TEST PLAN --------- 1) Log in to staff client 2) Patrons 3) Find an existing patron 4) Click on the link in the Name column 5) Click on the Duplicate button 6) Click on fields with data in them. -- they will clear, which is more problematic than correcting the entry. 7) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 8) Click on the Duplicate button 9) Tab through the fields -- the fields should remain unchanged. 10) Apply the patch 11) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 12) Click on the Duplicate button 13) Navigate through the fields -- tabbing nor clicking should clear any fields. 14) Run koha qa tests REBASED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33722|0 |1 is obsolete| | --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33723&action=edit [SIGNED OFF] Bug 9177 - Duplicate patron: Prepopulated fields ar cleared when setting cursor When adding a duplicated patron record some fields are prepopulated from the original patron record. Focusing your cursor on these fields automatically clears them. This works well if you assume that the user only focuses on fields which should be changed. This works badly if you consider that a user might want to tab between all fields. I think the disadvantages outweigh the minor benefit of not having to delete the contents of a field. This patch removes the clearing action. TEST PLAN --------- 1) Log in to staff client 2) Patrons 3) Find an existing patron 4) Click on the link in the Name column 5) Click on the Duplicate button 6) Click on fields with data in them. -- they will clear, which is more problematic than correcting the entry. 7) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 8) Click on the Duplicate button 9) Tab through the fields -- the fields should remain unchanged, but sadly they clear. 10) Apply the patch 11) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 12) Click on the Duplicate button 13) Navigate through the fields -- tabbing nor clicking should clear any fields. 14) Run koha qa tests NOTE: Had to rebase and tweak, but looks good. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- As a side comment, I don't think all the fields that should be cleared when you duplicate are cleared, but that is not within the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33723|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33727&action=edit [PASSED QA] Bug 9177 - Duplicate patron: Prepopulated fields ar cleared when setting cursor When adding a duplicated patron record some fields are prepopulated from the original patron record. Focusing your cursor on these fields automatically clears them. This works well if you assume that the user only focuses on fields which should be changed. This works badly if you consider that a user might want to tab between all fields. I think the disadvantages outweigh the minor benefit of not having to delete the contents of a field. This patch removes the clearing action. TEST PLAN --------- 1) Log in to staff client 2) Patrons 3) Find an existing patron 4) Click on the link in the Name column 5) Click on the Duplicate button 6) Click on fields with data in them. -- they will clear, which is more problematic than correcting the entry. 7) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 8) Click on the Duplicate button 9) Tab through the fields -- the fields should remain unchanged, but sadly they clear. 10) Apply the patch 11) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 12) Click on the Duplicate button 13) Navigate through the fields -- tabbing nor clicking should clear any fields. 14) Run koha qa tests NOTE: Had to rebase and tweak, but looks good. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Less surprises, improves accessibility by enabling to tab through the form without losing data. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Duplicate patron: |Duplicate patron: |Prepopulated fields ar |Prepopulated fields are |cleared when setting cursor |cleared when setting cursor --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #6)
As a side comment, I don't think all the fields that should be cleared when you duplicate are cleared, but that is not within the scope of this bug.
That sounds like Bug 7878 - When duplicating a patron too many fields carrying over - a fix for which was just pushed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Patch doesn't apply anymore, presumably because of the changes made by the QA follow-up to Bug 7878. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33727|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33753&action=edit [REBASED] Bug 9177 - Duplicate patron: Prepopulated fields ar cleared when setting cursor When adding a duplicated patron record some fields are prepopulated from the original patron record. Focusing your cursor on these fields automatically clears them. This works well if you assume that the user only focuses on fields which should be changed. This works badly if you consider that a user might want to tab between all fields. I think the disadvantages outweigh the minor benefit of not having to delete the contents of a field. This patch removes the clearing action. TEST PLAN --------- 1) Log in to staff client 2) Patrons 3) Find an existing patron 4) Click on the link in the Name column 5) Click on the Duplicate button 6) Click on fields with data in them. -- they will clear, which is more problematic than correcting the entry. 7) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 8) Click on the Duplicate button 9) Tab through the fields -- the fields should remain unchanged, but sadly they clear. 10) Apply the patch 11) On the line "Home > Patrons > {patron name} > Duplicate Adult Patron" click the patron name to go back. 12) Click on the Duplicate button 13) Navigate through the fields -- tabbing nor clicking should clear any fields. 14) Run koha qa tests NOTE: Had to rebase again. Yes, bug 7878 interfered. However, it deals with comment #6, which Owen appropriately noted. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Less surprises, improves accessibility by enabling to tab through the form without losing data. NOTE: Set back to Passed QA from Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9177 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org