http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13271 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13271 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33654&action=edit Bug 13271 - Subject search links broken if XSLT and OPACPopupAuthorsSearch are both off This patch corrects some faults in the OPAC's bootstrap template which prevent additional author and subject searches from working correctly with OPACPopupAuthorsSearch both on and off. Some JavaScript has been removed because it was used only by the prog theme and is obsolete. Locate a title with multiple subjects and additional authors. Test the following conditions: OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is on: - Clicking an additional author or subject link should trigger a modal window where you can select options for searching. Checking boxes and submitting the form should perform the correct search. OPACXSLTDetailsDisplay is set to "default" and OPACPopupAuthorsSearch is on OR off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. (OPACPopupAuthorsSearch only works with the non-XSL view). For extra credit: Test with JavaScript disabled and confirm that link still work correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13271 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Owen, do you use OPACPopupAuthorsSearch? For my eyes, this syspref and the associated functionality looks more like code pollution than anything else. It doesn't work with XSLT, which is a deal breaker. In Unimarc, non- XSL views are irrelevant. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13271 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33654|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33804&action=edit Bug 13271 - Subject search links broken if XSLT and OPACPopupAuthorsSearch are both off This patch corrects some faults in the OPAC's bootstrap template which prevent additional author and subject searches from working correctly with OPACPopupAuthorsSearch both on and off. Some JavaScript has been removed because it was used only by the prog theme and is obsolete. Locate a title with multiple subjects and additional authors. Test the following conditions: OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is on: - Clicking an additional author or subject link should trigger a modal window where you can select options for searching. Checking boxes and submitting the form should perform the correct search. OPACXSLTDetailsDisplay is set to "default" and OPACPopupAuthorsSearch is on OR off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. (OPACPopupAuthorsSearch only works with the non-XSL view). For extra credit: Test with JavaScript disabled and confirm that link still work correctly. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the bug and the solution. Before various JS errors: "ReferenceError: e is not defined" and "ReferenceError: showSubjects is not defined". After: Comforting silence, and functionnality. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13271 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33804|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33806&action=edit [PASSED QA] Bug 13271 - Subject search links broken if XSLT and OPACPopupAuthorsSearch are both off This patch corrects some faults in the OPAC's bootstrap template which prevent additional author and subject searches from working correctly with OPACPopupAuthorsSearch both on and off. Some JavaScript has been removed because it was used only by the prog theme and is obsolete. Locate a title with multiple subjects and additional authors. Test the following conditions: OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. OPACXSLTDetailsDisplay is blank and OPACPopupAuthorsSearch is on: - Clicking an additional author or subject link should trigger a modal window where you can select options for searching. Checking boxes and submitting the form should perform the correct search. OPACXSLTDetailsDisplay is set to "default" and OPACPopupAuthorsSearch is on OR off: - Clicking an additional author or subject link should directly trigger the correct search without an JavaScript error. (OPACPopupAuthorsSearch only works with the non-XSL view). For extra credit: Test with JavaScript disabled and confirm that link still work correctly. Signed-off-by: Frederic Demians <f.demians@tamil.fr> I confirm the bug and the solution. Before various JS errors: "ReferenceError: e is not defined" and "ReferenceError: showSubjects is not defined". After: Comforting silence, and functionnality. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. -- You are receiving this mail because: You are watching all bug changes.