[Bug 34735] New: Current/disabled links in breadcrumbs are styled differently when in ERM module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Bug ID: 34735 Summary: Current/disabled links in breadcrumbs are styled differently when in ERM module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: lucas@bywatersolutions.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com If you look at the breadcrumb describing the current page you are on it is typically a light grey. In the ERM module those same breadcrumbs are black. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155283&action=edit Bug 34735: Style disabled breadcrumbs To test: 1. Turn on ERMModule. 2. Notice the disbaled breadcrumbs are color: #000; 3. Apply patch, yarn build 4. Look again, disbaled breadcrumbs are color; #696969; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|jonathan.druart+koha@gmail. |lucas@bywatersolutions.com |com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155287&action=edit Bug 34735: Remove pointer events from disabled links Add pointer-events: none to a.disabled links in staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155288&action=edit Bug 34735: Update breadcrumb markup Make the breadcrumb navigation item markup match the rest of Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 155289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155289&action=edit Bug 34735: Remove uneeded CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass from comment #0)
If you look at the breadcrumb describing the current page you are on it is typically a light grey. In the ERM module those same breadcrumbs are black.
I submitted a couple of follow-ups that should make the breadcrumbs mark up in line with the rest of Koha, and inherit the styling that way. Lucas, please take a look and see if you agree with my patches, or make them obsolete if not. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155283|0 |1 is obsolete| | Attachment #155287|0 |1 is obsolete| | Attachment #155288|0 |1 is obsolete| | Attachment #155289|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155303&action=edit Bug 34735: Style disabled breadcrumbs To test: 1. Turn on ERMModule. 2. Notice the disbaled breadcrumbs are color: #000; 3. Apply patch, yarn build 4. Look again, disbaled breadcrumbs are color; #696969; Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155304&action=edit Bug 34735: Remove pointer events from disabled links Add pointer-events: none to a.disabled links in staff Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155305&action=edit Bug 34735: Update breadcrumb markup Make the breadcrumb navigation item markup match the rest of Koha Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155306&action=edit Bug 34735: Remove uneeded CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #5)
(In reply to Lucas Gass from comment #0)
If you look at the breadcrumb describing the current page you are on it is typically a light grey. In the ERM module those same breadcrumbs are black.
I submitted a couple of follow-ups that should make the breadcrumbs mark up in line with the rest of Koha, and inherit the styling that way.
Lucas, please take a look and see if you agree with my patches, or make them obsolete if not.
Thanks.
Thanks Pedro! Looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155303|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155746&action=edit Bug 34735: Style disabled breadcrumbs To test: 1. Turn on ERMModule. 2. Notice the disbaled breadcrumbs are color: #000; 3. Apply patch, yarn build 4. Look again, disbaled breadcrumbs are color; #696969; Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155304|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155747&action=edit Bug 34735: Remove pointer events from disabled links Add pointer-events: none to a.disabled links in staff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155305|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155748&action=edit Bug 34735: Update breadcrumb markup Make the breadcrumb navigation item markup match the rest of Koha Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155306|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155749&action=edit Bug 34735: Remove uneeded CSS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It actually matches the behaviour we have in the navmenu. Why is this better than before? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ok nevermind, looks good now after a second look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33169 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 [Bug 33169] Improve vue breadcrumbs and left-hand menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33169 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #18)
Depends on Bug 33169 not in 23.05.x
In the end Bug 33169 has been backported. Do you advice to backport this one ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34735 Bug 34735 depends on bug 33169, which changed state. Bug 33169 Summary: Improve vue breadcrumbs and left-hand menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org