[Bug 34862] New: blocking_errors.inc not included everywhere
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Bug ID: 34862 Summary: blocking_errors.inc not included everywhere Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org We want blocking_errors.inc to be included everywhere, in all the templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155991&action=edit Bug 34862: Remove blocking_errors where there is no main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155992&action=edit Bug 34862: [DO NOT PUSH] add script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155993&action=edit Bug 34862: Include blocking_errors.inc everywhere We create a generic 'messages.inc' that will include blocking_errors.inc We can imagine having more messages here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155992|0 |1 is obsolete| | Attachment #155993|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155997&action=edit Bug 34862: [DO NOT PUSH] add script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155998&action=edit Bug 34862: Include messages.inc Generated using `perl add_blocking_errors.pl` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155999&action=edit Bug 34862: Add messages.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156000&action=edit Bug 34862: Manual changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Jonathan, do you have a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #9 from David Cook <dcook@prosentient.com.au> --- One of these days it would be great if folk would support the idea of using WRAPPER (http://www.template-toolkit.org/docs/manual/Directives.html#section_WRAPPER) with Koha so that we could more easily make template changes to every page... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Cook from comment #9)
One of these days it would be great if folk would support the idea of using WRAPPER (http://www.template-toolkit.org/docs/manual/Directives. html#section_WRAPPER) with Koha so that we could more easily make template changes to every page...
git grep WRAPPER? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Lucas Gass from comment #8)
Jonathan, do you have a test plan for this?
This is related to bug 34478 IIRC. I caught places where the "wrong csrf" token message was not displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155991|0 |1 is obsolete| | Attachment #155998|0 |1 is obsolete| | Attachment #155999|0 |1 is obsolete| | Attachment #156000|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158755&action=edit Bug 34862: Remove blocking_errors where there is no main Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158756&action=edit Bug 34862: Include messages.inc Generated using `perl add_blocking_errors.pl` Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158757&action=edit Bug 34862: Add messages.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158758&action=edit Bug 34862: Manual changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158759&action=edit Bug 34862: (follow-up) Fix some misplaced messages and add missing This patch fixes some templates where the messages include was appearing in the wrong place, for instance above the left-hand sidebar instead of at the top of the main content. The patch also adds the new include to some templates which lacked it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #10)
(In reply to David Cook from comment #9)
One of these days it would be great if folk would support the idea of using WRAPPER (http://www.template-toolkit.org/docs/manual/Directives. html#section_WRAPPER) with Koha so that we could more easily make template changes to every page...
git grep WRAPPER?
Apologies for not being clear. What I mean is a wrapper that includes the header and footer. Every page template would use the same wrapper and just fill in the components needed for that page. Similar to what I did for bug 31339 but more comprehensive. That way blocking_error.inc could be included 1 time in the wrapper and then every page would automagically get it because they're using the wrapper. I have a different system that works that way and it's so nice. It would involve a lot of refactoring though for Koha. That said, we could create that wrapper and start using it for new pages and easy refactors... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155997|0 |1 is obsolete| | Attachment #158755|0 |1 is obsolete| | Attachment #158756|0 |1 is obsolete| | Attachment #158757|0 |1 is obsolete| | Attachment #158758|0 |1 is obsolete| | Attachment #158759|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159472&action=edit Bug 34862: [DO NOT PUSH] add script Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159473&action=edit Bug 34862: Remove blocking_errors where there is no main Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159474&action=edit Bug 34862: Include messages.inc Generated using `perl add_blocking_errors.pl` Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159475&action=edit Bug 34862: Add messages.inc Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159476&action=edit Bug 34862: Manual changes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159477&action=edit Bug 34862: (follow-up) Fix some misplaced messages and add missing This patch fixes some templates where the messages include was appearing in the wrong place, for instance above the left-hand sidebar instead of at the top of the main content. The patch also adds the new include to some templates which lacked it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but this no longer applies and I don't see how to fix - please rebase. I'll keep checking and push once ready. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 34862: [DO NOT PUSH] add script Applying: Bug 34862: Remove blocking_errors where there is no main Applying: Bug 34862: Include messages.inc error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt). error: could not build fake ancestor Patch failed at 0001 Bug 34862: Include messages.inc hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-34862-Include-messagesinc-tp2ov_ox.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did a second run with -i removing the first patch, but still no luck. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159473|0 |1 is obsolete| | Attachment #159474|0 |1 is obsolete| | Attachment #159475|0 |1 is obsolete| | Attachment #159476|0 |1 is obsolete| | Attachment #159477|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161666&action=edit Bug 34862: Remove blocking_errors where there is no main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159477|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159472|0 |1 is obsolete| | Attachment #159477|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161667&action=edit Bug 34862: Remove blocking_errors where there is no main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161668&action=edit Bug 34862: [DO NOT PUSH] add script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161669&action=edit Bug 34862: Include messages.inc Generated using `perl add_blocking_errors.pl` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161670&action=edit Bug 34862: Add messages.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161671&action=edit Bug 34862: Manual changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161672&action=edit Bug 34862: (follow-up) Fix some misplaced messages and add missing This patch fixes some templates where the messages include was appearing in the wrong place, for instance above the left-hand sidebar instead of at the top of the main content. The patch also adds the new include to some templates which lacked it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #25)
I did a second run with -i removing the first patch, but still no luck.
This is the kind of patch (190KB) that must not be waiting 2 months before pushing... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I push according to priorities, if you know this give me a heads up. Maybe it should have been marked as bug (not enh?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #34)
I push according to priorities, if you know this give me a heads up. Maybe it should have been marked as bug (not enh?)
blocker of a huge security bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't tell that easily - no dependencies on the bug, marked enh. As I said, give me a heads up, but if it had stood out, I would have been here earlier. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can only get the first patch to apply. Removed the second. Is the sequence correct? Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 34862: Include messages.inc Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt error: insufficient permission for adding an object to repository database .git/objects error: unable to create backing store for newly created file koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt error: Did you hand edit your patch? It does not apply to blobs recorded in its index. Patch failed at 0001 Bug 34862: Include messages.inc hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-34862-Include-messagesinc-hfhzpu3c.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161667|0 |1 is obsolete| | Attachment #161668|0 |1 is obsolete| | Attachment #161669|0 |1 is obsolete| | Attachment #161670|0 |1 is obsolete| | Attachment #161671|0 |1 is obsolete| | Attachment #161672|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161673&action=edit Bug 34862: Remove blocking_errors where there is no main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161674&action=edit Bug 34862: [DO NOT PUSH] add script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161675&action=edit Bug 34862: Include messages.inc Generated using `perl add_blocking_errors.pl` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161676&action=edit Bug 34862: Add messages.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161677&action=edit Bug 34862: Manual changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161678&action=edit Bug 34862: (follow-up) Fix some misplaced messages and add missing This patch fixes some templates where the messages include was appearing in the wrong place, for instance above the left-hand sidebar instead of at the top of the main content. The patch also adds the new include to some templates which lacked it. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry for the inconvenience - it appears to have been a permission issue on my end. Patches applied now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What about OPAC here ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #47 from Fridolin Somers <fridolin.somers@biblibre.com> --- I choose to backport to avoid future conflicts in templates. Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org