[Bug 35479] New: plugins nightly cronjob should log the plugins that are being run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Bug ID: 35479 Summary: plugins nightly cronjob should log the plugins that are being run Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Bug 31203 adding logging of the start and end of a run to cronjobs. When running the plugins_nightly.pl cronjob, we should record the plugins that have a nightly method, logging the start and end of each plugins routine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 159560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159560&action=edit Bug 35479: Log start, end, and any failures for each plugin's nightly cronjob When running the plugins_nightly.pl cronjob, we should record the plugins that have a nightly method, logging the start and end of each plugins routine Test Plan: 1) Enable CronjobLog 2) Install a plugin with a nightly cronjob ( e.g. https://github.com/bywatersolutions/koha-plugin-book-list-printer ) 3) Run plugins_nightly.pl 4) Note new entries in the cronjob viewer for the start and end of the plugin's nightly cronjob run 5) Edit the plugin, add a line like "die 'this is a test';" to the plugin's nightly cronjob 6) Run plugins_nightly.pl 7) View the action logs, not the log for the error you added! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159581&action=edit Bug 35479: (follow-up) Match formatting for other cronjob logs To test: 1 - Install the Kitchen Sink plugin 2 - Restart all 3 - Enable 'CronjobLog' system preference 4 - perl misc/cronjobs/plugins_nightly.pl 5 - Note you see on the command line 'Remember to clean the kitchen' - this indicates the plugin cron ran 6 - Tools->log viewer, select 'cronjob' and view 7 - Note you only see 'plugins_nightly.pl' Run and End lines 8 - Apply patches 9 - perl misc/cronjobs/plugins_nightly.pl 10 - View logs agian 11 - Note you now see Run and End lines for 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' 12 - Confirm they look like the other lines 13 - Edit KitchenSink.pm and add 'die "Kittens";' to the cronjob nightly 14 - perl misc/cronjobs/plugins_nightly.pl 15 - View logs, confirm there is a FAILED error message for the KitchenSink cron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159560|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159958&action=edit Bug 35479: Log start, end, and any failures for each plugin's nightly cronjob When running the plugins_nightly.pl cronjob, we should record the plugins that have a nightly method, logging the start and end of each plugins routine Test Plan: 1) Enable CronjobLog 2) Install a plugin with a nightly cronjob ( e.g. https://github.com/bywatersolutions/koha-plugin-book-list-printer ) 3) Run plugins_nightly.pl 4) Note new entries in the cronjob viewer for the start and end of the plugin's nightly cronjob run 5) Edit the plugin, add a line like "die 'this is a test';" to the plugin's nightly cronjob 6) Run plugins_nightly.pl 7) View the action logs, not the log for the error you added! Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159581|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159959&action=edit Bug 35479: (follow-up) Match formatting for other cronjob logs To test: 1 - Install the Kitchen Sink plugin 2 - Restart all 3 - Enable 'CronjobLog' system preference 4 - perl misc/cronjobs/plugins_nightly.pl 5 - Note you see on the command line 'Remember to clean the kitchen' - this indicates the plugin cron ran 6 - Tools->log viewer, select 'cronjob' and view 7 - Note you only see 'plugins_nightly.pl' Run and End lines 8 - Apply patches 9 - perl misc/cronjobs/plugins_nightly.pl 10 - View logs agian 11 - Note you now see Run and End lines for 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' 12 - Confirm they look like the other lines 13 - Edit KitchenSink.pm and add 'die "Kittens";' to the cronjob nightly 14 - perl misc/cronjobs/plugins_nightly.pl 15 - View logs, confirm there is a FAILED error message for the KitchenSink cron Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159960&action=edit Bug 35479: (QA follow-up): Tidy Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159958|0 |1 is obsolete| | Attachment #159959|0 |1 is obsolete| | Attachment #159960|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159966&action=edit Bug 35479: Log start, end, and any failures for each plugin's nightly cronjob When running the plugins_nightly.pl cronjob, we should record the plugins that have a nightly method, logging the start and end of each plugins routine Test Plan: 1) Enable CronjobLog 2) Install a plugin with a nightly cronjob ( e.g. https://github.com/bywatersolutions/koha-plugin-book-list-printer ) 3) Run plugins_nightly.pl 4) Note new entries in the cronjob viewer for the start and end of the plugin's nightly cronjob run 5) Edit the plugin, add a line like "die 'this is a test';" to the plugin's nightly cronjob 6) Run plugins_nightly.pl 7) View the action logs, not the log for the error you added! Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159967&action=edit Bug 35479: (follow-up) Match formatting for other cronjob logs To test: 1 - Install the Kitchen Sink plugin 2 - Restart all 3 - Enable 'CronjobLog' system preference 4 - perl misc/cronjobs/plugins_nightly.pl 5 - Note you see on the command line 'Remember to clean the kitchen' - this indicates the plugin cron ran 6 - Tools->log viewer, select 'cronjob' and view 7 - Note you only see 'plugins_nightly.pl' Run and End lines 8 - Apply patches 9 - perl misc/cronjobs/plugins_nightly.pl 10 - View logs agian 11 - Note you now see Run and End lines for 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' 12 - Confirm they look like the other lines 13 - Edit KitchenSink.pm and add 'die "Kittens";' to the cronjob nightly 14 - perl misc/cronjobs/plugins_nightly.pl 15 - View logs, confirm there is a FAILED error message for the KitchenSink cron Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159968&action=edit Bug 35479: (QA follow-up): Tidy Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Looks good. Didn't test the failure use case, but it makes sense. QA checks happy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|plugins nightly cronjob |Nightly cronjob for plugins |should log the plugins that |should log the plugins that |are being run |are being run -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Trivial patch Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I backport Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org