[Bug 36269] New: ElasticSearch: publisher-location (pl) index should use 264a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Bug ID: 36269 Summary: ElasticSearch: publisher-location (pl) index should use 264a Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: domm@plix.at Currently the index `pl` points to 008/15-17. It should (additionally/instead?) point to 260a and/or 264a. * Fix the default mappings in admin/searchengine/elasticsearch/mappings.yaml Notes from chat: cait: maybe having the index broader is not a bad thing, I am not sure if it's confusing or not cait: like put 260a (non-RDA), 264 (RDA) and 008 15-17 in it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not sure if we should aim for matching the Zebra config, but I think it might be a good starting point. I definitely think we should put 260 and 264 $a in. Not sure about the controlled value from 008 - but a 3 letter country code might not hurt things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 --- Comment #2 from Thomas Klausner <domm@plix.at> --- Created attachment 162913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162913&action=edit Bug 36269: ElasticSearch: publisher-location (pl) should use260a/264a Currently the index `pl` points to 008/15-17. It should (additionally/instead?) point to 260a and/or 264a. Test plan (for koha-testing-docker with ElasticSearch via `ktd --es7 up`) Verify the old/broken behaviour: * Go to Staff/Advanced Search * Select "Publisher Location" and enter "cau", start search * You will get some hits (~16), eg "Perl best practices / Damian Conway", which has 008 of "051222s2005 caua b 001 0 eng d" with "cau" on 15-17 * Edit this record (cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=5) * Inspect 260$a, which should containt "Sebastopol, CA :" * Go back to Advanced Search and search for "Publisher Location" = "Sebastopol" * No hits! Apply the patch! * exit ktd and stop it (ktd --es7 down; ktd --es7 stop) * start it again * Go to Staff / Administration / Search Engine Config (Elasticsearch) * Click on the Tab "Bibliographic records" and search/filter for "pl" * you should see 3 entries for "pl", with Mapping values of "008_/15-17", "260a" and "264a" * Go to Search, * Select "Publisher Location" and enter "cau", start search * same hits as befor * Search again, but for "Sebastopol" * Now you'll get 9 hits!! Bonus: Test 264a * Got to Admin / MARC bibl framework, select BKS -> MARC structure * search for tag "264", edit subfields * in tabs a, b, c: Check the "Editor" Checkbox (Visibility) * Save changes * find a book, eg again "Perl best practices" and edit it * find field 264 and enter "Test" into 264a, Save * Depending on your setup, you might have to manually re-index the book: * enter ktd: ktd --shell * reindex the one book (via --bn) or all (might also need a -d) /usr/share/koha/bin/search_tools/rebuild_elasticsearch.pl -v -b -d * Go again to Advanced Search, Publisher Location = "Test" * You should find the book If your NOT running ktd, you might be able to just edit the ElasticSearch Mappings to add / change the mapping for "pl" to point to "260a". One rather harsh way to do this (which I needed to do, because the ES Mappings UI did not work for me) is via this SQL: update search_marc_map set marc_field='260a' where marc_field='008_/15-17'; Sponsored-by: Steiermärkische Landesbibliothek -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162913|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 162932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162932&action=edit Bug 36269: ElasticSearch: publisher-location (pl) should use260a/264a Currently the index `pl` points to 008/15-17. It should (additionally/instead?) point to 260a and/or 264a. Test plan (for koha-testing-docker with ElasticSearch via `ktd --es7 up`) Verify the old/broken behaviour: * Go to Staff/Advanced Search * Select "Publisher Location" and enter "cau", start search * You will get some hits (~16), eg "Perl best practices / Damian Conway", which has 008 of "051222s2005 caua b 001 0 eng d" with "cau" on 15-17 * Edit this record (cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=5) * Inspect 260$a, which should containt "Sebastopol, CA :" * Go back to Advanced Search and search for "Publisher Location" = "Sebastopol" * No hits! Apply the patch! * exit ktd and stop it (ktd --es7 down; ktd --es7 stop) * start it again * Go to Staff / Administration / Search Engine Config (Elasticsearch) * Click on the Tab "Bibliographic records" and search/filter for "pl" * you should see 3 entries for "pl", with Mapping values of "008_/15-17", "260a" and "264a" * Go to Search, * Select "Publisher Location" and enter "cau", start search * same hits as befor * Search again, but for "Sebastopol" * Now you'll get 9 hits!! Bonus: Test 264a * Got to Admin / MARC bibl framework, select BKS -> MARC structure * search for tag "264", edit subfields * in tabs a, b, c: Check the "Editor" Checkbox (Visibility) * Save changes * find a book, eg again "Perl best practices" and edit it * find field 264 and enter "Test" into 264a, Save * Depending on your setup, you might have to manually re-index the book: * enter ktd: ktd --shell * reindex the one book (via --bn) or all (might also need a -d) /usr/share/koha/bin/search_tools/rebuild_elasticsearch.pl -v -b -d * Go again to Advanced Search, Publisher Location = "Test" * You should find the book If your NOT running ktd, you might be able to just edit the ElasticSearch Mappings to add / change the mapping for "pl" to point to "260a". One rather harsh way to do this (which I needed to do, because the ES Mappings UI did not work for me) is via this SQL: update search_marc_map set marc_field='260a' where marc_field='008_/15-17'; Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I was able to rebuild and get the new mappings using the following command in ktd --shell koha-elasticsearch --rebuild -r -d -b -v kohadev -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ElasticSearch: |Elasticsearch: |publisher-location (pl) |publisher-location (pl) |index should use 264a |index should include | |264a/264a -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this is more of a bug fix really, as we offer "publisher location" as a search option in the advanced search and have search links in the detail pages. Thanks, Thomas! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch: |Elasticsearch: |publisher-location (pl) |publisher-location (pl) |index should include |index should include |264a/264a |260a/264a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch: |Elasticsearch: |publisher-location (pl) |publisher-location (pl) |index should include |index should include |260a/264a |260a/264a (MARC21) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |domm@plix.at |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162932|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164224&action=edit Bug 36269: ElasticSearch: publisher-location (pl) should use260a/264a Currently the index `pl` points to 008/15-17. It should (additionally/instead?) point to 260a and/or 264a. Test plan (for koha-testing-docker with ElasticSearch via `ktd --es7 up`) Verify the old/broken behaviour: * Go to Staff/Advanced Search * Select "Publisher Location" and enter "cau", start search * You will get some hits (~16), eg "Perl best practices / Damian Conway", which has 008 of "051222s2005 caua b 001 0 eng d" with "cau" on 15-17 * Edit this record (cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=5) * Inspect 260$a, which should containt "Sebastopol, CA :" * Go back to Advanced Search and search for "Publisher Location" = "Sebastopol" * No hits! Apply the patch! * exit ktd and stop it (ktd --es7 down; ktd --es7 stop) * start it again * Go to Staff / Administration / Search Engine Config (Elasticsearch) * Click on the Tab "Bibliographic records" and search/filter for "pl" * you should see 3 entries for "pl", with Mapping values of "008_/15-17", "260a" and "264a" * Go to Search, * Select "Publisher Location" and enter "cau", start search * same hits as befor * Search again, but for "Sebastopol" * Now you'll get 9 hits!! Bonus: Test 264a * Got to Admin / MARC bibl framework, select BKS -> MARC structure * search for tag "264", edit subfields * in tabs a, b, c: Check the "Editor" Checkbox (Visibility) * Save changes * find a book, eg again "Perl best practices" and edit it * find field 264 and enter "Test" into 264a, Save * Depending on your setup, you might have to manually re-index the book: * enter ktd: ktd --shell * reindex the one book (via --bn) or all (might also need a -d) /usr/share/koha/bin/search_tools/rebuild_elasticsearch.pl -v -b -d * Go again to Advanced Search, Publisher Location = "Test" * You should find the book If your NOT running ktd, you might be able to just edit the ElasticSearch Mappings to add / change the mapping for "pl" to point to "260a". One rather harsh way to do this (which I needed to do, because the ES Mappings UI did not work for me) is via this SQL: update search_marc_map set marc_field='260a' where marc_field='008_/15-17'; Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- I must admin, we have had it this way in our mappings internally for some time - been on the list to reconcile what we have against community version -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- For upgrades, I think this will need a complete rebuild, correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #9)
For upgrades, I think this will need a complete rebuild, correct?
I think any change to the indexing configuration would require a reindex, but you will also need to configure these or reset your mappings on update - we are not changing existing mappings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds 260$a release notes| |and 264$a to the | |publisher-location (pl) | |Elasticsearch index for | |MARC21 records. Values in | |those two fields will be | |findable using the | |Publisher location option | |in the advanced search. | | | |Note: for existing | |installations, the index | |needs to be rebuild using | |-r (reset mappings) in | |order for this information | |to be taken into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36578 [Bug 36578] Elasticsearch: publisher-location (pl) index should include field 752 (for old prints) and also support UNIMARC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds 260$a |This enhancement adds 260$a release notes|and 264$a to the |and 264$a to the |publisher-location (pl) |publisher-location (pl) |Elasticsearch index for |Elasticsearch index for |MARC21 records. Values in |MARC21 records. Values in |those two fields will be |those two fields will be |findable using the |findable using the |Publisher location option |Publisher location option |in the advanced search. |in the advanced search. | | |Note: for existing |Note: for existing |installations, the index |installations, the index |needs to be rebuild using |needs to be rebuilt using |-r (reset mappings) in |-r (reset mappings) in |order for this information |order for this information |to be taken into account. |to be taken into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36269 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org