[Bug 23296] New: Auto Renewal Notice does not use Library specific notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Bug ID: 23296 Summary: Auto Renewal Notice does not use Library specific notices Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org All notices in Koha are created to be a default ALL libraries notice, however, with branch systems, there is also the ability to create a library specific notice that can be used instead. However, the notice AUTO_RENEWALS is not currently capable of being library specific - instead, the ALL Library Notice for AUTO_RENEWALS is the only one that Koha send. To adjust this, it would be recommended that a library specific notice like all the others in Koha can be created. Following circ control, would be the suggested way to go as with most notices in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Until this is fixed here is a workaround. Edit the (All libraries) AUTO_RENEWALS notice like so: [% whichbranch = borrower.branchcode %] [% IF whichbranch == "BRANCHCODE" %] some specific branch notice stuff about auto renewal [% ELSE %] some generic notice stuff about auto renewal [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Lucas examples uses the patron's homebranch and I think this is also the behaviour I would expect. The patron's homebranch is a singular value, we will end up with one notice, either default or a branch specific one. The CircControl preference states it's used for determining how to calculate fines and for which circulation rule to use, it doesn't state anything about notices. It also has an option for "where you are logged in" that doesn't apply well to automatically send notices. And last, if it was set to "where the item is from" and you have items from multiple branches, we'd have to split into multiple notices to follow that preference. ... and we really should document somewhere how the multiple notices work regarding to who the notices are sent from and which templates are used. It's not only about the template, but also about the email addresses that appear as sender etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, was discussing this at length with Putti on IRC, but it's quite confusing still. Bug 7001, comment 44 points to the use of CircControl for the notices too.
You will be happy to know that with CircControl set to "the library you are logged in at" the notices all work the way one would expect.
But what would is the expected behaviour in this case? I think the least we should do is clear this up, document and amend the text of the system preference. I am always pro consistency ... and documentation :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |lucas@bywatersolutions.com Severity|enhancement |normal Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- I think this should be consistent with the behavior of the digest version of the notice. So we should send the notice based on the patron's branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161469&action=edit Bug 23296: Set patron branchcode when preparing non-digest version To test: 1. APPLY PATCH 2. Set up circ rules to allow for auto renewals. 3. Set AutoRenewalNotices to 'according to message prefs' 4. Make a branch specific version of the the AUTO_RENEWAL notice. 5. Find a patron belonging to that branch and set the message prefs to allow for a AUTO_RENEWAL. But no digest option! 6. Check some things out and make sure they are eligble for auto renewal. 7. Run the cron. 8. Make sure the patron gets the branch specific notice. 9. Delete the branch specific notice. 10. DO 6-7 again. 11. Make sure they now get the all library notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161469|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 162127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162127&action=edit Bug 23296: Set patron branchcode when preparing non-digest version To test: 1. APPLY PATCH 2. Set up circ rules to allow for auto renewals. 3. Set AutoRenewalNotices to 'according to message prefs' 4. Make a branch specific version of the the AUTO_RENEWAL notice. 5. Find a patron belonging to that branch and set the message prefs to allow for a AUTO_RENEWAL. But no digest option! 6. Check some things out and make sure they are eligble for auto renewal. 7. Run the cron. 8. Make sure the patron gets the branch specific notice. 9. Delete the branch specific notice. 10. DO 6-7 again. 11. Make sure they now get the all library notice. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Some notes to make testing autorenewals easier: In circulation and fine rules loan period: 3 renewal period: 3 No automatic renewal before: 3 Automatic renewal : yes In system preferences NoRenewalBeforePrecision: date after checking out items run ./misc/cronjobs/automatic_renewals.pl to confirm items would be renewed then run again with options -c -v before checking the notices tab for the patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162127|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 164452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164452&action=edit Bug 23296: Set patron branchcode when preparing non-digest version To test: 1. APPLY PATCH 2. Set up circ rules to allow for auto renewals. 3. Set AutoRenewalNotices to 'according to message prefs' 4. Make a branch specific version of the the AUTO_RENEWAL notice. 5. Find a patron belonging to that branch and set the message prefs to allow for a AUTO_RENEWAL. But no digest option! 6. Check some things out and make sure they are eligble for auto renewal. 7. Run the cron. 8. Make sure the patron gets the branch specific notice. 9. Delete the branch specific notice. 10. DO 6-7 again. 11. Make sure they now get the all library notice. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Tidied one line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com --- Comment #10 from Laura O'Neil <laura@bywatersolutions.com> --- Might this be backported to 23.11 or 23.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23296 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org