https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10787, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18586 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Working on unit tests now but have found a bug in RDF::Trine::Store::SPARQL so will have to do a workaround tomorrow for that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #3)

Actually the workaround might be more inefficient so I'd rather just patch RDF::Trine::Store::SPARQL...

Well actually... I thought of a different workaround which will be fine for now, and I've sent a pull request with a patch for RDF::Trine::Store::SPARQL (https://github.com/kasei/perlrdf/pull/150). The author of RDF::Trine has already said that he'd welcome a patch for the bug, so that's good. For the previous bug I found in RDF::Trine::Store::SPARQL, I sent a pull request 23 days ago, it was merged into master 14 days ago, and a new version of RDF::Trine was posted on CPAN 1 day ago (a dev release was on CPAN on May 19th so 14 days ago). So I imagine that by the time we're at Koha 17.11, the updated version will be on CPAN and be easy to package. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63908|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 63909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63909&action=edit Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF This patch adds methods to Koha::RDF that creates or deletes a named graph by removing/adding RDF quads from/to a triplestore. This patch also can create a rdfs:seeAlso relationship between two RDF entities. This patch includes unit tests for both of these changes. _TEST PLAN_ 1) Run "prove t/Koha/RDF.t" 2) Note that all tests have run successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63909|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 64020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64020&action=edit [SIGNED-OFF] Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF This patch adds methods to Koha::RDF that creates or deletes a named graph by removing/adding RDF quads from/to a triplestore. This patch also can create a rdfs:seeAlso relationship between two RDF entities. This patch includes unit tests for both of these changes. _TEST PLAN_ 1) Run "prove t/Koha/RDF.t" 2) Note that all tests have run successfully. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to Brendan Gallagher from comment #8)

Is it me and I missed something?

While working with RDF::Trine, I've noticed that there are a few bugs. I've been sending patches to the maintainer to fix them as I find them, but it seems that you've encountered a bug in an older version of RDF::Trine which has already been fixed long ago. I'm operating off of the most recent versions of RDF::Trine. I'm guessing that you're on Debian Jessie which is on version 1.011 (https://packages.debian.org/jessie/librdf-trine-perl). It looks like there was a bug that was fixed in 1.013. After that, the tests pass. The current version of RDF::Trine is 1.017 and there is a dev version 1.017_1 which is in testing on http://cpantesters.org/ and will yield a 1.018 in the next few weeks I imagine. I've already talked to Mirko and he's happy to package the latest RDF::Trine in the Koha Debian repository. Perhaps I should get him to do that before QA continues on this patch? If you want to double-check what I'm saying now, you can clone the git repo from https://github.com/kasei/perlrdf, then run something like 'perl -I ~/perlrdf/RDF-Trine/lib t/Koha/RDF.t' and then the tests should pass. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Hey Brendan, I just noticed that Debian Stretch is the new Debian stable. It looks like it has RDF::Trine 1.015, which should pass these tests. Alternatively, Mirko has uploaded RDF::Trine 1.018 to Koha unstable (and Jonas Smedegaard has uploaded RDF::Trine 1.018 to Debian unstable): "I have backported librdf-trine-perl 1.018-1 to the Koha unstable repository. Please use option 1: install the package from our repository and report problems if you encounter any." (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Assigning to David as he is the author of the patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #13 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69633&action=edit Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF This patch adds methods to Koha::RDF that creates or deletes a named graph by removing/adding RDF quads from/to a triplestore. This patch also can create a rdfs:seeAlso relationship between two RDF entities. This patch includes unit tests for both of these changes. _TEST PLAN_ 1) Run "prove t/Koha/RDF.t" 2) Note that all tests have run successfully. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Test fails. Seems to be reported before. Versioning/packaging ? Needs further attention.. # Subtest: Create and delete named graphs 1..3 not ok 1 - 2 statements in model (in default graph and a named graph) # Failed test '2 statements in model (in default graph and a named graph)' # at t/Koha/RDF.t line 65. # got: '1' # expected: '2' not ok 2 - 3 statements in model (1 in default graph and 2 in separate named graphs # Failed test '3 statements in model (1 in default graph and 2 in separate named graphs' # at t/Koha/RDF.t line 71. # got: '1' # expected: '3' not ok 3 - 2 statements in model (1 in default graph and 1 in a named graph) after 1 of the named graphs was deleted # Failed test '2 statements in model (1 in default graph and 1 in a named graph) after 1 of the named graphs was deleted' # at t/Koha/RDF.t line 77. # got: '1' # expected: '2' # Looks like you failed 3 tests of 3. not ok 4 - Create and delete named graphs # Failed test 'Create and delete named graphs' # at t/Koha/RDF.t line 78. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #15)

(In reply to Marcel de Rooy from comment #14)

...

Test fails. Seems to be reported before. Versioning/packaging ? Needs further attention..

What operating system are you using, Marcel, and what version of RDF::Trine?

Mirko has the required version in the Koha unstable package repo and the particular bug in question making the test fail should be resolved in Debian stable (Stretch) now.

Debian Jessie. Do we support Koha on Stretch? No problems when switching to MariaDB? I have not tested the unstable repo very recently, but last time I tried it did not work (yes unstable). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |mirko@abunchofthings.net --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #17)

I suppose it's a bit of a catch-22... you need the dependency for it to pass QA but the dependency won't be added until the patch passes QA?

No, that cant be true. I will reset the status. If another QAer can test on Stretch, he may recommend to add the higher version to the Koha repo. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #19 from Mirko Tietgen <mirko@abunchofthings.net> --- Not sure if I get it right. Is the test failing because the dependency is not declared in the patch set? I think it should be, which should lead to the dependency being pulled from the unstable repo (in a dev environment). Also, what version do we actually need? Stretch has 1.015. Our repo has 1.018, AFAIR because that was the latest unstable available at the time of packaging and stretch was not yet released. Which version do we actually require for it to work for us? Is 1.015 enough? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #21 from Mirko Tietgen <mirko@abunchofthings.net> ---

From this[1] comment by David on bug 10662 I take we need 1.018 anyway and the version in Stretch is not enough for all enhancements.

It should pass the test for this patch, but we require a higher version for the harvesting client. David, can you confirm that is correct? [1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662#c128 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #23 from David Cook <dcook@prosentient.com.au> --- Or maybe I added the dependency to #18585 ... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 [Bug 18585] Connect to RDF triplestore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Bug 18713 depends on bug 18586, which changed state. Bug 18586 Summary: Create module to mint RDF subject URIs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- This one still seems to apply on master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10662 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 [Bug 10662] Build OAI-PMH Harvesting Client -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #30 from Josef Moravec <josef.moravec@gmail.com> --- Rebased on top of signed off patches from bug 18585 and set back to signed off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |joy@bywatersolutions.com --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #26)

After gaining more experience with RDF and triplestores, I'm not really happy with this one anymore.

This functionality should probably be moved into a Koha::RDF::Triplestore module, as it's very triplestore specific... or maybe Koha::RDF::Model... since you could use other non-triplestore models.

But there's other things that can be done in Koha::RDF that don't need to relate to models/triplestores...

For what it's worth, I'm no longer convinced what I have here is the best way >forward, but I suppose it's better than nothing.

Those comments make me doubt that we should put more work into this. I'd really like to get more opinions on this. I am asking for a second sign-off, also to widen the audience on this bug beyond the QA team. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #34 from David Cook <dcook@prosentient.com.au> --- We need to actually implement RDF in Koha before we think about this sort of thing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 --- Comment #35 from David Cook <dcook@prosentient.com.au> --- Note that I do not have any intention on working on this again, and I think that it might be a good idea to remove the existing implementation of Koha::RDF... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 Bug 18713 depends on bug 18585, which changed state. Bug 18585 Summary: Connect to RDF triplestore https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18585 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WISHLIST -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.