https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/PTFS-Eur | |ope/koha/commits/bug_38441/ CC| |andrew.auld@ptfs-europe.com | |, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174604&action=edit Bug 38441: New 'ILLHistoryCheck' system preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174606&action=edit Bug 38441: HistoryCheck Koha class -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174608&action=edit Bug 38441: ILLHistoryCheck: OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 174610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174610&action=edit Bug 38441: Style updates for staffnotes - Use pre for staffnotes in staff illview - Ensure <pre> has same font-family as rest of the page - Render html for staff notes in list. Truncate to 100 chars max -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller@ukhsa.gov.uk, | |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174604|0 |1 is obsolete| | --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175300&action=edit Bug 38441: New 'ILLHistoryCheck' system preference -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174606|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175302&action=edit Bug 38441: HistoryCheck Koha class -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174608|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175304&action=edit Bug 38441: ILLHistoryCheck: OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174610|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175306&action=edit Bug 38441: Style updates for staffnotes - Use pre for staffnotes in staff illview - Ensure <pre> has same font-family as rest of the page - Render html for staff notes in list. Truncate to 100 chars max -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 [Bug 38685] ILL pages have incomplete breadcrumbs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175301|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176508&action=edit Bug 38441: atomicupdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175303|0 |1 is obsolete| | --- Comment #20 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176510&action=edit Bug 38441: ILLHistoryCheck: Staff UI -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175305|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176512&action=edit Bug 38441: Allow / render HTML in ILL staff notes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175307|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176514&action=edit Bug 38441: Add tests Test plan: 1) Apply patches 2) Run (ignore if using a sandbox): $ reset_all 3) Visit ILL system preferences: <staff_url>/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 4) Enable ILLModule and ILLHistoryCheck system preferences -- STAFF testing -- 5) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 6) Pick type = 'Journal article', enter '123' for ISSN, '42' for cardnumber and any library. Click create. 7) Repeat 5) and 6). Notice you're now on the 'Request history check' screen. Verify your previous ILL request is listed. Click 'Submit anyway'. 8) Repeat 5) and 6). But pick a different patron cardnumber this time e.g. '23529000035676'. 9) Verify you're shown the 'Request history check' screen listing the 2 previously created requests. Click 'Submit anyway'. 10) Repeat 5 and 6). Use cardnumber '23529000035676' again. 11) Verify you're shown the 'Request history check' screen. The listing now shows the requests found for this patron first, then lists the remaining found requests for other patrons. -- OPAC testing -- 12) Place a new request through the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 13) Pick type = 'Journal article', enter '123' for ISSN. Click 'Create'. Notice it shows the 'history check' screen listing the existing 2 requests. Click 'Submit anyway'. 14) Return to the Staff UI: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 15) Click on the latest ILL request. Verify 'Staff notes' contain information relating to already existing ILL requests. -- Bonus testing -- 16) On the Staff UI, create a new request for cardnumber 23529000035676 with ISSN = 321 17) On the OPAC, logged in as koha:koha, place a request with ISSN = 321. Verify you don't get shown the history check but the staff notes is still added 18) Play around with ILLModuleDisclaimerByType and ILLOpacUnauthenticatedRequest (easy) 19) Play around with ILLCheckAvailability and AutoILLBackendPriority (reach out for help using these preferences) Run tests: $ prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #26 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176561&action=edit Bug 38441: (QA follow-up): Handle undef userenv C4::Context->userenv may be undef (after a reset_all, trying to place an unauthenticated request without being logged). This change prevents a nasty 500 error trying use undefined as hash -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 176573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176573&action=edit Bug 38441: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176508|0 |1 is obsolete| | --- Comment #31 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179801&action=edit Bug 38441: atomicupdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176510|0 |1 is obsolete| | --- Comment #33 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179803&action=edit Bug 38441: ILLHistoryCheck: Staff UI -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176512|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179805&action=edit Bug 38441: Allow / render HTML in ILL staff notes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176514|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179807&action=edit Bug 38441: Add tests Test plan: 1) Apply patches 2) Run (ignore if using a sandbox): $ reset_all 3) Visit ILL system preferences: <staff_url>/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 4) Enable ILLModule and ILLHistoryCheck system preferences -- STAFF testing -- 5) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 6) Pick type = 'Journal article', enter '123' for ISSN, '42' for cardnumber and any library. Click create. 7) Repeat 5) and 6). Notice you're now on the 'Request history check' screen. Verify your previous ILL request is listed. Click 'Submit anyway'. 8) Repeat 5) and 6). But pick a different patron cardnumber this time e.g. '23529000035676'. 9) Verify you're shown the 'Request history check' screen listing the 2 previously created requests. Click 'Submit anyway'. 10) Repeat 5 and 6). Use cardnumber '23529000035676' again. 11) Verify you're shown the 'Request history check' screen. The listing now shows the requests found for this patron first, then lists the remaining found requests for other patrons. -- OPAC testing -- 12) Place a new request through the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 13) Pick type = 'Journal article', enter '123' for ISSN. Click 'Create'. Notice it shows the 'history check' screen listing the existing 2 requests. Click 'Submit anyway'. 14) Return to the Staff UI: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 15) Click on the latest ILL request. Verify 'Staff notes' contain information relating to already existing ILL requests. -- Bonus testing -- 16) On the Staff UI, create a new request for cardnumber 23529000035676 with ISSN = 321 17) On the OPAC, logged in as koha:koha, place a request with ISSN = 321. Verify you don't get shown the history check but the staff notes is still added 18) Play around with ILLModuleDisclaimerByType and ILLOpacUnauthenticatedRequest (easy) 19) Play around with ILLCheckAvailability and AutoILLBackendPriority (reach out for help using these preferences) Run tests: $ prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176566|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179809&action=edit Bug 38441: (QA follow-up): Fix find-misplaced-executables.t It appears the atomic update had wrong permissions: prove xt/find-misplaced-executables.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #41 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 179811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179811&action=edit Bug 38441: (QA follow-up): HistoryCheck now only considers same patron Initial implementation checked existing ILLs for same patron and other patrons. User testing reported ILLs for other patrons are not helpful, and makes this stage screen show up much more frequently than it should. This patch simplifies the original implementation to only consider the patron of the request being placed for an ILL history check. It also changes the ID matching to only 'DOI' or only 'Pubmed ID' if any of those is set. This is to minimize scenarios where different articles from the same journal come up as matching results e.g. same ISSN but different DOI. It is also updating tests accordingly. Other QA improvements Improve HistoryCheck request list: - Make link external and show icon (to prevent staff member from clicking away from the historyCheck screen unintentionally) - Show requests' status - Show requests' placed date - Add id_prefix to request ID if possible -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179801|0 |1 is obsolete| | --- Comment #44 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 180035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180035&action=edit Bug 38441: atomicupdate Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179803|0 |1 is obsolete| | --- Comment #46 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 180037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180037&action=edit Bug 38441: ILLHistoryCheck: Staff UI Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179805|0 |1 is obsolete| | --- Comment #48 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 180039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180039&action=edit Bug 38441: Allow / render HTML in ILL staff notes Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179807|0 |1 is obsolete| | --- Comment #50 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 180041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180041&action=edit Bug 38441: Add tests Test plan: 1) Apply patches 2) Run (ignore if using a sandbox): $ reset_all 3) Visit ILL system preferences: <staff_url>/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 4) Enable ILLModule and ILLHistoryCheck system preferences -- STAFF testing -- 5) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 6) Pick type = 'Journal article', enter '123' for ISSN, '42' for cardnumber and any library. Click create. 7) Repeat 5) and 6). Notice you're now on the 'Request history check' screen. Verify your previous ILL request is listed. Click 'Submit anyway'. 8) Repeat 5) and 6). But pick a different patron cardnumber this time e.g. '23529000035676'. 9) Verify you're shown the 'Request history check' screen listing the 2 previously created requests. Click 'Submit anyway'. 10) Repeat 5 and 6). Use cardnumber '23529000035676' again. 11) Verify you're shown the 'Request history check' screen. The listing now shows the requests found for this patron first, then lists the remaining found requests for other patrons. -- OPAC testing -- 12) Place a new request through the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 13) Pick type = 'Journal article', enter '123' for ISSN. Click 'Create'. Notice it shows the 'history check' screen listing the existing 2 requests. Click 'Submit anyway'. 14) Return to the Staff UI: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 15) Click on the latest ILL request. Verify 'Staff notes' contain information relating to already existing ILL requests. -- Bonus testing -- 16) On the Staff UI, create a new request for cardnumber 23529000035676 with ISSN = 321 17) On the OPAC, logged in as koha:koha, place a request with ISSN = 321. Verify you don't get shown the history check but the staff notes is still added 18) Play around with ILLModuleDisclaimerByType and ILLOpacUnauthenticatedRequest (easy) 19) Play around with ILLCheckAvailability and AutoILLBackendPriority (reach out for help using these preferences) Run tests: $ prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179809|0 |1 is obsolete| | --- Comment #52 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 180043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180043&action=edit Bug 38441: (QA follow-up): Fix find-misplaced-executables.t It appears the atomic update had wrong permissions: prove xt/find-misplaced-executables.t Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179811|0 |1 is obsolete| | --- Comment #54 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 180045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180045&action=edit Bug 38441: (QA follow-up): HistoryCheck now only considers same patron Initial implementation checked existing ILLs for same patron and other patrons. User testing reported ILLs for other patrons are not helpful, and makes this stage screen show up much more frequently than it should. This patch simplifies the original implementation to only consider the patron of the request being placed for an ILL history check. It also changes the ID matching to only 'DOI' or only 'Pubmed ID' if any of those is set. This is to minimize scenarios where different articles from the same journal come up as matching results e.g. same ISSN but different DOI. It is also updating tests accordingly. Other QA improvements Improve HistoryCheck request list: - Make link external and show icon (to prevent staff member from clicking away from the historyCheck screen unintentionally) - Show requests' status - Show requests' placed date - Add id_prefix to request ID if possible Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180035|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180908&action=edit Bug 38441: atomicupdate Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180037|0 |1 is obsolete| | --- Comment #59 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180910&action=edit Bug 38441: ILLHistoryCheck: Staff UI Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180039|0 |1 is obsolete| | --- Comment #61 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180912&action=edit Bug 38441: Allow / render HTML in ILL staff notes Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180041|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180914&action=edit Bug 38441: Add tests Test plan: 1) Apply patches 2) Run (ignore if using a sandbox): $ reset_all 3) Visit ILL system preferences: <staff_url>/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 4) Enable ILLModule and ILLHistoryCheck system preferences -- STAFF testing -- 5) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 6) Pick type = 'Journal article', enter '123' for DOI, '42' for cardnumber and any library. Click create. 7) Repeat 5) and 6). Notice you're now on the 'Request history check' screen. Verify your previous ILL request is listed. Click 'Submit anyway'. 8) Repeat 5) and 6). But pick a different patron cardnumber this time e.g. '23529000035676'. 9) Verify you're not shown the 'Request history check' screen as its a different patron. -- OPAC testing -- 10) Place a new request through the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 11) Pick type = 'Journal article', enter '123' for DOI. Click 'Create'. Notice it shows the 'history check' screen listing the existing requests. Click 'Submit anyway'. 12) Return to the Staff UI: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click on the latest ILL request. Verify 'History check requests' is displayed and contains information relating to the already existing ILL requests. -- Bonus testing -- 16) Play around with ILLModuleDisclaimerByType and ILLOpacUnauthenticatedRequest enabled at the same time as HistoryCheck (easy) 17) Play around with ILLCheckAvailability and AutoILLBackendPriority enabled at the same time as HistoryCheck (reach out for help using these preferences) Run tests: $ prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180043|0 |1 is obsolete| | --- Comment #65 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180916&action=edit Bug 38441: (QA follow-up): Fix find-misplaced-executables.t It appears the atomic update had wrong permissions: prove xt/find-misplaced-executables.t Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180045|0 |1 is obsolete| | --- Comment #67 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180918&action=edit Bug 38441: (QA follow-up): HistoryCheck now only considers same patron Initial implementation checked existing ILLs for same patron and other patrons. User testing reported ILLs for other patrons are not helpful, and makes this stage screen show up much more frequently than it should. This patch simplifies the original implementation to only consider the patron of the request being placed for an ILL history check. It also changes the ID matching to only 'DOI' or only 'Pubmed ID' if any of those is set. This is to minimize scenarios where different articles from the same journal come up as matching results e.g. same ISSN but different DOI. It is also updating tests accordingly. Other QA improvements Improve HistoryCheck request list: - Make link external and show icon (to prevent staff member from clicking away from the historyCheck screen unintentionally) - Show requests' status - Show requests' placed date - Add id_prefix to request ID if possible Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #69 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi guys thank you for your patience here. I've now rebased the patch set on top of the updated bug 36197 and bug 38685 and followed up with all the QA feedback provided at Hackfest. Thank you in advance for the time spent here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | --- Comment #71 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi, it all looks great. Can you check this failing test: ```shell kohadev-koha@kohadevbox:koha(qa_38441)$ prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t .. 1/2 # Looks like you planned 2 tests but ran 1. # Failed test 'after_request_created' # at t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t line 188. Can't call method "value" on an undefined value at t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t line 182. # Looks like your test exited with 11 just after 2. t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t (Wstat: 2816 (exited 11) Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 11 Files=1, Tests=2, 2 wallclock secs ( 0.01 usr 0.02 sys + 1.19 cusr 0.62 csys = 1.84 CPU) Result: FAIL ``` -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181072|0 |1 is obsolete| | --- Comment #72 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181111&action=edit Bug 38441: (QA follow-up): Only look for matchin requests if patron Previous commit 'HistoryCheck now only considers same patron' added the following regression: HistoryCheck is performed and shown in the OPAC even if no user is authenticated (using ILLOpacUnauthenticatedRequest). This fixes that. History check is skipped unless a user exists. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #75 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181113&action=edit Bug 38441: atomicupdate Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #77 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181115&action=edit Bug 38441: ILLHistoryCheck: Staff UI Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #79 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181117&action=edit Bug 38441: Allow / render HTML in ILL staff notes Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #81 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181119&action=edit Bug 38441: Add tests Test plan: 1) Apply patches 2) Run (ignore if using a sandbox): $ reset_all 3) Visit ILL system preferences: <staff_url>/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 4) Enable ILLModule and ILLHistoryCheck system preferences -- STAFF testing -- 5) Create a new ILL request, visit: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 6) Pick type = 'Journal article', enter '123' for DOI, '42' for cardnumber and any library. Click create. 7) Repeat 5) and 6). Notice you're now on the 'Request history check' screen. Verify your previous ILL request is listed. Click 'Submit anyway'. 8) Repeat 5) and 6). But pick a different patron cardnumber this time e.g. '23529000035676'. 9) Verify you're not shown the 'Request history check' screen as its a different patron. -- OPAC testing -- 10) Place a new request through the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 11) Pick type = 'Journal article', enter '123' for DOI. Click 'Create'. Notice it shows the 'history check' screen listing the existing requests. Click 'Submit anyway'. 12) Return to the Staff UI: <staff_url>/cgi-bin/koha/ill/ill-requests.pl 13) Click on the latest ILL request. Verify 'History check requests' is displayed and contains information relating to the already existing ILL requests. -- Bonus testing -- 16) Play around with ILLModuleDisclaimerByType and ILLOpacUnauthenticatedRequest enabled at the same time as HistoryCheck (easy) 17) Play around with ILLCheckAvailability and AutoILLBackendPriority enabled at the same time as HistoryCheck (reach out for help using these preferences) Run tests: $ prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #83 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181121&action=edit Bug 38441: (QA follow-up): Fix find-misplaced-executables.t It appears the atomic update had wrong permissions: prove xt/find-misplaced-executables.t Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #85 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181123&action=edit Bug 38441: (QA follow-up): HistoryCheck now only considers same patron Initial implementation checked existing ILLs for same patron and other patrons. User testing reported ILLs for other patrons are not helpful, and makes this stage screen show up much more frequently than it should. This patch simplifies the original implementation to only consider the patron of the request being placed for an ILL history check. It also changes the ID matching to only 'DOI' or only 'Pubmed ID' if any of those is set. This is to minimize scenarios where different articles from the same journal come up as matching results e.g. same ISSN but different DOI. It is also updating tests accordingly. Other QA improvements Improve HistoryCheck request list: - Make link external and show icon (to prevent staff member from clicking away from the historyCheck screen unintentionally) - Show requests' status - Show requests' placed date - Add id_prefix to request ID if possible Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #87 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181125&action=edit Bug 38441: (QA follow-up): Only look for matchin requests if patron Previous commit 'HistoryCheck now only considers same patron' added the following regression: HistoryCheck is performed and shown in the OPAC even if no user is authenticated (using ILLOpacUnauthenticatedRequest). This fixes that. History check is skipped unless a user exists. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply Keywords| |rel_25_05_candidate --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to apply this on top of 36197, but got: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38441: New 'ILLHistoryCheck' system preference Applying: Bug 38441: atomicupdate Applying: Bug 38441: HistoryCheck Koha class Applying: Bug 38441: ILLHistoryCheck: Staff UI error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt). error: could not build fake ancestor Patch failed at 0001 Bug 38441: ILLHistoryCheck: Staff UI hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38441-ILLHistoryCheck-Staff-UI-3hshu7iy.patch Can you please rebase ASAP? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181112|0 |1 is obsolete| | --- Comment #90 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181593&action=edit Bug 38441: New 'ILLHistoryCheck' system preference Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181114|0 |1 is obsolete| | --- Comment #92 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181595&action=edit Bug 38441: HistoryCheck Koha class Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181116|0 |1 is obsolete| | --- Comment #94 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181597&action=edit Bug 38441: ILLHistoryCheck: OPAC Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181118|0 |1 is obsolete| | --- Comment #96 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181599&action=edit Bug 38441: Style updates for staffnotes - Use pre for staffnotes in staff illview - Ensure <pre> has same font-family as rest of the page - Render html for staff notes in list. Truncate to 100 chars max Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181120|0 |1 is obsolete| | --- Comment #98 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181601&action=edit Bug 38441: (QA follow-up): Handle undef userenv C4::Context->userenv may be undef (after a reset_all, trying to place an unauthenticated request without being logged). This change prevents a nasty 500 error trying use undefined as hash Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181122|0 |1 is obsolete| | --- Comment #100 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181603&action=edit Bug 38441: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181124|0 |1 is obsolete| | --- Comment #102 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181605&action=edit Bug 38441: (QA follow-up): Hackfest feedback This commit addresses all Hackfest QA related feedback: 1) Update of all strings that required update, including UI messages and sys pref description 2) Moved the history check information from staffnotes to its own pipe-separated illrequestattribute 'historycheck_requests' 3) Fix display of ILL request information on the history check screen (Staff), including proper label naming (e.g. branchcode -> library), show status description instead of code, uppercase labels. 4) Updated OPAC display to match Staff UI's display of matching history requests 5) Removed ISSN criteria for matching requests check 6) Update tests accordingly Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181126|0 |1 is obsolete| | --- Comment #104 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181607&action=edit Bug 38441: (QA follow-up) Minor change Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 --- Comment #105 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39875 [Bug 39875] ILL - History check fails if unauthenticated request -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #106 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 36197 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 Bug 38441 depends on bug 37448, which changed state. Bug 37448 Summary: Add build_sample_ill_request to TestBuilder.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37448 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.