https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181672&action=edit Bug 39777: Use cardnumber OR authenticated user cardnumber Test plan: 1) Apply the 'rollback tests' patch to reinstate the testing of the behavior if a cardnumber is missing (and a user is authenticated) 2) Run tests (they should fail): prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 3) Apply this patch. Repeat 2) They should pass. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181672|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 181674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181674&action=edit Bug 39777: Use cardnumber OR authenticated user cardnumber Test plan: 1) Apply the 'rollback tests' patch to reinstate the testing of the behavior if a cardnumber is missing (and a user is authenticated) 2) Run tests (they should fail): prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 3) Apply this patch. Repeat 2) They should pass. Test plan for UI: 1) Enable ILLModule and ILLHistoryCheck 2) Create a new ILL on OPAC, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Select type="journal", enter DOI = "123". Create. 4) Repeat steps 2 and 3. A history check screen should be displayed (it is not, before this patch). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181671|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 181692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181692&action=edit Bug 39777: Rollback tests These tests should test an authenticated patron, without the presence of a cardnumber in the metadata (as it is the case in the OPAC form) This is also the reason why we mock_userenv right below this. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the ILL history release notes| |check tests. It also | |restores the ILL history | |check when creating an ILL | |request in the OPAC. If a | |potential duplicate request | |is made (for example the | |patron has already made a | |request using the same DOI, | |Pubmed ID, or ISBN), it now | |displays the request | |history check page (when | |the ILLHistoryCheck system | |preference is enabled). CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 182108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182108&action=edit Bug 39777: Use cardnumber OR authenticated user cardnumber Test plan: 1) Apply the 'rollback tests' patch to reinstate the testing of the behavior if a cardnumber is missing (and a user is authenticated) 2) Run tests (they should fail): prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 3) Apply this patch. Repeat 2) They should pass. Test plan for UI: 1) Enable ILLModule and ILLHistoryCheck 2) Create a new ILL on OPAC, visit: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 3) Select type="journal", enter DOI = "123". Create. 4) Repeat steps 2 and 3. A history check screen should be displayed (it is not, before this patch). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39777 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38441 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.