[Bug 40783] New: The bookbag_form should not be submittable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Bug ID: 40783 Summary: The bookbag_form should not be submittable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jake.deery@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org The bookbag_form on the OPAC search results page should not submit by default. This causes accessibility problems, as it appears as though a page refresh occurs needlessly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 186311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186311&action=edit Bug 40783: Fix erroneous bookbag_form submission This patch addresses a bug where pressing return when focused on the bookbag_form checkbox results in a form submission. The bookbag_form is not designed to be submitted, so the behaviour has been disabled for accessibility reasons. TO TEST: a) go to /cgi-bin/koha/opac-search.pl?idx=kw&q=history&sort_by=relevance b) add an item to your cart (ensure the syspref is enabled) c) tab through the results until you come across a checkbox, press return d) notice your page refresh, a form submission has happened APPLY PATCH e) repeat steps a-c f) notice the page no longer refreshes, and that no form submission occurs g) notice the items are still in your cart and can be interacted with normally SIGN OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Assignee|oleonard@myacpl.org |jake.deery@openfifth.co.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 --- Comment #2 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 186789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186789&action=edit Bug 40783: Result page checkbox now triggers click This patch changes the behaviour off the checkboxes on the results page, so that instead of causing a form submission (essentially, a page refresh), the checkbox will now follow the same behaviour as if it were clicked. TO TEST: a) go to /cgi-bin/koha/opac-search.pl?idx=kw&q=history&sort_by=relevance b) add an item to your cart (ensure the syspref is enabled) c) tab through the results until you come across a checkbox, press return d) notice your page refreshes, as a form submission has happened APPLY PATCH e) repeat steps a-c f) notice the page no longer refreshes, and that no form submission occurs g) notice that the checkbox is now checked, as if it had been clicked h) notice the items are still in your cart and can be interacted with normally SIGN OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 --- Comment #3 from Jake Deery <jake.deery@openfifth.co.uk> --- Slightly rewritten this patch, as the old one broke the sort_by dropdown on the results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #4 from Philip Orr <philip.orr@lmscloud.de> --- Works for me, but qa fails tidiness: ´´´ Result: [FAIL] koha-tmpl/opac-tmpl/bootstrap/js/results-list.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/js/results-list.js` ``` Happy to sign off anyway. Also just to amend the patch notes: Step e) repeat steps a-c First you should clear your local cache and reload the page. Otherwise the old js may be still cached :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186789|0 |1 is obsolete| | --- Comment #5 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 187201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187201&action=edit Bug 40783: Result page checkbox now triggers click This patch changes the behaviour off the checkboxes on the results page, so that instead of causing a form submission (essentially, a page refresh), the checkbox will now follow the same behaviour as if it were clicked. TO TEST: a) go to /cgi-bin/koha/opac-search.pl?idx=kw&q=history&sort_by=relevance b) add an item to your cart (ensure the syspref is enabled) c) tab through the results until you come across a checkbox, press return d) notice your page refreshes, as a form submission has happened APPLY PATCH e) repeat steps a-c f) notice the page no longer refreshes, and that no form submission occurs g) notice that the checkbox is now checked, as if it had been clicked h) notice the items are still in your cart and can be interacted with normally SIGN OFF Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187457&action=edit [ALTERNATIVE PATCH] Bug 40783: Use existing noEnterSubmit class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Jake, please have a look at this patch, I think it's what you need here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40783 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org