[Bug 39189] New: Collapsing sections on moredetail.pl not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Bug ID: 39189 Summary: Collapsing sections on moredetail.pl not working Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 7508 I should have reworked Bug 7508 on top of Bug 38227, because 38227 moved the togglePanel function to staff-global.js. As it is now, there is a duplicate togglePanel function in moredetail.tt and the panels are not working correctly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7508 [Bug 7508] Collapsable items on items tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #0)
a duplicate togglePanel function in moredetail.tt
Sorry, a duplicate click handler. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178551&action=edit Bug 39189: Fix collapsing panels on moredetail.tt This patch removes a duplicate togglePanel function and a duplicate click handler from moredetail.tt. Bug 38227 made both global by adding them to staff-global.js. Also fixed: Converted a mistaken use of "__" to "_". To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search and view the details of a title with multiple items. - On the bibliographic detail page, click "Items" in the sidebar. - Click a "Barcode XXXX" heading to confirm that it collapses and expands that section correctly. - Collapse all sections and then test the barcode links in the sidebar. Clicking any of them should expand the correct panel and scroll to that section. - Test the other pages using the togglePanel function: Patron entry and the authority search from triggered from the MARC editor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |magnus@libriotech.no --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Sorry, doesn't quite work for me. Applied the patch yarn js:build restart_all Did a search, clicked through to the details of a record that has three items, and then on "Items" in the sidebar. I see the barcodes under "Items" in the sidebar. Clicking on them scrolls the page so the heading for the chosen item is displayed at the top of the screen. Clickin on the heading of that item does nothing. Scrolling to another heading and clicking on that brings the heading to the top of the screen, but it is never collapsed. There is nothing in the console. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Magnus Enger from comment #3)
Clickin on the heading of that item does nothing. Scrolling to another heading and clicking on that brings the heading to the top of the screen, but it is never collapsed. There is nothing in the console.
I would expect this behavior if the browser was still using cached JS, but I know you did a hard refresh on the page so I'm not sure what's going on. I tested it again in a few different browsers and it still works for me. Perhaps someone else could try, maybe they'll have better luck? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- When I tested this it worked as expected for the more details page. For this step: Test the other pages using the togglePanel function All the sections in Patron entry collapsed and expanded correctly except for: Additional attributes and identifiers Patron messaging preferences Clicking on those headings didn't do anything. Maybe that's a separate bug? For this step: the authority search from triggered from the MARC editor. I couldn't test this. What I thought is Authority search doesn't have any collapsible panels, but I can look again if you can add some info on how to do this part. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178551|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178865&action=edit Bug 39189: Fix collapsing panels on moredetail.tt This patch removes a duplicate togglePanel function and a duplicate click handler from moredetail.tt. Bug 38227 made both global by adding them to staff-global.js. Also fixed: Converted a mistaken use of "__" to "_". To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search and view the details of a title with multiple items. - On the bibliographic detail page, click "Items" in the sidebar. - Click a "Barcode XXXX" heading to confirm that it collapses and expands that section correctly. - Collapse all sections and then test the barcode links in the sidebar. Clicking any of them should expand the correct panel and scroll to that section. - Test the other pages using the togglePanel function: Patron entry and the authority search from triggered from the MARC editor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178866&action=edit Bug 39189: (follow-up) Add containers to the template markup Some sections of the patron entry form do not have a single container to be collapsed using the jQuery's next(). Since this patch converts it from nextAll() it's necessary to have a single container to match. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Brendan Lawlor from comment #5)
For this step: the authority search from triggered from the MARC editor.
I couldn't test this. What I thought is Authority search doesn't have any collapsible panels, but I can look again if you can add some info on how to do this part.
For an authority controlled tag like 100 click the "Tag editor" at the end of subfield a. In the popup, you can collapse the "Search options" panel that contains the form. Do a search that returns one or more results, at the top is a collapsed "Search options" panel that expands to show the search form. Do a search that returns no results, the panel will be expanded by default, but you can collapse it to concentrate on the "No results found" message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Everything else seems to work, but on the patron entry form collapsing "Patron account flags" collapses the paragraph of text, but leaves the Gone no address and Lost card radiobuttons uncollapsed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179157&action=edit Bug 39189: (follow-up) Add a missing container to patron entry form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- Works fine for the patron entry form now. I must have been too focused on the links expanding and collapsing individual items, I missed seeing that apparently all items are children of the item above them. Steps to reproduce: 1. Find a record with three items, like Empress of the blues 2. On the items tab, scroll down to the bottom item and collapse it 3. Now you have two expanded items, and one collapsed 4. Collapse the second item 5. Now you have one expanded item, and one collapsed item, rather than two 6. Collapse the first item 7. Now you have one collapsed item, rather than three -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179323&action=edit Bug 39189: (follow-up) Add missing container to moredetail.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178865|0 |1 is obsolete| | --- Comment #13 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179346&action=edit Bug 39189: Fix collapsing panels on moredetail.tt This patch removes a duplicate togglePanel function and a duplicate click handler from moredetail.tt. Bug 38227 made both global by adding them to staff-global.js. Also fixed: Converted a mistaken use of "__" to "_". To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search and view the details of a title with multiple items. - On the bibliographic detail page, click "Items" in the sidebar. - Click a "Barcode XXXX" heading to confirm that it collapses and expands that section correctly. - Collapse all sections and then test the barcode links in the sidebar. Clicking any of them should expand the correct panel and scroll to that section. - Test the other pages using the togglePanel function: Patron entry and the authority search from triggered from the MARC editor. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178866|0 |1 is obsolete| | --- Comment #14 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179347&action=edit Bug 39189: (follow-up) Add containers to the template markup Some sections of the patron entry form do not have a single container to be collapsed using the jQuery's next(). Since this patch converts it from nextAll() it's necessary to have a single container to match. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179157|0 |1 is obsolete| | --- Comment #15 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179348&action=edit Bug 39189: (follow-up) Add a missing container to patron entry form Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179323|0 |1 is obsolete| | --- Comment #16 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 179349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179349&action=edit Bug 39189: (follow-up) Add missing container to moredetail.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179346|0 |1 is obsolete| | --- Comment #17 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179352&action=edit Bug 39189: Fix collapsing panels on moredetail.tt This patch removes a duplicate togglePanel function and a duplicate click handler from moredetail.tt. Bug 38227 made both global by adding them to staff-global.js. Also fixed: Converted a mistaken use of "__" to "_". To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search and view the details of a title with multiple items. - On the bibliographic detail page, click "Items" in the sidebar. - Click a "Barcode XXXX" heading to confirm that it collapses and expands that section correctly. - Collapse all sections and then test the barcode links in the sidebar. Clicking any of them should expand the correct panel and scroll to that section. - Test the other pages using the togglePanel function: Patron entry and the authority search from triggered from the MARC editor. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179347|0 |1 is obsolete| | --- Comment #18 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179353&action=edit Bug 39189: (follow-up) Add containers to the template markup Some sections of the patron entry form do not have a single container to be collapsed using the jQuery's next(). Since this patch converts it from nextAll() it's necessary to have a single container to match. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179348|0 |1 is obsolete| | --- Comment #19 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179354&action=edit Bug 39189: (follow-up) Add a missing container to patron entry form Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179349|0 |1 is obsolete| | --- Comment #20 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 179355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179355&action=edit Bug 39189: (follow-up) Add missing container to moredetail.tt Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Especially happy to see accessibility improved too :) (Removing "Click to ...") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 7508 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39189 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40917 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40917 [Bug 40917] Required patron attributes show with extra whitespace in the textarea -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org