[Bug 28016] New: Replace obsolete title-string sorting: Assorted templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Bug ID: 28016 Summary: Replace obsolete title-string sorting: Assorted templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 27934 This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/modules/patron_lists/list.tt intranet-tmpl/prog/en/modules/cataloguing/additem.tt intranet-tmpl/prog/en/modules/reserve/request.tt intranet-tmpl/prog/en/modules/tags/review.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934 [Bug 27934] Table sorting using title-string option is obsolete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118619&action=edit Bug 28016: Replace obsolete title-string sorting: Assorted templates This patch modifies various templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Cataloging -> Edit items - Easiest to test with an title with many items. You can follow the "Edit items" link from search results. - Tools -> Patron lists - View the contents of a patron list - Catalog -> Place hold - Locate a title with multiple items and check out each item with a different due date. - Start the process of placing a hold on that title for a patron. - On the "Place hold" screen, check the table of "specific" items and test sorting of the "Information" column by date due. - Tools -> Tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118619|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118672&action=edit Bug 28016: Replace obsolete title-string sorting: Assorted templates To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Cataloging -> Edit items - Easiest to test with an title with many items. You can follow the "Edit items" link from search results. - Tools -> Patron lists - View the contents of a patron list - Catalog -> Place hold - Locate a title with multiple items and check out each item with a different due date. - Start the process of placing a hold on that title for a patron. - On the "Place hold" screen, check the table of "specific" items and test sorting of the "Information" column by date due. - Tools -> Tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118672|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118911&action=edit Bug 28016: Replace obsolete title-string sorting: Assorted templates This patch modifies various templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Cataloging -> Edit items - Easiest to test with an title with many items. You can follow the "Edit items" link from search results. - Tools -> Patron lists - View the contents of a patron list - Catalog -> Place hold - Locate a title with multiple items and check out each item with a different due date. - Start the process of placing a hold on that title for a patron. - On the "Place hold" screen, check the table of "specific" items and test sorting of the "Information" column by date due. - Tools -> Tags Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28016 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org