[Bug 28018] New: Replace obsolete title-string sorting: OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Bug ID: 28018 Summary: Replace obsolete title-string sorting: OPAC templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 27934 This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. opac-tmpl/bootstrap/en/includes/account-table.inc opac-tmpl/bootstrap/en/includes/columns_settings.inc opac-tmpl/bootstrap/en/includes/holds-table.inc opac-tmpl/bootstrap/en/modules/opac-account.tt opac-tmpl/bootstrap/en/modules/opac-course-details.tt opac-tmpl/bootstrap/en/modules/opac-detail.tt opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt opac-tmpl/bootstrap/en/modules/opac-illrequests.tt opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt opac-tmpl/bootstrap/en/modules/opac-search-history.tt opac-tmpl/bootstrap/en/modules/opac-tags.tt opac-tmpl/bootstrap/en/modules/opac-user.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934 [Bug 27934] Table sorting using title-string option is obsolete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118780&action=edit Bug 28018: Replace obsolete title-string sorting: OPAC templates This patch modifies OPAC templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - As a logged-in user, (proper testing will depend on having the relevant data associated with your user, e.g. holds, searches, ill requests, etc.): - Your summary - Checkouts - Overdues - Holds - Your charges - Your search history - Your checkout history - Your holds history - Your interlibrary loan requests - Your tags - Bibliographic detail page - With a non-serial record: Holdings - With a serial record: Latest issues - More details -> Full history: Test multiple years if possible - Course reserves -> Course details - Self checkout -> Check out to a patron with checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118780|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118887&action=edit Bug 28018: Replace obsolete title-string sorting: OPAC templates This patch modifies OPAC templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - As a logged-in user, (proper testing will depend on having the relevant data associated with your user, e.g. holds, searches, ill requests, etc.): - Your summary - Checkouts - Overdues - Holds - Your charges - Your search history - Your checkout history - Your holds history - Your interlibrary loan requests - Your tags - Bibliographic detail page - With a non-serial record: Holdings - With a serial record: Latest issues - More details -> Full history: Test multiple years if possible - Course reserves -> Course details - Self checkout -> Check out to a patron with checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118887|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118888&action=edit Bug 28018: Replace obsolete title-string sorting: OPAC templates This patch modifies OPAC templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - As a logged-in user, (proper testing will depend on having the relevant data associated with your user, e.g. holds, searches, ill requests, etc.): - Your summary - Checkouts - Overdues - Holds - Your charges - Your search history - Your checkout history - Your holds history - Your interlibrary loan requests - Your tags - Bibliographic detail page - With a non-serial record: Holdings - With a serial record: Latest issues - More details -> Full history: Test multiple years if possible - Course reserves -> Course details - Self checkout -> Check out to a patron with checkouts Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28018 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org