https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11927, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21416 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |a.roussos@dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 --- Comment #1 from Andreas Roussos <a.roussos@dataly.gr> --- Created attachment 102970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102970&action=edit Bug 25149: Fix Zebra language code for Greek According to the list of two-letter language codes found in ISO 639-1 (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes), the correct Zebra language option for Greek should be 'el', not 'gr'. This patch fixes that. Test plan: 0) Apply the patch. 1) Confirm that 'gr' has been changed to 'el' in all relevant files. 2) Create a new Koha instance using `koha-create --zebralang el testinst1`. 3) Edit /etc/koha/koha-sites.conf and set ZEBRA_LANGUAGE to 'el'. Then, create another Koha instance with `koha-create testinst2`. 4) Confirm that both instances created in steps 2) and 3) have picked up the Zebra CHR file from the /etc/koha/zebradb/lang_defs/el/ directory. This is done by inspecting the value of 'profilePath' in these files: /etc/koha/sites/testinst{1,2}/zebra-authorities-dom.cfg /etc/koha/sites/testinst{1,2}/zebra-biblios-dom.cfg -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102970|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 103515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103515&action=edit Bug 25149: Fix Zebra language code for Greek According to the list of two-letter language codes found in ISO 639-1 (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes), the correct Zebra language option for Greek should be 'el', not 'gr'. This patch fixes that. Test plan: 0) Apply the patch. 1) Confirm that 'gr' has been changed to 'el' in all relevant files. 2) Create a new Koha instance using `koha-create --zebralang el testinst1`. 3) Edit /etc/koha/koha-sites.conf and set ZEBRA_LANGUAGE to 'el'. Then, create another Koha instance with `koha-create testinst2`. 4) Confirm that both instances created in steps 2) and 3) have picked up the Zebra CHR file from the /etc/koha/zebradb/lang_defs/el/ directory. This is done by inspecting the value of 'profilePath' in these files: /etc/koha/sites/testinst{1,2}/zebra-authorities-dom.cfg /etc/koha/sites/testinst{1,2}/zebra-biblios-dom.cfg Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103515|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 103519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103519&action=edit Bug 25149: Fix Zebra language code for Greek According to the list of two-letter language codes found in ISO 639-1 (https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes), the correct Zebra language option for Greek should be 'el', not 'gr'. This patch fixes that. Test plan: 0) Apply the patch. 1) Confirm that 'gr' has been changed to 'el' in all relevant files. 2) Create a new Koha instance using `koha-create --zebralang el testinst1`. 3) Edit /etc/koha/koha-sites.conf and set ZEBRA_LANGUAGE to 'el'. Then, create another Koha instance with `koha-create testinst2`. 4) Confirm that both instances created in steps 2) and 3) have picked up the Zebra CHR file from the /etc/koha/zebradb/lang_defs/el/ directory. This is done by inspecting the value of 'profilePath' in these files: /etc/koha/sites/testinst{1,2}/zebra-authorities-dom.cfg /etc/koha/sites/testinst{1,2}/zebra-biblios-dom.cfg Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

I think this catches all cases for new installations, but I wonder about existing ones set up with 'gr'. I assume the 'gr' remains in the config files and that we can't intervene here as part of the update process? Could we put a warning in the release notes or even Koha/updatedatabase? I think so myself -- an existing installation set up with ZEBRA_LANGUAGE="gr" will retain its configuration file. I have added a note in the "Text to go in

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Please note that the release notes| |configuration file | |(/etc/koha/koha-sites.conf) | |of existing installations | |that have been set up using | |ZEBRA_LANGUAGE="gr" will | |not be affected by this | |change. --- Comment #5 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to Katrin Fischer from comment #4) the release notes:" section of this Bug report, let me know what you think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.