[Bug 25340] New: opac-review.pl doesn't show title when commenting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Bug ID: 25340 Summary: opac-review.pl doesn't show title when commenting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org When placing a comment/review on a record on the OPAC, Koha says "Comments on No title" even when there is a title. The template looks like this: <h1>Comments on <i>[% INCLUDE 'biblio-title.inc' biblio=Stash.stash() %]</i></h1> Surely that should have a more appropriate data structure put into biblio. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104086&action=edit Bug 25340: Pass biblio object to OPAC comments template This patch modifies the OPAC comments system so that the biblio object is passed to the template. This allows the biblio-title include to properly access the title and subtitle information. Unrelated change: Remove some custom CSS from the page which was obsolete. To test, apply the patch and make sure the "reviewson" preference is enabled. - Log in to the OPAC and open a bibliographic record's detail page. - Under the "Comments" tab, click the "Post your comments" link to trigger the pop-up window. - In the pop-up window, verify that the item's title is correct in the page title and the heading. Author should display correctly, if present. - Test submitting a comment and editing a comment. Everything should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104086|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 104113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104113&action=edit Bug 25340: Pass biblio object to OPAC comments template This patch modifies the OPAC comments system so that the biblio object is passed to the template. This allows the biblio-title include to properly access the title and subtitle information. Unrelated change: Remove some custom CSS from the page which was obsolete. To test, apply the patch and make sure the "reviewson" preference is enabled. - Log in to the OPAC and open a bibliographic record's detail page. - Under the "Comments" tab, click the "Post your comments" link to trigger the pop-up window. - In the pop-up window, verify that the item's title is correct in the page title and the heading. Author should display correctly, if present. - Test submitting a comment and editing a comment. Everything should work correctly. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104113|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104116&action=edit Bug 25340: Pass biblio object to OPAC comments template This patch modifies the OPAC comments system so that the biblio object is passed to the template. This allows the biblio-title include to properly access the title and subtitle information. Unrelated change: Remove some custom CSS from the page which was obsolete. To test, apply the patch and make sure the "reviewson" preference is enabled. - Log in to the OPAC and open a bibliographic record's detail page. - Under the "Comments" tab, click the "Post your comments" link to trigger the pop-up window. - In the pop-up window, verify that the item's title is correct in the page title and the heading. Author should display correctly, if present. - Test submitting a comment and editing a comment. Everything should work correctly. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Thanks, Owen :). I was flat out last week and didn't have time to do this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25340 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- When I rebase this for 19.05.x I am running into problems. Perhaps I'm not rebasing it correctly. If this is needed in 19.05.x please rebase since I cannot. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org