[Bug 10897] New: t/ILSDI_Services.t is db dependent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Bug ID: 10897 Summary: t/ILSDI_Services.t is db dependent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: chris@bigballofwax.co.nz QA Contact: testopia@bugs.koha-community.org Mocking the dbh context to fix it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21130&action=edit Bug 10897 Removing DB dependence of t/ILSDI_Services.t To test 1/ Run the test with a config that doesnt allow db access you should get a message like t/ILSDI_Services.t .................. DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Access denied for user 'kohaadmin'@'localhost' (using password: YES) at /home/travis/build/ranginui/koha/blib/PERL_MODULE_DIR/C4/Context.pm line 810. 2/ Apply patch and run again 3/ Test should now run cleanly (cherry picked from commit c525dd384eba818076929cd20f10003c3b804111) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21130|0 |1 is obsolete| | --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 21133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21133&action=edit Bug 10897 Removing DB dependence of t/ILSDI_Services.t To test 1/ Run the test with a config that doesnt allow db access you should get a message like t/ILSDI_Services.t .................. DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Access denied for user 'kohaadmin'@'localhost' (using password: YES) at /home/travis/build/ranginui/koha/blib/PERL_MODULE_DIR/C4/Context.pm line 810. 2/ Apply patch and run again 3/ Test should now run cleanly (cherry picked from commit c525dd384eba818076929cd20f10003c3b804111) Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 Status|Needs Signoff |Signed Off CC| |robin@catalyst.net.nz Patch complexity|--- |Trivial patch Severity|enhancement |major --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- Going to push this into passed QA as it's a requirement for packages to build, and I've verified that it works on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- For reference, a quick way to get a "config that doesnt allow db access" even if one's development environment is normally hooked up to a database is to do something like this: KOHA_CONF= prove -v ILSDI_Services.t I'll adjust the settings on Jenkins to (also) do exactly this for the non-DB-dependent tests to catch this situation in the future. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Galen Charlton from comment #4)
For reference, a quick way to get a "config that doesnt allow db access" even if one's development environment is normally hooked up to a database is to do something like this:
KOHA_CONF= prove -v ILSDI_Services.t
I'll adjust the settings on Jenkins to (also) do exactly this for the non-DB-dependent tests to catch this situation in the future.
OK, in retrospect that's more extreme than just a config that lacks DB access. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- I've pushed a different patch that simply removes t/ILSDI_Services.t; t/db_dependent/ILSDI_Services.t includes the module compilation test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org