http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20884&action=edit Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron This patch adds unit tests for Authenticate patron. To test: - Run perl t/db_dependent/ILSDI_Services.t - Verify all tests pass Note: there are some tests marked as TODO. Rewriting AuthenticatePatron to make cardnumber and userid work for authenticating a patron will be implemented in the next patch. Tests related to this are currently showing as 'not ok', but are still passing. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20884|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20888&action=edit [SIGNED-OFF] Bug 10667: Add unit tests for ILSDI::Services::AuthenticatePatron This patch adds unit tests for Authenticate patron. To test: - Run perl t/db_dependent/ILSDI_Services.t - Verify all tests pass Note: there are some tests marked as TODO. Rewriting AuthenticatePatron to make cardnumber and userid work for authenticating a patron will be implemented in the next patch. Tests related to this are currently showing as 'not ok', but are still passing. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors With both patches applied, all test pass. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20998|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21007&action=edit [SIGNED-OFF] Bug 10667: Follow up - prevent t/00-load from failing To test: - Apply first 2 patches for unit tests and changes to Services.pm - Turn off mysql - Run t/00-load.t - Verify that the test fails. - Apply this third patch. - Run t/00-load.t again. - Verify this time it passes. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work well, no koha-qa errors. Without third patch and mysql down, test fails, with third patch it succeed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20889|0 |1 is obsolete| | --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Created attachment 21065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21065&action=edit Bug 10667: Allow authentication with cardnumber for ILS-DI Test authentication via ILS-DI: - with userid and password - with userid and wrong password - with cardnumber and password - with cardnumber and wrong password ... Before the patch only userid will authenticate the patron. After the patch was applied, userid and cardnumber will work. To test: - Run t/db_dependent/ILSDI_Services.t - all tests should pass. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors Test: Enable ISL-DI access opac with /cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=XXX&password=YYY With userid/cardnumber & password returns borrowernumber With userid/cardnumber & wrong password returns PatronNotFound Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- patches pass all ./t/tests and qa-tool passing QA on 3 patches -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.