[Bug 38767] New: Statuses in the holdings table should be divs not spans
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Bug ID: 38767 Summary: Statuses in the holdings table should be divs not spans Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the holdings table there is a the status column, there can sometimes be multiple statuses per item. When there is the are displayed in <span>, being inline makes each status run together. They need to be block level <div> to be more readable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38512 [Bug 38512] Item table status column display is wrong when record has recalls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 175850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175850&action=edit Bug 38767: Convert each status element in holdings table from span to div 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. Apply patch 4. Statuses are seperated by a break. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Many of those won't reproduce the problem because staff-global.css sets them to display: block; already. Some can't exist with some others (you can't have available and lost since available comes from !lost). Some sort of expect to be combined (e.g. waitingat and heldfor). Could you fix the actual problem ones by just adding their class to the classes that are set to display: block? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #3 from Phil Ringnalda <phil@chetcolibrary.org> --- Oh, didn't notice the dependency saying the problem was the recall message that you made stop trying (and failing) to work as a run-on sentence with its initial lowercase letter. So make that "can't you just add a classname to the recall span, always a useful thing, and then add that to the list of block statuses in https://git.koha-community.org/Koha-community/Koha/src/commit/1a4820322e528f... so it won't try to attach itself to other things?" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Statuses in the holdings |Statuses in the holdings |table should be divs not |table should have block |spans |display, not inline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
Could you fix the actual problem ones by just adding their class to the classes that are set to display: block?
Sounds good to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175850|0 |1 is obsolete| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176022&action=edit Bug 38767: Add block display for statuses in holdings table 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 4. Statuses are seperated by a break. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I had a go at testing, but I was unable to replicate the issue. 1. I set up recalls: - Enable recalls: UseRecalls - Update circulation rules: I used 5 for all of the recall options 2. For a record, changed status to 4- Damaged status: Damaged 3. Checked out an item for the record to a patron 4. Placed a recall on the record (used the koha user in the OPAC to place the recall 5. Checked the item in and confirmed the recall 6. Status column in the holdings table shows as: Damaged Waiting recall at Centerville since 01/02/2025 7. This seems OK to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Whether or not the display problem is reproducible, I think we can improve how the statuses and CSS are handled in order to make simpler and more flexible. My go-to pattern for this kind of thing is two have one common class and one specific class. This is what we do in the bibliographic details on that same page: <span class="results_summary isbn">...</span> The "results_summary" class can be used to change the display of all elements in that "category" (in this case it could be 'display:block'). The specific class can be used (if necessary) to differentiate that element from the others in that category. Doing it this way means we don't have to keep adding classes to the CSS as item statuses are created. I would suggest something like: <span class="holding_status recallwaiting">%s</span> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176022|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 176298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176298&action=edit Bug 38767: Add block display for statuses in holdings table 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 4. Statuses are seperated by a break. Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #7)
Whether or not the display problem is reproducible, I think we can improve how the statuses and CSS are handled in order to make simpler and more flexible. My go-to pattern for this kind of thing is two have one common class and one specific class. This is what we do in the bibliographic details on that same page:
<span class="results_summary isbn">...</span>
The "results_summary" class can be used to change the display of all elements in that "category" (in this case it could be 'display:block'). The specific class can be used (if necessary) to differentiate that element from the others in that category.
Doing it this way means we don't have to keep adding classes to the CSS as item statuses are created.
I would suggest something like:
<span class="holding_status recallwaiting">%s</span>
Failing this based on Owen's comment. I'll come back to it ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 176461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176461&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 4. Statuses are seperated by a break. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176298|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- For a step 1 that lets you see step 2 without the patch, try: * place an item-specific hold on an item at another branch * check the item in at that branch, giving you intransit+holdonitem * check the item in at the destination, giving you waitingat+heldfor The affected statuses are intransit, holdonitem, transitrequested, waitingat, heldfor, bundled, recallwaiting, recalledby, but most of them are either impossible or more difficult to combine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
The affected statuses are intransit, holdonitem, transitrequested, waitingat, heldfor, bundled, recallwaiting, recalledby, but most of them are either impossible or more difficult to combine.
Thanks Phil, that is a good point to make. You can also check for the existence of the new class and make sure the element is displaying `block`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176461|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 177133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177133&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 4. Statuses are seperated by a break. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the status release notes| |column in the holdings | |table for a record with | |multiple statuses - each | |status is now shown on its | |own line, instead of | |running together. (The CSS | |was updated so that there | |is a holding_status class | |(which is styled as a | |block) and then the | |individual status class, | |for example: <span | |class="holding_status | |waitingat">Waiting at X | |since Y.</span>.) --- Comment #14 from David Nind <david@davidnind.com> --- Thanks Phil for the steps to replicate multiple statuses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177133|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177759&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 4. Statuses are seperated by a break. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177759|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178090&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 4. Statuses are seperated by a break. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to main |Needs documenting --- Comment #18 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hard to backport, looks like an enhancement, won't backport unless asked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #19 from David Nind <david@davidnind.com> --- Bug fix, no change required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org