[Bug 38944] New: Add Test::NoWarnings to tests without warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Bug ID: 38944 Summary: Add Test::NoWarnings to tests without warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 25515 To prevent new warnings for test files that do not generate warnings we should use Test::NoWarnings. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176912&action=edit Bug 38944: Add new dependency Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176913&action=edit Bug 38944: Add Test::NoWarnings to tests no producing warnings This has been generated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176914&action=edit Bug 38944: Manual changes Not caught by the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- The idea here is to add Test::NoWarnings to all the tests that currently do not produce warnings. So we have a good starting point to move toward no warnings in our tests. The next step will be to clean the other tests that provide warnings. Test plan: The test suite should still pass after those patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25515 Depends on|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- I tried testing, but I think Test::NoWarnings module needs to be added to ktd to be able to be able to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes you can install it using `cpanm Test::NoWarnings` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from David Nind <david@davidnind.com> --- The patch no longer applies cleanly: .... Auto-merging t/db_dependent/UsageStats.t CONFLICT (content): Merge conflict in t/db_dependent/UsageStats.t Auto-merging t/db_dependent/Koha/Biblio.t error: Failed to merge in the changes. Patch failed at 0001 Bug 38944: Add Test::NoWarnings to tests no producing warnings ...... Testing notes (using KTD): 1. Start up KTD with selenium: ktd --selenium up 2. Install the new dependency: cpanm Test::NoWarnings 3. Apply the patches. 4. Run all the tests: . ktd --shell --root . cd /kohadevbox/koha . perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176912|0 |1 is obsolete| | Attachment #176913|0 |1 is obsolete| | Attachment #176914|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177165&action=edit Bug 38944: Add new dependency Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177166&action=edit Bug 38944: Add Test::NoWarnings to tests no producing warnings This has been generated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177167&action=edit Bug 38944: Manual changes Not caught by the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 177196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177196&action=edit Test summary report - 2025-01-28 I've attached the tests summary showing the failures from running all the tests. Testing notes (updated) (using KTD): 1. Start up KTD with selenium: ktd --selenium up 2. Install the new dependency: sudo cpanm Test::NoWarnings 3. Apply the patches. 4. Run all the tests: . ktd --shell --root . cd /kohadevbox/koha . perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177167|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177274&action=edit Bug 38944: Manual changes Not caught by the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177275&action=edit Bug 38944: Correctly catch warnings raised by DBI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #14 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- This is pretty awesome. I've always done this. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from David Nind <david@davidnind.com> --- Thanks Jonatahn! I was too slow re-testing, and the patches no longer apply ... git bz apply 38944 Bug 38944 - Add Test::NoWarnings to tests without warnings 177165 - Bug 38944: Add new dependency Test::NoWarnings 177166 - Bug 38944: Add Test::NoWarnings to tests no producing warnings 177274 - Bug 38944: Manual changes 177275 - Bug 38944: Correctly catch warnings raised by DBI Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38944: Add new dependency Test::NoWarnings Applying: Bug 38944: Add Test::NoWarnings to tests no producing warnings Using index info to reconstruct a base tree... M t/Languages.t M t/db_dependent/Koha/CirculationRules.t M t/db_dependent/Koha/Holds.t M t/db_dependent/Koha/Object/Mixin/AdditionalFields.t M t/db_dependent/Languages.t M t/db_dependent/api/v1/items.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/api/v1/items.t Auto-merging t/db_dependent/Languages.t Auto-merging t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Auto-merging t/db_dependent/Koha/Holds.t Auto-merging t/db_dependent/Koha/CirculationRules.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/CirculationRules.t Auto-merging t/Languages.t CONFLICT (content): Merge conflict in t/Languages.t error: Failed to merge in the changes. Patch failed at 0001 Bug 38944: Add Test::NoWarnings to tests no producing warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177166|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177362&action=edit Bug 38944: Add Test::NoWarnings to tests no producing warnings This has been generated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177274|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177363&action=edit Bug 38944: Manual changes Not caught by the script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177275|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177364&action=edit Bug 38944: Correctly catch warnings raised by DBI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #19 from David Nind <david@davidnind.com> --- Thanks Jonathan! Still a few test failures: Test Summary Report ------------------- t/db_dependent/selenium/01-installation.t (Wstat: 65280 (exited 255) Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 2. t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t (Wstat: 2816 (exited 11) Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 11 Parse errors: Bad plan. You planned 5 tests but ran 3. t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t (Wstat: 5632 (exited 22) Tests: 4 Failed: 0) Non-zero exit status: 22 Parse errors: Bad plan. You planned 14 tests but ran 4. t/db_dependent/api/v1/erm_sushi_services.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 xt/find-misplaced-executables.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 t/00-testcritic.t (Wstat: 0 Tests: 3245 Failed: 1) Failed test: 3245 Parse errors: Plan (1..3244) must be at the beginning or end of the TAP output Bad plan. You planned 3244 tests but ran 3245. xt/verify-yarnlock.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 xt/find-license-problems.t (Wstat: 256 (exited 1) Tests: 1378 Failed: 1) Failed test: 814 Non-zero exit status: 1 Files=733, Tests=18916, 2790.29 wallclock secs ( 5.20 usr 1.93 sys + 2999.38 cusr 571.04 csys = 3577.55 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177380&action=edit Bug 38944: Revert changes to selenium/01-installation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Nind from comment #19)
Thanks Jonathan!
Still a few test failures:
Test Summary Report ------------------- t/db_dependent/selenium/01-installation.t (Wstat: 65280 (exited 255) Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 2.
Should be fixed by the last patch.
t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t (Wstat: 2816 (exited 11) Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 11 Parse errors: Bad plan. You planned 5 tests but ran 3. t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t (Wstat: 5632 (exited 22) Tests: 4 Failed: 0) Non-zero exit status: 22 Parse errors: Bad plan. You planned 14 tests but ran 4.
They are passing for me. Do they pass on main?
t/db_dependent/api/v1/erm_sushi_services.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1
This is currently failing on main.
xt/find-misplaced-executables.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 t/00-testcritic.t (Wstat: 0 Tests: 3245 Failed: 1) Failed test: 3245 Parse errors: Plan (1..3244) must be at the beginning or end of the TAP output Bad plan. You planned 3244 tests but ran 3245. xt/verify-yarnlock.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 xt/find-license-problems.t (Wstat: 256 (exited 1) Tests: 1378 Failed: 1) Failed test: 814 Non-zero exit status: 1 Files=733, Tests=18916, 2790.29 wallclock secs ( 5.20 usr 1.93 sys + 2999.38 cusr 571.04 csys = 3577.55 CPU) Result: FAIL
What's the output of those ones? This patchset does not modify them so I guess they also fail on main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #22 from David Nind <david@davidnind.com> --- Hi Jonathan. These are the only tests that are failing now if I run all the tests at once. Some of the previous errors were because I had a folder with kidclamp's handy Koha scripts. Test Summary Report ------------------- t/db_dependent/Koha/SearchEngine/Elasticsearch/Indexer.t (Wstat: 2816 (exited 11) Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 11 Parse errors: Bad plan. You planned 5 tests but ran 3. t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t (Wstat: 65280 (exited 255) Tests: 4 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 14 tests but ran 4. xt/verify-yarnlock.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 t/00-testcritic.t (Wstat: 0 Tests: 3245 Failed: 1) Failed test: 3245 Parse errors: Plan (1..3244) must be at the beginning or end of the TAP output Bad plan. You planned 3244 tests but ran 3245. Files=733, Tests=18914, 2958.36 wallclock secs ( 5.49 usr 1.96 sys + 3076.34 cusr 577.41 csys = 3661.20 CPU) Result: FAIL 1. Elasticsearch tests ====================== Both the tests fail for me when I run all the tests after applying the patches, etc. However, after the patches are applied, if I shutdown and restart KTD (and then add the module), the tests pass when I run them individually. 2. xt/verify-yarnlock.t ======================= Fails for me before and after the patches. Lots of warnings and errors. If I do a yarn install and yarn build, then run the test individually, it passes. ..... warning "arraybuffer.prototype.slice#function.prototype.name#call-bind#get-intrinsic##has-symbols@^1.0.1" could be deduped from "1.0.3" to "has-symbols@1.0.3" warning "string.prototype.trim#function.prototype.name#call-bind#get-intrinsic##function-bind@^1.1.1" could be deduped from "1.1.1" to "function-bind@1.1.1" warning "string.prototype.trim#function.prototype.name#call-bind#get-intrinsic##has@^1.0.3" could be deduped from "1.0.3" to "has@1.0.3" warning "string.prototype.trim#function.prototype.name#call-bind#get-intrinsic##has-symbols@^1.0.1" could be deduped from "1.0.3" to "has-symbols@1.0.3" error Found 54 errors. xt/verify-yarnlock.t .. 1/1 # Failed test 'verify yarn.lock file is updated correctly' # at xt/verify-yarnlock.t line 45. # got: '256' # expected: '0' # Looks like you failed 1 test of 1. xt/verify-yarnlock.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- xt/verify-yarnlock.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 3 wallclock secs ( 0.04 usr 0.02 sys + 2.94 cusr 1.13 csys = 4.13 CPU) Result: FAIL 3. t/00-testcritic.t ==================== Fails for me before and after the patches. prove t/00-testcritic.t t/00-testcritic.t .. All 3244 subtests passed Test Summary Report ------------------- t/00-testcritic.t (Wstat: 0 Tests: 3245 Failed: 1) Failed test: 3245 Parse errors: Plan (1..3244) must be at the beginning or end of the TAP output Bad plan. You planned 3244 tests but ran 3245. Files=1, Tests=3245, 30 wallclock secs ( 0.71 usr 0.04 sys + 224.51 cusr 1.36 csys = 226.62 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177165|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 177477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177477&action=edit Bug 38944: Add new dependency Test::NoWarnings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177362|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 177478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177478&action=edit Bug 38944: Add Test::NoWarnings to tests no producing warnings This has been generated. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177363|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 177479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177479&action=edit Bug 38944: Manual changes Not caught by the script Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177364|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 177480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177480&action=edit Bug 38944: Correctly catch warnings raised by DBI Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177380|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 177481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177481&action=edit Bug 38944: Revert changes to selenium/01-installation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #28 from David Nind <david@davidnind.com> --- Now signed off - see comments on chat https://chat.koha-community.org/koha-community/pl/ck6muapewi8p5e87ehsefyii5c "..it seems that you can signoff, you don't have more errors after the patches. The failures you get on main can be caused by several reasons (git repo not clean, node_modules not clean, ktd started withou a --es flag). Hard to tell but they do not seem related to this patch" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |Test::NoWarnings module to | |all the tests that | |currently do not produce | |warnings. This will then be | |a good starting point to | |move toward no warnings in | |our tests, with the next | |step to clean the other | |tests that currently do | |provide warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177477|0 |1 is obsolete| | Attachment #177478|0 |1 is obsolete| | Attachment #177479|0 |1 is obsolete| | Attachment #177480|0 |1 is obsolete| | Attachment #177481|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177928&action=edit Bug 38944: Add new dependency Test::NoWarnings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177929&action=edit Bug 38944: Add Test::NoWarnings to tests no producing warnings This has been generated. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #31 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177930&action=edit Bug 38944: Manual changes Not caught by the script Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177931&action=edit Bug 38944: Correctly catch warnings raised by DBI Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177932&action=edit Bug 38944: Revert changes to selenium/01-installation.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #34 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 177977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177977&action=edit Buug 38944: Revert changes to t/00-testcritic.t Not sure what's happening here. Skipping it for now. t/00-testcritic.t .. 3246/? # Failed test 'done_testing() was already called at /usr/share/perl5/Test/Perl/Critic.pm line 105' # at t/00-testcritic.t line 22. t/00-testcritic.t .. All 3249 subtests passed Test Summary Report ------------------- t/00-testcritic.t (Wstat: 0 Tests: 3251 Failed: 2) Failed tests: 3250-3251 Parse errors: Plan (1..3249) must be at the beginning or end of the TAP output Bad plan. You planned 3249 tests but ran 3251. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177928|0 |1 is obsolete| | Attachment #177929|0 |1 is obsolete| | Attachment #177930|0 |1 is obsolete| | Attachment #177931|0 |1 is obsolete| | Attachment #177932|0 |1 is obsolete| | Attachment #177977|0 |1 is obsolete| | --- Comment #35 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177994&action=edit Bug 38944: Add new dependency Test::NoWarnings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #36 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177995&action=edit Bug 38944: Add Test::NoWarnings to tests no producing warnings This has been generated. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #37 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177996&action=edit Bug 38944: Manual changes Not caught by the script Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #38 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177997&action=edit Bug 38944: Correctly catch warnings raised by DBI Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #39 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177998&action=edit Bug 38944: Revert changes to selenium/01-installation.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #40 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177999&action=edit Bug 38944: Revert changes to t/00-testcritic.t Not sure what's happening here. Skipping it for now. t/00-testcritic.t .. 3246/? # Failed test 'done_testing() was already called at /usr/share/perl5/Test/Perl/Critic.pm line 105' # at t/00-testcritic.t line 22. t/00-testcritic.t .. All 3249 subtests passed Test Summary Report ------------------- t/00-testcritic.t (Wstat: 0 Tests: 3251 Failed: 2) Failed tests: 3250-3251 Parse errors: Plan (1..3249) must be at the beginning or end of the TAP output Bad plan. You planned 3249 tests but ran 3251. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- @mtj: Can you look into the dependency please? +recommends 'Test::NoWarnings', '1.06'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #42 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #41)
@mtj: Can you look into the dependency please?
+recommends 'Test::NoWarnings', '1.06';
hie, this looks ok we can add libtest-nowarnings-perl_1.06-2_all.deb to the koha repo, for older debian versions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Mason, how do we coordinate here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- We should push this, really... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #44)
We should push this, really...
I'll reach out to Mason for adding the dependency to the repo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #46 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #45)
(In reply to Jonathan Druart from comment #44)
We should push this, really...
I'll reach out to Mason for adding the dependency to the repo.
i've pushed the libtest-nowarnings-perl_1.06-2_all package to both koha and koha-staging repos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #47 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #46)
(In reply to Katrin Fischer from comment #45)
(In reply to Jonathan Druart from comment #44)
We should push this, really...
I'll reach out to Mason for adding the dependency to the repo.
i've pushed the libtest-nowarnings-perl_1.06-2_all package to both koha and koha-staging repos
$ docker run -it debian:buster ... root@22861f5b59a7:/# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 10 (buster) Release: 10 Codename: buster root@22861f5b59a7:/# apt policy libtest-nowarnings-perl libtest-nowarnings-perl: Installed: 1.06-2 Candidate: 1.06-2 Version table: *** 1.06-2 500 500 https://debian.koha-community.org/koha stable/main amd64 Packages 100 /var/lib/dpkg/status 1.04-2 500 500 http://deb.debian.org/debian buster/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #48 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #43)
Thanks Mason, how do we coordinate here?
sorry about missing this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Mason James from comment #48)
(In reply to Katrin Fischer from comment #43)
Thanks Mason, how do we coordinate here?
sorry about missing this one!
@Joubu: Ready to push, but can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177994|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179241&action=edit Bug 38944: Add new dependency Test::NoWarnings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177995|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179242&action=edit Bug 38944: Add Test::NoWarnings to tests no producing warnings This has been generated. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177996|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179243&action=edit Bug 38944: Manual changes Not caught by the script Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177997|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179244&action=edit Bug 38944: Correctly catch warnings raised by DBI Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177998|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179245&action=edit Bug 38944: Revert changes to selenium/01-installation.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177999|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179246&action=edit Bug 38944: Revert changes to t/00-testcritic.t Not sure what's happening here. Skipping it for now. t/00-testcritic.t .. 3246/? # Failed test 'done_testing() was already called at /usr/share/perl5/Test/Perl/Critic.pm line 105' # at t/00-testcritic.t line 22. t/00-testcritic.t .. All 3249 subtests passed Test Summary Report ------------------- t/00-testcritic.t (Wstat: 0 Tests: 3251 Failed: 2) Failed tests: 3250-3251 Parse errors: Plan (1..3249) must be at the beginning or end of the TAP output Bad plan. You planned 3249 tests but ran 3251. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #56 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179247&action=edit Bug 38944: Remove warning from Patron/Borrower_Debarments. # Use of uninitialized value $anonymous_patron in string eq at /kohadevbox/koha/Koha/Patron.pm line 737. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #57 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Mason James from comment #48)
(In reply to Katrin Fischer from comment #43)
Thanks Mason, how do we coordinate here?
sorry about missing this one!
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179378&action=edit Bug 38944: Fix tidiness t/db_dependent/check_kohastructure.t This is an odd one, why this change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Passed QA Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #61 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179478&action=edit Bug 38944: Tidy t/db_dependent/Record/Record.t The generated patch was big and I skipped the git hook :-/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #61)
Created attachment 179478 [details] [review] Bug 38944: Tidy t/db_dependent/Record/Record.t
The generated patch was big and I skipped the git hook :-/
Picked up for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #63 from David Cook <dcook@prosentient.com.au> --- I'm not seeing this in koha-testing-docker, but I'm guessing I must need to do a new pull... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #64 from David Nind <david@davidnind.com> --- (In reply to David Cook from comment #63)
I'm not seeing this in koha-testing-docker, but I'm guessing I must need to do a new pull...
I think you will. I'm seeing it installed for me (I recently removed all the docker images and volumes and did a fresh ktd pull). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #65 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #64)
(In reply to David Cook from comment #63)
I'm not seeing this in koha-testing-docker, but I'm guessing I must need to do a new pull...
I think you will. I'm seeing it installed for me (I recently removed all the docker images and volumes and did a fresh ktd pull).
Thanks for confirming, David :). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181977&action=edit Bug 38944: Fix for Mysql8 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|dependency |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed latest follow-up "Fix for Mysql8" to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39869 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40472 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40472 [Bug 40472] Need to remove libtest-perltidy-perl from debian/control file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #68 from Fridolin Somers <fridolin.somers@biblibre.com> --- First patch has been backported to 24.11.x in Bug 39857 : https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39857#c10 Other patches not backported to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #69 from David Nind <david@davidnind.com> --- Relates to the test suite, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org