[Bug 33624] New: Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Bug ID: 33624 Summary: Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: philip.orr@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl First seen in Bug #32914. If you enter Koha's Batch record modification tool, select Authority records, select a template and then hit continue without actually uploading a file or entering record numbers, the error message "No records were modified." will be displayed. All correct so far. If you then don't click on "New batch record modification" and instead use the back button in Firefox to go back one page, you will land in batch record modification with the option "Authority records" selected but with the tab "Select a list of records" (meant for lists of Biblios) now again displayed and usable. Since biblio records and authorities records could have similar biblionumbers, this could lead to a situation where you're accidentally modifying the wrong records. To recreate: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected, but you should now see the tab "Select a list of records". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am not sure I understand. "Select a list of records" exists for both biblios and authorities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #2 from Philip Orr <philip.orr@lmscloud.de> --- Oops, sorry - forgot to mention that you need to have applied the patch for bug 32914 first. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 New steps to recreate: - Apply the patch for bug 32914 - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected, but you should now see the tab "Select a list of records". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on| |32914 Status|NEW |ASSIGNED --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Philip Orr from comment #2)
Oops, sorry - forgot to mention that you need to have applied the patch for bug 32914 first. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914
New steps to recreate: - Apply the patch for bug 32914 - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected, but you should now see the tab "Select a list of records".
Ho right, the list tab, I meant "Enter a list of record numbers" in my previous comment. I didn't notice the list one as I didn't have one created. I do recreate the problem on master. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 [Bug 32914] Use template wrapper for batch record deletion and modification templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151072&action=edit Bug 33624: Hide the "list" tab if authority is selected The "Select a list of records" should only be available for biblio records. But if the page is accessed using the back button of the browser it will be displayed for authorities as well. Test plan: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected => Without this patch you see the tab "Select a list of records" => With this patch applied it's hidden when the page is loaded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Bug is in master, without bug 32914. But it's PQA so I built the fix on top of it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151072|0 |1 is obsolete| | --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 151327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151327&action=edit Bug 33624: Hide the "list" tab if authority is selected The "Select a list of records" should only be available for biblio records. But if the page is accessed using the back button of the browser it will be displayed for authorities as well. Test plan: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected => Without this patch you see the tab "Select a list of records" => With this patch applied it's hidden when the page is loaded Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I dont understand what this patch actually is supposed to solve. If the list is not displayed but still contains the numbers entered, why hide it ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151327|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151335&action=edit Bug 33624: Hide the "list" tab if authority is selected The "Select a list of records" should only be available for biblio records. But if the page is accessed using the back button of the browser it will be displayed for authorities as well. Test plan: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected => Without this patch you see the tab "Select a list of records" => With this patch applied it's hidden when the page is loaded Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.07 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org