[Bug 33541] New: Show 'Document type' in list of suggestions when creating an order from a suggestion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Bug ID: 33541 Summary: Show 'Document type' in list of suggestions when creating an order from a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33326 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149730&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149730|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149731&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle@rcplib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That was fast! Thank you, Juliet! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Juliet. If you could edit status to change it to 'Signed off', that would be great! This will give you credit for the sign off in the dashboard - it will then show under Signoffs - April (https://dashboard.koha-community.org/). David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This table can be configured, you need to update admin/columns_settings.yml Also you don't need the third parameter (opac=0), it's the default value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149731|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150554&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle@rcplib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Removed IS_OPAC param from AuthorisedValues.GetByCode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #5)
This table can be configured, you need to update admin/columns_settings.yml
I think you are confusing the tables. suggestions is, but newordersuggestion is not configurable. This is the table with accepted suggestions shown when using "ordering from suggestion". It has no table configuration icons and I didn't find it in the config.
Also you don't need the third parameter (opac=0), it's the default value.
Fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150554|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150562&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle@rcplib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Removed IS_OPAC param from AuthorisedValues.GetByCode Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #7)
(In reply to Jonathan Druart from comment #5)
This table can be configured, you need to update admin/columns_settings.yml
I think you are confusing the tables. suggestions is, but newordersuggestion is not configurable. This is the table with accepted suggestions shown when using "ordering from suggestion". It has no table configuration icons and I didn't find it in the config.
Indeed, I was looking at the wrong table! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The 'Document type' of a release notes| |suggestion will now be | |visible in the list of | |accepted suggestions when | |creating a new order line. | |This is to help with | |ordering the right material | |type and also for picking | |the correct item type. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org