[Bug 12803] New: Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Bug ID: 12803 Summary: Add ability to skip closed libraries when generating the holds queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31057&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31060&action=edit Bug 12803 - Enable feature when using Transport Cost Matrix Test plan: repeat test plan for first patch, but use transport cost matrix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31060|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31061&action=edit Bug 12803 - Enable feature when using Transport Cost Matrix Test plan: repeat test plan for first patch, but use transport cost matrix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31061|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31062&action=edit Bug 12803 - Enable feature when using Transport Cost Matrix Test plan: repeat test plan for first patch, but use transport cost matrix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31062|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31063&action=edit Bug 12803 - Enable feature when using Transport Cost Matrix Test plan: repeat test plan for first patch, but use transport cost matrix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org --- Comment #6 from Jason Robb <jrobb@sekls.org> --- We've tested this and it is working as described. If a library is closed on their calendar, a holds queue isn't generated. If multiple libraries own an item, the hold goes to the open library's queue over the closed library's. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31057|0 |1 is obsolete| | --- Comment #7 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 31630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31630&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31063|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|kyle@bywatersolutions.com |melissa@bywatersolutions.co | |m --- Comment #8 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 31631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31631&action=edit Bug 12803 - Enable feature when using Transport Cost Matrix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|melissa@bywatersolutions.co |koha-bugs@lists.koha-commun |m |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31630|0 |1 is patch| | Attachment #31630|application/mbox |text/plain mime type| | CC| |melissa@bywatersolutions.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, could you please use Koha::Calendar instead of C4::Calendar? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12801 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32046&action=edit Bug 12803 [QA Followup] - Use Koha::Calendar -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Good catch Jonathan! Note this bug now depends on bug 12801 since it makes use of Koha::Calendar which has a caching bug that would cause this feature to work incorrectly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32271&action=edit Bug 12803: tidy up some tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Before this patch, load_branches_to_pull_from return undef if StaticHoldsQueueWeight was empty, now RandomizeHoldsQueueWeight and HoldsQueueSkipClosed are take into account. Kyle, could you please confirm it is an error? I am not comfortable enough to fix it in a followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- This is actually a bug fix. If you read the preference, it reads that RandomizeHoldsQueueWeight should work even if StaticHoldsQueueWeight is empty. However, in the original code this was not true. This change otherwise has no effect on the behavior of the feature. Previously, if load_branches_to_pull returned undef, GetItemsAvailableToFillHoldRequestsForBib would use all branches. This is still true, it just makes more logical sense now. If you would like me to revert the RandomizeHoldsQueueWeight behavior so the bug can be fixed separately, I'd be more than happy to do so. (In reply to Jonathan Druart from comment #13)
Before this patch, load_branches_to_pull_from return undef if StaticHoldsQueueWeight was empty, now RandomizeHoldsQueueWeight and HoldsQueueSkipClosed are take into account. Kyle, could you please confirm it is an error? I am not comfortable enough to fix it in a followup.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking at this now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but t/db_dependent/HoldsQueue.t is failing in my installation: t/db_dependent/HoldsQueue.t ................. 2/23 # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 310. # got: '2' # expected: '1' # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '3' # expected: '2' # Looks like you failed 2 tests of 23. t/db_dependent/HoldsQueue.t ................. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/23 subtests Could this conflict with the calendar changes for hourly? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12450 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- I cannot reproduce this error. Are you using Koha's sample data? I'm not sure these unit tests are reliable with any other data. (In reply to Katrin Fischer from comment #16)
I am sorry, but t/db_dependent/HoldsQueue.t is failing in my installation:
t/db_dependent/HoldsQueue.t ................. 2/23 # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 310. # got: '2' # expected: '1'
# Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '3' # expected: '2' # Looks like you failed 2 tests of 23. t/db_dependent/HoldsQueue.t ................. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/23 subtests
Could this conflict with the calendar changes for hourly?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #16)
I am sorry, but t/db_dependent/HoldsQueue.t is failing in my installation:
I got the same error, but when I executed the updatedb entry, the tests passed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle and Jonathan, I retested and made sure I ran the database update. ok 20 - Holds queue filling 2nd correct hold for default holds policy 'from home library' not ok 21 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 310. # got: '2' # expected: '1' ok 22 - Holds queue filling correct number for holds for default holds policy 'from any library' not ok 23 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '3' # expected: '2' # Looks like you failed 2 tests of 23. Without the patch and before the database update all the tests pass nicely on my db. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Tried again, and got the error. MariaDB [koha_ut]> select count(*) from systempreferences where variable="HoldsQueueSkipClosed"; +----------+ | count(*) | +----------+ | 1 | +----------+ % git diff diff --git a/t/db_dependent/HoldsQueue.t b/t/db_dependent/HoldsQueue.t index a73eac1..b67a2e2 100755 --- a/t/db_dependent/HoldsQueue.t +++ b/t/db_dependent/HoldsQueue.t @@ -307,6 +307,7 @@ C4::Calendar->new( branchcode => 'MPL' )->insert_single_holiday( ); C4::HoldsQueue::CreateQueue(); $holds_queue = $dbh->selectall_arrayref("SELECT * FROM tmp_holdsqueue", { Slice => {} }); +warn Data::Dumper::Dumper $holds_queue; is( scalar( @$holds_queue ), 1, "Holds not filled with items from closed libraries" ); C4::Context->set_preference('HoldsQueueSkipClosed', 0); % prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 18/23 $VAR1 = [ { 'itemcallnumber' => undef, 'reservedate' => '2015-02-12', 'borrowernumber' => '70', 'phone' => undef, 'surname' => 'Surname', 'holdingbranch' => 'CPL', 'pickbranch' => 'CPL', 'title' => 'Test Holds Queue XXX', 'item_level_request' => '0', 'notes' => undef, 'biblionumber' => '14', 'firstname' => 'Firstname', 'cardnumber' => 'CARDNUMBER1', 'itemnumber' => '127', 'barcode' => '350699408070' }, { 'reservedate' => '2015-02-12', 'itemcallnumber' => undef, 'borrowernumber' => '71', 'surname' => 'Surname', 'phone' => undef, 'pickbranch' => 'CPL', 'holdingbranch' => 'FFL', 'item_level_request' => '0', 'title' => 'Test Holds Queue XXX', 'notes' => undef, 'firstname' => 'Firstname', 'biblionumber' => '14', 'cardnumber' => 'CARDNUMBER2', 'itemnumber' => '128', 'barcode' => '350699408071' } ]; # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 311. # got: '2' # expected: '1' # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 328. # got: '3' # expected: '2' # Looks like you failed 2 tests of 23. t/db_dependent/HoldsQueue.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/23 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 512 Tests: 23 Failed: 2) Failed tests: 21, 23 Non-zero exit status: 2 Files=1, Tests=23, 3 wallclock secs ( 0.02 usr 0.00 sys + 1.96 cusr 0.04 csys = 2.02 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- And I confirm the tests pass on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Starting with a fresh database with all sample data. 1) t/db_dependent/HoldsQueue.t passes on master 2) t/db_dependent/HoldsQueue.t passes with bug 12803 pre-updatedatabase.pl 3) t/db_dependent/HoldsQueue.t passes with bug 12803 post-updatedatabse.pl I have no idea where to go from here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I have an Ubuntu 14.04 (amd64) box, all stock (I only have the koha repo, and the git ppa for the latest git). What I did was: - > DROP DATABASE koha_devel; CREATE DATABASE koha_devel; - Went through the install process, all default data loaded. - Run $ prove t/db_dependent/HoldsQueue.t => SUCCESS: all green - Applied the patches (small rebase for updatedatabase.pl) - Run $ perl installer/data/mysql/updatedatabase.pl Upgrade to 3.19.00.XXX done (Bug 12803 - Add ability to skip closed libraries when generating the holds queue) - Run $ prove t/db_dependent/HoldsQueue.t => FAIL: t/db_dependent/HoldsQueue.t .. 23/23 # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '1' # expected: '2' # Looks like you failed 1 test of 23. t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/23 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 23 Failed: 1) Failed test: 23 Non-zero exit status: 1 Files=1, Tests=23, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.49 cusr 0.06 csys = 1.57 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31630|0 |1 is obsolete| | Attachment #31631|0 |1 is obsolete| | Attachment #32046|0 |1 is obsolete| | Attachment #32271|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43509&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43510&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43509|0 |1 is obsolete| | Attachment #43510|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43511&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43512&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- % prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. ok All tests successful. Files=1, Tests=22, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.90 cusr 0.02 csys = 1.96 CPU) Result: PASS % git bz apply 12803 Bug 12803 - Add ability to skip closed libraries when generating the holds queue 43511 - Bug 12803 - Add ability to skip closed libraries when generating the holds queue 43512 - Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12803 - Add ability to skip closed libraries when generating the holds queue Applying: Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes % qa -c 2 -v 2 testing 2 commit(s) (applied to 390233a 'Bug 14966: Table header broken at det') Processing files before patches |========================>| 4 / 4 (100.00%) Processing files after patches |========================>| 4 / 4 (100.00%) OK Koha/Calendar.pm OK critic OK forbidden patterns OK pod OK spelling OK valid FAIL t/db_dependent/HoldsQueue.t OK critic FAIL forbidden patterns forbidden pattern: trailing space char (line 322) OK pod OK spelling OK valid OK C4/HoldsQueue.pm OK critic OK forbidden patterns OK pod OK spelling OK valid FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs HoldsQueueSkipClosed is bad placed (see bug 10610) % prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 13/24 # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '1' # expected: '2' # Looks like you failed 1 test of 24. t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/24 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 24 Failed: 1) Failed test: 23 Non-zero exit status: 1 Files=1, Tests=24, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.76 cusr 0.06 csys = 1.86 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 43511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43511 Bug 12803 - Add ability to skip closed libraries when generating the holds queue Review of attachment 43511: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12803&attachment=43511) ----------------------------------------------------------------- ::: C4/HoldsQueue.pm @@ +29,4 @@
use C4::Circulation; use C4::Members; use C4::Biblio; +use C4::Dates qw/format_date/;
Don't use C4::Dates, we are going to kick it out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |kyle.m.hall@gmail.com --- Comment #30 from Kyle M Hall <kyle.m.hall@gmail.com> ---
Don't use C4::Dates, we are going to kick it out.
Can you please point me to the method I should be using? I don't see a replacement in Koha::Calendar! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #30)
Don't use C4::Dates, we are going to kick it out.
Can you please point me to the method I should be using? I don't see a replacement in Koha::Calendar!
I was talking about C4::Dates, you should use Koha::DateUtils instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #32 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Jonathan Druart from comment #31)
(In reply to Kyle M Hall from comment #30)
Don't use C4::Dates, we are going to kick it out.
Can you please point me to the method I should be using? I don't see a replacement in Koha::Calendar!
I was talking about C4::Dates, you should use Koha::DateUtils instead.
Ah, I see now. I was looking at the wrong code! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43610&action=edit Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, comment 28 is not fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43779&action=edit Bug 12803 [QA Followup] - Fix koha-qa.pl errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Kyle M Hall <kyle.m.hall@gmail.com> ---
% prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 13/24 # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '1' # expected: '2' # Looks like you failed 1 test of 24. t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/24 subtests
Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 24 Failed: 1) Failed test: 23 Non-zero exit status: 1 Files=1, Tests=24, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.76 cusr 0.06 csys = 1.86 CPU) Result: FAIL
So far I have been completely unable to reproduce this failure using my test database or a fresh Koha db with all the sample data. Have you tested it with a fresh sample data database? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #36)
So far I have been completely unable to reproduce this failure using my test database or a fresh Koha db with all the sample data. Have you tested it with a fresh sample data database?
Everything passes with a fresh install, but then add a biblio and the tests won't pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43833&action=edit Bug 12803 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #38)
Created attachment 43833 [details] [review] Bug 12803 [QA Followup] - Fix unit tests
This is a bit radical and I would like to know why it fails. I don't understand why adding 1 biblio to the DB makes your tests failing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #40 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Jonathan Druart from comment #39)
(In reply to Kyle M Hall from comment #38)
Created attachment 43833 [details] [review] [review] Bug 12803 [QA Followup] - Fix unit tests
This is a bit radical and I would like to know why it fails. I don't understand why adding 1 biblio to the DB makes your tests failing.
I wish I could help you find out why, but I can't seem to reproduce your error! I tried with 1 bib and 0, 1 and 2 items. There must be something else going on in your database . If you can send me a copy of your test database I'll give it a shot! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not much help here I am afraid, but adding to the weirdness. Tests passed the second time I ran them, then they kept failing constantly. Additional weirdness: it's not always the same tests failing: Sometimes: perl t/db_dependent/HoldsQueue.t ... not ok 23 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 337. # got: '1' # expected: '2' Other times: perl t/db_dependent/HoldsQueue.t ... not ok 21 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 320. # got: '2' # expected: '1' ok 22 - Holds queue filling correct number for holds for default holds policy 'from any library' not ok 23 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 337. # got: '3' # expected: '2' ok 24 - Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch # Looks like you failed 2 tests of 24. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #40)
(In reply to Jonathan Druart from comment #39)
(In reply to Kyle M Hall from comment #38)
Created attachment 43833 [details] [review] [review] [review] Bug 12803 [QA Followup] - Fix unit tests
This is a bit radical and I would like to know why it fails. I don't understand why adding 1 biblio to the DB makes your tests failing.
I wish I could help you find out why, but I can't seem to reproduce your error! I tried with 1 bib and 0, 1 and 2 items. There must be something else going on in your database . If you can send me a copy of your test database I'll give it a shot!
I used the DB generated by bug 10337. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #43 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 43979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43979&action=edit Test Database SQL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #44 from Kyle M Hall <kyle.m.hall@gmail.com> --- Please try running the unit tests against the attached Test Database SQL file. I've run the unit test hundreds of times with this database and got no errors. I am very interested to see if you get any errors using the same database. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #44)
Please try running the unit tests against the attached Test Database SQL file. I've run the unit test hundreds of times with this database and got no errors. I am very interested to see if you get any errors using the same database.
I confirm that it fails here. I am using mysql Ver 15.1 Distrib 10.0.19-MariaDB, for debian-linux-gnu (i686) using readline 5.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was using Ubuntu with MySQL - using my 'normal' db with quite a bit of test data by now. Not sure we can find the 'common' thing for those who fail and does who fail not easily :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm not sure what I can possibly do to get this Passed QA. I get no unit test failures. You aren't getting them with my "Fix unit tests" followup ( iirc ). So there is not really anything I can do on my what. Jonthan, can you please investigate this since you are getting the failures as well? Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #47)
I'm not sure what I can possibly do to get this Passed QA. I get no unit test failures. You aren't getting them with my "Fix unit tests" followup ( iirc ). So there is not really anything I can do on my what. Jonthan, can you please investigate this since you are getting the failures as well? Thanks!
If the tests fail using the same DB as you, it's not related to the patches or the DB. Alone I cannot do anything. Are you using the same version of mysql as me? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43511|0 |1 is obsolete| | Attachment #43512|0 |1 is obsolete| | Attachment #43610|0 |1 is obsolete| | Attachment #43779|0 |1 is obsolete| | Attachment #43833|0 |1 is obsolete| | --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45569&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45570&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45571&action=edit Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45572&action=edit Bug 12803 [QA Followup] - Fix koha-qa.pl errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45573&action=edit Bug 12803 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45574&action=edit Bug 12803 [QA Followup] - Update unit tests due to changes in master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45573|0 |1 is obsolete| | Attachment #45574|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45575&action=edit Bug 12803 [QA Followup] - Update unit tests due to changes in master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45576&action=edit Bug 12803 [QA Followup] - Fix to stop failing unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Jonathan, Katrin, can you please try this new patch set? I think the last patch fixes the reason your tests are failing! I've removed the other 'fix' patch so you should be able to tell. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #58 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #57)
Jonathan, Katrin, can you please try this new patch set? I think the last patch fixes the reason your tests are failing! I've removed the other 'fix' patch so you should be able to tell.
The tests now pass but... I have apply the change of the last patch to my old branch and they don't pass. Did you change something else? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #58)
(In reply to Kyle M Hall from comment #57)
Jonathan, Katrin, can you please try this new patch set? I think the last patch fixes the reason your tests are failing! I've removed the other 'fix' patch so you should be able to tell.
The tests now pass but... I have apply the change of the last patch to my old branch and they don't pass. Did you change something else?
Yes, the second to last patch "Update unit tests due to changes in master" also makes some changes to HoldsQueue.t do to the fact that the tests no longer rely on the 'MPL' branchcode but instead generate random branches using TestBuilder. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #60 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1/ Please double check when you fix conflict on rebasing. You are duplicating lines. See use statements in t/db_dependent/HoldsQueue.t 2/ I think we could avoid the NO_CACHE env variable, which is not really meaningful and is only used once, for tests. It seems more suitable to clear the cache from the tests, don't you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45638&action=edit Bug 12803 [QA Followup] - Remove duplicate 'use' lines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45643&action=edit Bug 12803 [QA Followup] - Remove NO_CACHE -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Fixed! For reasons I cannot fathom, if I call is_holiday on the branch in question before building the queue, Koha::Calendar picks up the holiday and uses it later. If is_holiday is *not* called, later on when HoldQueue.pm using is_holiday it will not see the holiday in the database. I cannot explain this but it is clearly some kind of bad cache/database/unit test interaction that is far outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45643|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45644&action=edit Bug 12803 [QA Followup] - Remove NO_CACHE -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, There is a small conflict to fix. Do you mind if we mark this patch dependent on bug 15391? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45569|0 |1 is obsolete| | Attachment #45570|0 |1 is obsolete| | Attachment #45571|0 |1 is obsolete| | Attachment #45572|0 |1 is obsolete| | Attachment #45575|0 |1 is obsolete| | Attachment #45576|0 |1 is obsolete| | Attachment #45638|0 |1 is obsolete| | Attachment #45644|0 |1 is obsolete| | --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46888&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46889&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46890&action=edit Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46891&action=edit Bug 12803 [QA Followup] - Fix koha-qa.pl errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #70 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46892&action=edit Bug 12803 [QA Followup] - Update unit tests due to changes in master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46893&action=edit Bug 12803 [QA Followup] - Fix to stop failing unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46894&action=edit Bug 12803 [QA Followup] - Remove duplicate 'use' lines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46895&action=edit Bug 12803 [QA Followup] - Remove NO_CACHE -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #65)
Kyle, There is a small conflict to fix. Do you mind if we mark this patch dependent on bug 15391?
Fixed! I'm a bit reticent to make this dependent on bug 15391. Bug 15391 has no patches yet, indeed we haven't even truly nailed down the issue. Additionally, there is no real interaction / interdependence between the tests added here and the issues on bug 15391. My fear is that bug 15391 will take a long time to solve, which will hold up this patch set that's already been in process for years now. That being said, I'll leave the call up to you! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46888|0 |1 is obsolete| | Attachment #46889|0 |1 is obsolete| | Attachment #46890|0 |1 is obsolete| | Attachment #46891|0 |1 is obsolete| | Attachment #46892|0 |1 is obsolete| | Attachment #46893|0 |1 is obsolete| | Attachment #46894|0 |1 is obsolete| | Attachment #46895|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47246&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb <jrobb@sekls.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #76 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47247&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! Bug 12803 [QA Followup] - Fix koha-qa.pl errors Bug 12803 [QA Followup] - Update unit tests due to changes in master Bug 12803 [QA Followup] - Fix to stop failing unit tests Bug 12803 [QA Followup] - Remove duplicate 'use' lines Bug 12803 [QA Followup] - Remove NO_CACHE Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15391 --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, To easy the readability, I have squashed the qa follow-ups, especially because of the NOCACHE param, which has been added and finally removed. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15391 [Bug 15391] HoldsQueue.t does not handle for loan itemtypes correctly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org