[Bug 7582] New: When adding a Z39.50 server the "checked" option should use a Yes/No dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Bug #: 7582 Summary: When adding a Z39.50 server the "checked" option should use a Yes/No dropdown Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/admin/z3950servers.pl OS/Version: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: System Administration AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com Instead of asking the user to type 0 or 1 there should be a Yes/No dropdown for choosing whether a Z39.50 server is checked by default. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2012-02-22 17:33:47 UTC --- Created attachment 7813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7813 Bug 7582 - When adding a Z39.50 server the "checked" option should use a Yes/No dropdown -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2012-02-22 17:35:49 UTC --- After applying the patch, when adding or editing a Z39.50 server the "checked" option should show a dropdown choice of Yes or No. When editing, the option should be preselected with the correct value. I also updated the table of existing Z39.50 servers to show "Yes" or "No" instead of 1 or 0. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7813|0 |1 is obsolete| | Status|Needs Signoff |Signed Off AssignedTo|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-02-23 10:08:00 UTC --- Created attachment 7822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7822 [SIGNED-OFF] Bug 7582 - When adding a Z39.50 server the "checked" option should use a Yes/No dropdown I split the <tr> line in your patch for a best visibility. I hope you would agree to this modification. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> 2012-02-23 18:21:55 UTC --- Not to nit-pick, but wouldn't a single checkbox work just as well here for this boolean choice? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7822|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2012-02-24 13:52:05 UTC --- Created attachment 7854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7854 Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff AssignedTo|jonathan.druart@biblibre.co |oleonard@myacpl.org |m | Summary|When adding a Z39.50 server |When adding a Z39.50 server |the "checked" option should |the "checked" option should |use a Yes/No dropdown |use a checkbox -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7854|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-25 20:30:25 UTC --- Created attachment 7872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7872 Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 17:36:38 UTC --- QA comment: * small patches, mostly on template * template still valid & translatable passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-28 08:57:01 UTC --- last patch I pushed yesterday, forgot to update the status -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Although I think this is a definite improvement, I am not going to push it to 3.6.x because I would not expect a minor version to make a change to the data entry interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7582 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org