[Bug 9085] New: Installer will not run with DEBUG set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Priority: P5 - low Change sponsored?: --- Bug ID: 9085 Assignee: gmcharlt@gmail.com Summary: Installer will not run with DEBUG set Severity: major Classification: Unclassified OS: All Reporter: cnighswonger@foundations.edu Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha This is due to raising all db errors combined with the fact that attempts to make selections from a non-existent systempreferences table raises db errors. The installer should run even with DEBUG set, otherwise dropping and recreating a development database becomes somewhat of a chore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |cnighswonger@foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 13455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13455&action=edit Bug 9085 - Installer will not run with DEBUG set This is due to raising all db errors combined with the fact that attempts to make selections from a non-existent systempreferences table raises db errors. The installer should run even with DEBUG set, otherwise dropping and recreating a development database becomes somewhat of a chore. This patch adds code to check for the existence of the systempreferece table. If the table exists, then RaiseError is enabled on the database handle. Otherwise it is disabled to allow the installer to run without throwing an error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13455|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13459&action=edit Bug 9085 - Installer will not run with DEBUG set This is due to raising all db errors combined with the fact that attempts to make selections from a non-existent systempreferences table raises db errors. The installer should run even with DEBUG set, otherwise dropping and recreating a development database becomes somewhat of a chore. This patch adds code to check for the existence of the systempreferece table. If the table exists, then RaiseError is enabled on the database handle. Otherwise it is disabled to allow the installer to run without throwing an error. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The installer can now be run both with and without DEBUG set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * I checked that this patch changed nothing in usual cases * add a safety check, usefull only if DEBUG is set. Maybe the test could have been done only when DEBUG is ON, but with Plack, dbh will be much more persistant than CGI, so the cost of the new eval {} is OK * passes koha-qa.plr passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13459|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13547&action=edit Bug 9085 - Installer will not run with DEBUG set This is due to raising all db errors combined with the fact that attempts to make selections from a non-existent systempreferences table raises db errors. The installer should run even with DEBUG set, otherwise dropping and recreating a development database becomes somewhat of a chore. This patch adds code to check for the existence of the systempreferece table. If the table exists, then RaiseError is enabled on the database handle. Otherwise it is disabled to allow the installer to run without throwing an error. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> The installer can now be run both with and without DEBUG set. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9085 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org