[Bug 9980] New: Anonymous searches in the OPAC entirely broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Bug ID: 9980 Summary: Anonymous searches in the OPAC entirely broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jcamins@cpbibliography.com CC: kyle@bywatersolutions.com Depends on: 7740 I get the following error when I try to do a search on the OPAC without logging in: Software error: Can't use an undefined value as a HASH reference at /home/jcamins/kohaclone/opac/opac-search.pl line 719. For help, please send mail to the webmaster (webmaster@koha), giving this error message and the time and date of the error. This is caused by commit 4def1cb4 (bug 7740). The solution is to wrap the C4::Context->userenv bit in an if statement. Since we are so late in the release cycle, and reverting is easy, I will plan to revert 7740 on or about April 5 if this bug is not adopted by then. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Searching Assignee|oleonard@myacpl.org |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *ping* Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm yep this is a massive blocker, working on the fix now, otherwise bug 7740 is going to be reverted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17229&action=edit Bug 9980 : Fix for anonymous searches To test Search in the OPAC both logged and logged out -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17229|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 17250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17250&action=edit Bug 9980 : Fix for anonymous searches To test Search in the OPAC both logged and logged out Signed-off-by: Magnus Enger <magnus@enger.priv.no> When I turn off XSLT for the OPAC I can recreate the problem. After applying the patch things work as expected for all combinations of: - Search results and detail view - Logged in and not logged in - XSLT and non-XSLT view -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17250|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 17251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17251&action=edit Bug 9980 : [SIGNED-OFF] Fix for anonymous searches To test Search in the OPAC both logged and logged out Signed-off-by: Magnus Enger <magnus@enger.priv.no> When I turn off XSLT for the OPAC I can recreate the problem. After applying the patch things work as expected for all combinations of: - Search results and detail view - Logged in and not logged in - XSLT and non-XSLT view -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17251|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17252&action=edit [PASSED QA] Bug 9980: Fix for anonymous searches To test Search in the OPAC both logged and logged out Signed-off-by: Magnus Enger <magnus@enger.priv.no> When I turn off XSLT for the OPAC I can recreate the problem. After applying the patch things work as expected for all combinations of: - Search results and detail view - Logged in and not logged in - XSLT and non-XSLT view Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests, QA script and test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8198 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10217 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org