[Bug 10022] New: Multiple tags moderation doesn't work on translated page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Bug ID: 10022 Summary: Multiple tags moderation doesn't work on translated page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com CC: gmcharlt@gmail.com When using a translated intranet, tags moderation using checkboxes and a submit button doesn't work. You get a message "Unknown Operation on x Term(s)" (translated of course). This is because submit value is translated, it must not be used in perl page to find witch submit button has been pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Tools Assignee|koha-bugs@lists.koha-commun |gmcharlt@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 17338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17338&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9266 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Fridolyn, I also ran into translation related problems with tags some time ago. Maybe take a look at 9266 if it is a duplicate? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- This does look similar to bug 9266, whoever signs off code test both, and mark 9266 resolved duplicate if this solves both -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17338|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17728&action=edit [SIGNED-OFF] Bug 10022 - Multiple tags moderation doesn't work on translated page When using a translated intranet, tags moderation using checkboxes and a submit button doesn't work. You get a message "Unknown Operation on x Term(s)" (translated of course). This patch corrects by using name="op-[operation]" instead of name="op" in each submit input. Test plan : - Create a new tag on a record - Go to tags moderation in Tools => You should see your tag in pending terms - Click on checkbox - Click on Approve or Reject submit button at the bottom of the table => Without patch the tag is still pending => With patch operation is well performed, tag is not pending - Test "Check lists" form - Test Approve and Reject buttons from "Actions" column Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17728|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17780&action=edit [PASSED QA] Bug 10022 - Multiple tags moderation doesn't work on translated page When using a translated intranet, tags moderation using checkboxes and a submit button doesn't work. You get a message "Unknown Operation on x Term(s)" (translated of course). This patch corrects by using name="op-[operation]" instead of name="op" in each submit input. Test plan : - Create a new tag on a record - Go to tags moderation in Tools => You should see your tag in pending terms - Click on checkbox - Click on Approve or Reject submit button at the bottom of the table => Without patch the tag is still pending => With patch operation is well performed, tag is not pending - Test "Check lists" form - Test Approve and Reject buttons from "Actions" column Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org