[Bug 12697] New: Surplus closing </div> in OPAC advanced search (bootstrap)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Bug ID: 12697 Summary: Surplus closing </div> in OPAC advanced search (bootstrap) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: abl@biblos.pk.edu.pl QA Contact: testopia@bugs.koha-community.org In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first): 336: </div> <!-- / .span4 --> which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Jacek Ablewicz <ablewicz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 --- Comment #1 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 30486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30486&action=edit Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first): 336: </div> <!-- / .span4 --> which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl Assignee|oleonard@myacpl.org |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12521 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30486|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30597&action=edit [SIGNED-OFF] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first): 336: </div> <!-- / .span4 --> which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 12521, don't know exactly what to reproduce, but surplus '</div>' is real (33 open, 34 close). Everything looks correct, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30597|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30824&action=edit [PASSED QA] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first): 336: </div> <!-- / .span4 --> which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well. To reproduce: 1/ go to the OPAC advanced search page 2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result 3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043). To test: 1/ ensure that Bug 12521 is applied first/already applied 2/ apply patch 3/ confirm that this issue is no longer reroductible Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> On top of 12521, don't know exactly what to reproduce, but surplus '</div>' is real (33 open, 34 close). Everything looks correct, no koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org