[Bug 12863] New: News in OPAC: HTML broken with nested p tags and multiple thead in same table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Bug ID: 12863 Summary: News in OPAC: HTML broken with nested p tags and multiple thead in same table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org HTML validator displays errors for news in OPAC. I used HTMML validator 0.9.5.8 for Firefox. 1) nested p-Tag like <tbody><tr><td><p><p>This is the text...</p></p> (...) This is because opac-main.tt encloses the news text with a p tag. This is not necessary since the News editor delivers HTML formatted text. To test: Create news with just on line. Display in OPAC and test with HTML validator or check page source code. 2) multiple thead in same table if you have more than one news To test: Create multiple news for OPAC. HTML validator will complain about multiple thead tags in same table. This is not allowed, see: www.w3.org/TR/html-markup/table.html#table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 31333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31333&action=edit Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch fixes broken HTML in OPAC news by replacing table display with divs. To test: Create multiple news for OPAC Validate with HTML validator or check source code Result: Error with nested p tags Table header thead is repeated for every news (not allowed) Bonus testing: Let a screen reader like NVDA read the news and try to understand it with closed eyes. Apply patch Result: No more HTML errors in news Screen reader reads news properly To style you can use classes newscontainer, newsitem, newsheader, newsbody and newsfooter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Severity|trivial |minor --- Comment #2 from Marc Véron <veron@veron.ch> --- Setting to P4 since HTML is broken and accessibiliy by screen readers affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31333|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31394&action=edit [SIGNED-OFF] Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch fixes broken HTML in OPAC news by replacing table display with divs. To test: Create multiple news for OPAC Validate with HTML validator or check source code Result: Error with nested p tags Table header thead is repeated for every news (not allowed) Bonus testing: Let a screen reader like NVDA read the news and try to understand it with closed eyes. Apply patch Result: No more HTML errors in news Screen reader reads news properly To style you can use classes newscontainer, newsitem, newsheader, newsbody and newsfooter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31395&action=edit Bug 12863 [LESS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This follow-up modifies the LESS file to add style to the new markup to match the previous markup. A subsequent patch will include the revised and compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 31396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31396&action=edit Bug 12863 [CSS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch contains the revised and compiled CSS which will style the OPAC's new news markup to match the previous version. To test, apply the patch and clear your browser cache if necessary. View news in the OPAC and confirm that it is styled like it was before the patch making markup changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31395|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 31398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31398&action=edit Bug 12863 [LESS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This follow-up modifies the LESS file to add style to the new markup to match the previous markup. A subsequent patch will include the revised and compiled CSS. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 31399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31399&action=edit [Signed-off] Bug 12863 [CSS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch contains the revised and compiled CSS which will style the OPAC's new news markup to match the previous version. To test, apply the patch and clear your browser cache if necessary. View news in the OPAC and confirm that it is styled like it was before the patch making markup changes. CSS patch behaves as expected. Thanks to Owen for adding this. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31394|0 |1 is obsolete| | Attachment #31398|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31443&action=edit [PASSED QA] Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch fixes broken HTML in OPAC news by replacing table display with divs. To test: Create multiple news for OPAC Validate with HTML validator or check source code Result: Error with nested p tags Table header thead is repeated for every news (not allowed) Bonus testing: Let a screen reader like NVDA read the news and try to understand it with closed eyes. Apply patch Result: No more HTML errors in news Screen reader reads news properly To style you can use classes newscontainer, newsitem, newsheader, newsbody and newsfooter. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31444&action=edit [PASSED QA] Bug 12863 [LESS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This follow-up modifies the LESS file to add style to the new markup to match the previous markup. A subsequent patch will include the revised and compiled CSS. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31445&action=edit [PASSED QA] Bug 12863 [CSS follow-up] News in OPAC: HTML broken with nested p tags and multiple thead in same table This patch contains the revised and compiled CSS which will style the OPAC's new news markup to match the previous version. To test, apply the patch and clear your browser cache if necessary. View news in the OPAC and confirm that it is styled like it was before the patch making markup changes. CSS patch behaves as expected. Thanks to Owen for adding this. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31399|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12863 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org