[Bug 6149] New: Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Bug #: 6149 Summary: Operator Highlighted in Search Results Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: spalding@senylrc.org QAContact: koha-bugs@lists.koha-community.org When I do an advance search and use an operator like 'and' or 'or' it is highlighted in the search results. This link will demonstrate the issue where I did a search for nurse or care,and letters or are highlighted in the results. http://vassar.koha.senylrc.org/cgi-bin/koha/opac-search.pl?idx=kw&q=nurse&op=or&idx=kw&q=care&op=and&idx=kw&do=Search&limit=branch%3ANPKVBH&sort_by=title_az Koha version: 3.02.06.000 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Zachary Spalding <spalding@senylrc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |rel_3_4 Severity|trivial |major --- Comment #1 from Zachary Spalding <spalding@senylrc.org> 2011-07-06 18:13:10 UTC --- Currently using Koha version: 3.04.01.000, also I think it is affecting search results. There are records being return with only the operator highlighted. Is this something that can be fixed in ccl.properties file? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|major |trivial --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-06 18:28:34 UTC --- The highlighting is done by css/jquery client side. So it cant be fixed/changed server side, and indeed does not affect anything in the search. If your search is returning bad results, that is unrelated to highlighting, and would need its own bug -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |savitra.sirohi@osslabs.biz Assignee|gmcharlt@gmail.com |savitra.sirohi@osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I believe this is still a valid bug. The highlighter needs to be more intelligent about what it highlights. Perhaps we can just tell it to never highlight the boolean operators, or pass the keywords only to it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10704 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 20240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20240&action=edit Patch to add syspref controlled stopwords to highlighting. This is an initial patch to implement some additional control upon the search result term highlighting features. It add a stopwords system preference where a pipe delimited list of words can be added which will prevent these words from being highlighted in search results. To Test 1. Enable OpacHighlightWords in the staff client 2. Run a search where results will be obtained 3. Note that all serach terms (including operators like 'and') are highlighted 4. Click through to the detailed display for one of the results 5. Note that all search terms are highlighted. 6. Apply patch 7. Add some 'stopwords' to new OpacHighlightStopWords system preference. 8. Run another search that includes some of the words you've just added to stopwords 9. Note that the stopwords are no longer highlighted, all other search terms should still appear highlighted. 10. Click through to the detailed display for a record 11. Note that the stopwrods are no longer highlighted, all other search terms should still be highlighted. Note for QA.. I'm sure there's a follow-up required for this patch with the correct DB additions for adding a syspref, but I'm reminding myself on the etiquette for that before submitting the follow-up. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Martin Renvoize from comment #4)
Note for QA.. I'm sure there's a follow-up required for this patch with the correct DB additions for adding a syspref, but I'm reminding myself on the etiquette for that before submitting the follow-up.
Martin, take a look at the installer/data/mysql/updatedatabase.pl file. You should add a new entry (as the 3.13.00.015 entry). You have to add the new syspref to the installer/data/mysql/sysprefs.sql file too. This patch does not apply anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20240|0 |1 is obsolete| | Status|ASSIGNED |Needs Signoff Assignee|savitra.sirohi@osslabs.biz |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 20469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20469&action=edit Patch to add syspref controlled stopwords to highlighting Updated to apply to current master and also added db updates as suggested by Jonathan (thanks for the reminder). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- 1) OpacHighlightStopWords is used the database update and sysprefs sql file, but OpacHighlightedStopWords is used everywhere else. 2) Please use the TT plugin function Koha.Preference() to get the preference, rather than passing it it from the perl script 3) It's not working for me! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20469|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 20540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20540&action=edit Patch to add syspref controlled stopwords to highlighting Patch updated to reflect Kyles comments: 1. OpacHightlightedStopWords used consistently throughout files 2. TT Plugin used for sysprefs inside the template instead of adding logic to koha pl files where not required. 3. See follow-up comment. Patch also rebased against master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the comments Kyle, I've done as asked with regard to silly mistakes in the sql update files and using the TT Plugin to fetch the preference now. (I didn't realise we had that yet.. oops) As for 'It's not working!', could you elaborate at all? What browser are you using, is javascript enabled (without it highlighting won't work at all)? Cheers Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm using chrome. Enabling the feature and setting it to "OR|or|Or" did not stop the "or"s in my results from being highlighted. I'll retest and let you know if I find any errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Martin, I've retested and discovered my problem. I had assumed this would affect the staff intranet! It works great in the OPAC. Do you think you could provide a followup to add this functionality to the staff intranet as well? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That's a relief, I hadn't got a clue why it wasn't working otherwise. Patch coming up to also add the stopwords to the staff client.. to be honest, I'de completely forgotten the staff client also does the highlighting.. looking through it, the code is very inconsistent with the opac method and doesn't apply to the detailed result view, only the search results page. Anywho.. I'll patch the results page as is. Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20540|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 20543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20543&action=edit Patch to add syspref controlled stopwords to highlighting Followup patch: Adds same stopwords to Staff Client Search Results page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't think this actually got to QA.. so resetting to Needs Signoff, as I think the 'Failed QA' status is holding it back from any further comment or testing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #15 from Campbell Reid-Tait <campbellreidtait@gmail.com> --- Created attachment 20715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20715&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Campbell Reid-Tait <campbellreidtait@gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20543|0 |1 is obsolete| | CC| |campbellreidtait@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Campbell Reid-Tait <campbellreidtait@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Campbell Reid-Tait <campbellreidtait@gmail.com> --- Works on OPAC. Followup patch to add same stopwords to Staff Client Search Results page, still needed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Campbell, It should all be in the one patch, including the staff client piece... I can see it's still in the patch you signed off from the diffs.. Could you give any errors you see if it's really not working? Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Martin Renvoize from comment #17)
Could you give any errors you see if it's really not working?
Hi Martin, It does not work neither for me on the staff interface. Try to use the Koha plugin at the top of the results.tt file ([% USE Koha %]). Moreover, I think it would be great to have the list of stopwords case insensitive, in order to avoid to list all variants (The, the, THE). Marked as Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Jonathan (In reply to Jonathan Druart from comment #18)
It does not work neither for me on the staff interface. Try to use the Koha plugin at the top of the results.tt file ([% USE Koha %]).
Thanks for the heads up regarding calling the Koha plugin in results.tt, I've now added this and tested. Seems to be working as expected to me.
Moreover, I think it would be great to have the list of stopwords case insensitive, in order to avoid to list all variants (The, the, THE).
I've now taken this into account too, making it case insensitive was a great idea! Patch to follow. . . -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20715|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 20802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20802&action=edit Bug 6149 - Stopwords for Result Highlighting Rebased again, and taken Jonathans comments into account. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also noted that these highlighting systems are out of sync between opac and staff client, including the lack of staff client code for Bug 10686. Once I've got this bit out of the way, I'm tempted to submit that as a speerate bug and patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #22 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 6149 - Stopwords for Result Highlighting Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt M koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Patch failed at 0001 Bug 6149 - Stopwords for Result Highlighting The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20802|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 21168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21168&action=edit Bug 6149 - Stopwords for result highlighting Rebased upon master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #24 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 6149 - Stopwords for Result Highlighting Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Patch failed at 0001 Bug 6149 - Stopwords for Result Highlighting The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21582&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21168|0 |1 is obsolete| | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, bit confused about the example values: and|And|or|Or 1) Do we need 'And' and 'and' when the values are now case insensitive?
I've now taken this into account too, making it case insensitive was a great >idea!
2) Why not list 'not'? I will continue to test, this could go into a follow up. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21582|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21831&action=edit [PASSED QA] Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #26)
Hm, bit confused about the example values: and|And|or|Or
1) Do we need 'And' and 'and' when the values are now case insensitive?
I've now taken this into account too, making it case insensitive was a great >idea!
2) Why not list 'not'?
I will continue to test, this could go into a follow up.
Hmmm, it's passed QA now, but I was intending on posting a followup for Katrin's comments. The sample that should go into the sql would probably be best as 'and|or|not' now that I've made it case insensative and the 'not' is a good addition that I just hadn't thought of before ;) Either way, that's very trivial and not worth losing QA for :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22448&action=edit Bug 6149: Follow-up - Operator highlighted in search results - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Martin, could you take a look at my follow-up and sign-off on it if it's ok? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think we will also need a follow up for the Bootstrap OPAC. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22448|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 22463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22463&action=edit [SIGNED OFF] Bug 6149: Follow-up - Operator highlighted in search results Signed off on Katrin's followup, works perfectly and both changes make great sense. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 22466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22466&action=edit Bug 6149 - Follow-up - Stopwords for Result Highlighting This follow-up adds the feature to the bootstrap theme as requested by Katrin ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22466|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 22505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22505&action=edit [SIGNED OFF] Bug 6149: Follow-up - Stopwords for Result Highlighting (Bootstrap) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Adds fix to the Bootstrap OPAC theme, works nicely. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The highlight does not work at all on the detail page with the bootstrap theme (caused by a JS error: q_array[x] = q_array[x]toLowerCase();). I think the change should be done in the opac-results-grouped template file too. Maybe should you include this function into a js file in order to avoid a duplication of code. Marked as Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, it worked for me yesterday - but i was not using the grouped template and was not aware it's currently used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #36)
Hi Jonathan, it worked for me yesterday - but i was not using the grouped template and was not aware it's currently used.
The opac-detail cannot work, a dot is missing in the JS code: + q_array[x] = q_array[x]toLowerCase(); The template seems to be used if the pref OpacGroupResults is enabled. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah you are right - I forgot to test the highlighting on the detail page :( Just tested results - thx Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pants, there's always a typo.. I must have been in ccsr instead of bootstrap. Now I feel silly! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22505|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 22511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22511&action=edit Bug 6149: Follow-up - Stopwords for Result Highlighting (Bootstrap) QA Followup to fix the stupid typo... ack, double checked it this time! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22511|0 |1 is obsolete| | --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 23005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23005&action=edit [SIGNED-OFF] Bug 6149: Follow-up - Stopwords for Result Highlighting (Bootstrap) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 23025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23025&action=edit Bug 6149: Follow-up - Stopwords for Result Highlighting (opac-results-grouped) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added a follow up patch to add the feature to opac-results-grouped templates as requested. I'm working on a further follow-up to tidy the code out into a manageable file now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Jonathan, could you test that last patch for me? I'm confident it should work, but I don't have any systems with a working pazpar config to test upon. Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 23027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23027&action=edit Bug 6149: Follow-up - Stopwords for Result Highlighting Final follow-up: Refactors code to includes to simpify future maintainability. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Martin Renvoize from comment #44)
Jonathan, could you test that last patch for me? I'm confident it should work, but I don't have any systems with a working pazpar config to test upon.
Sorry Martin but I don't have pazpar2 configured. I tested all pages (except opac-results-grouped.tt), and all works great. Maybe the refactoring could be done in another report in order not to block this one. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11270 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23027|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 23027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23027 Bug 6149: Follow-up - Stopwords for Result Highlighting Moved last patch (re-factoring) into separate bug. (bug 11270) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks Martin. The last patch modifies a page I cannot test (opac-results-grouped), so I cannot pass QA on it. Given that neither you nor me are tested this patch, I propose either someone (with pazpar2 configured) signs off this last patch or someone else does qa on it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure pazpar2 is actually functional at this point in time, so I am not sure the change should block this from going in. If I just turn on OpacGroupResults I get a perl error in OPAC: Fehler: Could not find opac-search.xml in /usr/share/koha/opac/cgi-bin/opac/ at /usr/share/koha/lib/C4/Search.pm line 689 Maybe we could agree on having the first 3 patches go in and leaving the third on the bug? OpacGroupResults -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- Agreed! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #51 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note the highlight does not work on the catalogue detail page (not a regression). 3 first patches marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21831|0 |1 is obsolete| | Attachment #22463|0 |1 is obsolete| | Attachment #23005|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23064&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23065&action=edit Bug 6149: Follow-up - Operator highlighted in search results - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #54 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23066&action=edit Bug 6149: Follow-up - Stopwords for Result Highlighting (Bootstrap) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23025|Bug 6149: Follow-up - |[NOT PASSED QA] Bug 6149: description|Stopwords for Result |Follow-up - Stopwords for |Highlighting |Result Highlighting |(opac-results-grouped) |(opac-results-grouped) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt@gmail.com --- Comment #55 from Galen Charlton <gmcharlt@gmail.com> --- Think on the name of the sysprefs: HighlightedStopWords. A user could be excused for thinking that it was the name of stopwords that /should/ be highlighted. So could a developer maintaining this in the future. WordsNotToHighlightInSearchResults is closer to the mark, although I'm open to a less verbose way of saying it. In any event, please resubmit with a better name. I have no other serious objection to the patch, though if you think of searching for titles like "Harry potter and the goblet of fire", I don't really consider it much of a win. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 26051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26051&action=edit Bug 6149 - RM followup. Gloabal replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Submitted followup as requested. I think the name is suitable descriptive whilst not being overly verbose now, though am happy to change if advised. I agree, it's a pretty trivial solution, and could probabylbe implimetned more thoroughly given a rewrite of the highlighter itself... but it does solves the imediate problem for a number of our customers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #58 from Owen Leonard <oleonard@myacpl.org> --- This is not working for me, I think because there is some mixup with the preference name. It appears that updatedatabase.pl at the very least suffers from this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, that's interesting.. The only follow-up I did was a mas find/replace on that syspref name as per Galen request. I can't find any mention of the wrong name in the codebase now? I'll dig a little further -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23064|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30136&action=edit Bug 6149: Follow-up - Stopwords for Result Highlighting (opac-results-grouped) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30137&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23065|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30138&action=edit Bug 6149: Follow-up - Operator highlighted in search results - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26051|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30139&action=edit Bug 6149 - RM followup. Gloabal replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Re-based upon current master, though with the imminent removal of CCSR and prog I'm thinking I should factor those two bits of the patch out now. I still intend, but have no idea if I'll ever get around to it, to factor out the highlighting code so it's more easily applied across templates with just an include. I'd also like to update the jquery plugin (either to v4 from v3.. or to http://bartaz.github.io/sandbox.js/jquery.highlight.html fork), and add some ajax cleverness so that instead of having to create a list of stopwords (though that may still be useful for some other cases) we could get a more accurate set of search terms without operators back from the search script itself) I don't see why this one should get held up much further though.. it still works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23025|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30138|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30140&action=edit Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30141&action=edit Bug 6149: Follow-up [defaults] - Stopwords for Result Highlighting - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30142&action=edit Bug 6149: Follow-up [bootstrap] - Stopwords for Result Highlighting - Added functionality to new bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30143&action=edit Bug 6149: Follow-up [grouped] - Stopwords for Result Highlighting - Added functionaility to opac-results-grouped page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30144&action=edit Bug 6149 - Follow-up [syspref] - Stopwords for Result Highlighting - global replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry to have to add a comment 70 to this, but it doesn't work in Bootstrap for me. I tried with der|die|das and it still highlights them in the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30144|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30835&action=edit Bug 6149 - Follow-up [syspref] - Stopwords for Result Highlighting - global replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30842&action=edit [PASSED QA] Bug 6149 - Stopwords for Result Highlighting This patch adds a system preference to control stopwords used to prevent operators and other 'minor' words from being highlighted in search results when the OpacHighlightWords syspref is enabled Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Works as advertised, I fixed the updatedatabase to use XXX so it won't clash as much Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a conflict in updatedatabase.pl. Also fixed tabs in opac-detail.tt Feature passes all tests and QA script now. Tested in intranet and OPAC with different words and searches. Works on results pages and OPAC detail page. Highlighting and unhighlighting still works correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30843&action=edit [PASSED QA] Bug 6149: Follow-up [defaults] - Stopwords for Result Highlighting - changed sample words to and|or|not in sysprefs.sql and updatedatabase - changed systempreference name from OpacHighlightedStopwords to HighlightedStopwords, as it also works for the staff results page Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30844&action=edit [PASSED QA] Bug 6149: Follow-up [bootstrap] - Stopwords for Result Highlighting - Added functionality to new bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30845&action=edit [PASSED QA] Bug 6149: Follow-up [grouped] - Stopwords for Result Highlighting - Added functionaility to opac-results-grouped page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #76 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30846&action=edit [PASSED QA] Bug 6149 - Follow-up [syspref] - Stopwords for Result Highlighting - global replaced HightedStopWords syspref with NotHightedWords for clarification purposes. Hopefully this is a bit better and still not too verbose. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, fixed some tabs and a typo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30141|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30143|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches also change the old prog theme, but changes are small, bug report is old and has gone through a lot of iterations already, and we are going to remove the templates soon ...I am going to let it pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 31403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31403&action=edit Bug 6149: (qa followup) sysprefs should be alphabetically sorted Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org