[Bug 14284] New: Typo in Languages.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 Bug ID: 14284 Summary: Typo in Languages.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Architecture, internals, and plumbing Assignee: indradg@gmail.com Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org Line #102 reads as follows: 'native_descrition'=>$language_set->{language_native_description} } should read : 'native_description'=>$language_set->{language_native_description} } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39624&action=edit Bug 14284 - Fixes typo 'native_descrition' Fixes the following typo (originally line 102 in C4/Languages.pm): 'native_descrition'=>$language_set->{language_native_description} } to read: 'native_description'=>$language_set->{language_native_description} } Test plan ========= 1/ in your git installdir do a `grep -R native native_descrition`. it should return only one single reference to this line in C4/Languages.pm 2/ open the file C4/Languages.pm, go to line #102 to confirm it. close the file 3/ apply patch 4/ re-run `grep -R native native_descrition`, this time nothing should be returned. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Someone missed that?! Write some tests, so I can sign this sucker off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Bug 12017 has a patch piece that removes this function completely. I'm sure the correct course of action will be taken with respect to this function (getFrameworkLanguages) there. *** This bug has been marked as a duplicate of bug 12017 *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. Tompsett from comment #3)
Bug 12017 has a patch piece that removes this function completely. I'm sure the correct course of action will be taken with respect to this function (getFrameworkLanguages) there.
Was about to said that, it's dead code -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14284 --- Comment #5 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #4)
(In reply to M. Tompsett from comment #3)
Bug 12017 has a patch piece that removes this function completely. I'm sure the correct course of action will be taken with respect to this function (getFrameworkLanguages) there.
Was about to said that, it's dead code
bgkriegel++ for 12017! :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org