[Bug 27072] New: Don't process staff interface CSS with rtlcss
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Bug ID: 27072 Summary: Don't process staff interface CSS with rtlcss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 20168 The conversion of OPAC templates to Bootstrap 4 included the introduction of automatic generation of right-to-left CSS using rtlcss(). This process unintentionally results in the creation of an RTL version of staff-global.css although it is unused. The ultimate goal should be to update the staff interface to include RTL CSS generated by rtlcss, but in the meantime we can make a change to gulpfile.js to exclude the staff client CSS from processing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd like this one for 20.11 if possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113925&action=edit Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113925|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 113938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113938&action=edit Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113938|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113950&action=edit Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thank, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113950|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113951&action=edit Bug 27072: Don't process staff interface CSS with rtlcss This patch changes Koha's gulpfile to add a check for the "OPAC" context before using rtlcss to automatically build right-to-left versions of CSS. To test, apply the patch and test the process of building CSS for both the OPAC and staff client: - "yarn css --view opac" : This should build unminified CSS for the OPAC, including map files in bootstrap/css/maps - "yarn build --view opac" : This should build minified CSS for the OPAC and generate the RTL versions. - "yarn css" : This should build unminified CSS for the staff interface, including map files in prog/css/maps. - "yarn build" : This should build minified CSS for the staff interface, with no creation of RTL versions. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Ohh, we clashed.. I was just QAing too.. double signoff :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master Keywords|rel_20_11_target | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Bug 27072 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org