[Bug 28193] New: OpacLoginInstructions news block broken by Bug 18506
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Bug ID: 28193 Summary: OpacLoginInstructions news block broken by Bug 18506 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, bolshawh@parliament.uk, caroline.cyr-la-rose@inlibro.com, dcook@prosentient.com.au, dpavlin@rot13.org, fridolin.somers@biblibre.com, jonathan.druart@bugs.koha-community.org, julian.maurice@biblibre.com, katrin.fischer@bsz-bw.de, kyle@bywatersolutions.com, martin.renvoize@ptfs-europe.com, matthias.meusburger@biblibre.com, nick@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 18506 Bug 18506 introduced a regression in the opac-auth template, undoing the changes made by Bug 23797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 [Bug 18506] SSO - Shibboleth Only Mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OpacLoginInstructions news |OpacLoginInstructions news |block broken by Bug 18506 |block broken by Bug 20168 Depends on|18506 |20168 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Whoops, I've falsely accused Bug 18506. Git blames me! Bug 20168! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 [Bug 18506] SSO - Shibboleth Only Mode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|andrew@bywatersolutions.com | |, bolshawh@parliament.uk, | |caroline.cyr-la-rose@inlibr | |o.com, | |dcook@prosentient.com.au, | |dpavlin@rot13.org, | |fridolin.somers@biblibre.co | |m, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |julian.maurice@biblibre.com | |, katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, | |matthias.meusburger@biblibr | |e.com, | |nick@bywatersolutions.com, | |testopia@bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120008&action=edit Bug 28193: OpacLoginInstructions news block broken by Bug 20168 This patch fixes a regression which was introduced by Bug 20168, causing the OpacLoginInstructions template code to revert back to the old system preference behavior. This patch returns the correct markup. To test, apply the patch and view the OPAC login page (/cgi-bin/koha/opac-user.pl) - With no news entry for OpacLoginInstructions you should see the default: A block of text with two headings, "Don't have a password yet?" and "Don't have a library card?" - Go to Tools -> News and create an entry for OpacLoginInstructions. - Return to the OPAC and confirm that your custom text appears. - Try updating/installing another translation and adding a different news entry for that language. Confirm that the correct entry appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120008|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 120026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120026&action=edit Bug 28193: OpacLoginInstructions news block broken by Bug 20168 This patch fixes a regression which was introduced by Bug 20168, causing the OpacLoginInstructions template code to revert back to the old system preference behavior. This patch returns the correct markup. To test, apply the patch and view the OPAC login page (/cgi-bin/koha/opac-user.pl) - With no news entry for OpacLoginInstructions you should see the default: A block of text with two headings, "Don't have a password yet?" and "Don't have a library card?" - Go to Tools -> News and create an entry for OpacLoginInstructions. - Return to the OPAC and confirm that your custom text appears. - Try updating/installing another translation and adding a different news entry for that language. Confirm that the correct entry appears. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, a git grep still reveals some references to the system preference: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc: [% IF Koha.Preference( 'OpacLoginInstructions' ) %] Can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 120037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120037&action=edit Bug 28193: (follow-up) Correct OpacLoginInstructions in login modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120026|0 |1 is obsolete| | Attachment #120037|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120095&action=edit Bug 28193: OpacLoginInstructions news block broken by Bug 20168 This patch fixes a regression which was introduced by Bug 20168, causing the OpacLoginInstructions template code to revert back to the old system preference behavior. This patch returns the correct markup. To test, apply the patch and view the OPAC login page (/cgi-bin/koha/opac-user.pl) - With no news entry for OpacLoginInstructions you should see the default: A block of text with two headings, "Don't have a password yet?" and "Don't have a library card?" - Go to Tools -> News and create an entry for OpacLoginInstructions. - Return to the OPAC and confirm that your custom text appears. - Try updating/installing another translation and adding a different news entry for that language. Confirm that the correct entry appears. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120096&action=edit Bug 28193: (follow-up) Correct OpacLoginInstructions in login modal Signed-off-by: John Doe <you@example.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120095|0 |1 is obsolete| | Attachment #120096|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120097&action=edit Bug 28193: OpacLoginInstructions news block broken by Bug 20168 This patch fixes a regression which was introduced by Bug 20168, causing the OpacLoginInstructions template code to revert back to the old system preference behavior. This patch returns the correct markup. To test, apply the patch and view the OPAC login page (/cgi-bin/koha/opac-user.pl) - With no news entry for OpacLoginInstructions you should see the default: A block of text with two headings, "Don't have a password yet?" and "Don't have a library card?" - Go to Tools -> News and create an entry for OpacLoginInstructions. - Return to the OPAC and confirm that your custom text appears. - Try updating/installing another translation and adding a different news entry for that language. Confirm that the correct entry appears. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120098&action=edit Bug 28193: (follow-up) Correct OpacLoginInstructions in login modal Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com Resolution|--- |FIXED --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not pushed to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28193 Bug 28193 depends on bug 20168, which changed state. Bug 20168 Summary: Update of the OPAC bootstrap template to bootstrap v4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org