[Bug 21493] New: Remove incomplete icon style from serial issues tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Bug ID: 21493 Summary: Remove incomplete icon style from serial issues tabs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When viewing the brief or full history of a subscription's issues, there are tab links for "Normal view," "Brief history," and "Full history." These links are incorrectly inheriting an incomplete style: The default sprite is specified but no background-position. Since there are no icons intended for these tabs the background image should be removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79963&action=edit Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79963|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80218&action=edit Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Always like a bit of cleaning up.. thanks Owen, signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80218|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80234&action=edit Bug 21493: Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons and makes other minor corrections to related CSS. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. - View the purchase suggestions page as a logged-in user. Confirm that the "new purchase suggestion" link looks correct. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80596&action=edit Bug 21493: (18.05.x) Remove incomplete icon style from serial issues tabs This patch adds CSS to exclude serial issues history links from having an icon background. There is no part of the icon sprite which is designed for that purpose. This patch also tweaks the positioning of a couple of icons. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files). - Open the detail page for a bibliographic record in the OPAC which has subscriptions. - Click the "More details" link. - Confirm that the "Brief history" and "Full history" links have no icon. - Click the "Full history" link and do the same. - On the normal, MARC, and ISBD views, confirm that the icons for those links look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the 18.05.x version Owen. Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21493 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 18385 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org