[Bug 9617] New: Replace YUI menu on catalog pages with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Bug ID: 9617 Summary: Replace YUI menu on catalog pages with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/detail.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar include file used on catalog detail pages (detail.pl, MARCdetail.pl, etc.) uses YUI for buttons and button menus. It should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15561&action=edit Bug 9617 - Replace YUI menu on catalog pages with Bootstrap This patch converts the toolbar include file used by catalog detail pages (detail.pl, MARCdetail.pl, etc.) replacing YUI button and menu code with Bootstrap. Minor change to staff client CSS fixes issue with language footer. Minor change to doc-head-close.inc corrects error in logic for handling cart and lists js discovered in testing. To test, view any page which uses cat-toolbar.inc. Buttons and menus should look correct and work correctly. Functions to test include: New record New item New subscription New child record Edit record Edit items Edit items in a batch Delete items in a batch Attach item Edit as new (duplicate) Replace record via Z39.50 Delete record Delete all items Save (various formats) Add to cart Add to list Print Place hold (including with search-to-hold active). Testing should be done by users with varying permissions including with and without: CAN_user_serials_create_subscription CAN_user_editcatalogue_edit_catalogue CAN_user_editcatalogue_edit_items CAN_user_tools_items_batchmod CAN_user_tools_items_batchdel -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15561|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15591&action=edit [SIGNED-OFF] Bug 9617 - Replace YUI menu on catalog pages with Bootstrap This patch converts the toolbar include file used by catalog detail pages (detail.pl, MARCdetail.pl, etc.) replacing YUI button and menu code with Bootstrap. Minor change to staff client CSS fixes issue with language footer. Minor change to doc-head-close.inc corrects error in logic for handling cart and lists js discovered in testing. To test, view any page which uses cat-toolbar.inc. Buttons and menus should look correct and work correctly. Functions to test include: New record New item New subscription New child record Edit record Edit items Edit items in a batch Delete items in a batch Attach item Edit as new (duplicate) Replace record via Z39.50 Delete record Delete all items Save (various formats) Add to cart Add to list Print Place hold (including with search-to-hold active). Testing should be done by users with varying permissions including with and without: CAN_user_serials_create_subscription CAN_user_editcatalogue_edit_catalogue CAN_user_editcatalogue_edit_items CAN_user_tools_items_batchmod CAN_user_tools_items_batchdel Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons tested. Works as described. No Errors. Looks good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Medium patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Woow, great patch. cat-toolcar.inc burned eyes so much! :) All works perfectly, I didn't find any regression. I think that a form element with an id='f' and name='f' is not really a good idea since it is an include file, but it was already present before this patch. However, one remark (because I don't know if it is wanted): the div#toolbar has a margin-top: 10px; added by the .btn-toolbar. So the toolbar is 10px under its previous position. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15591|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15773&action=edit Bug 9617 - Replace YUI menu on catalog pages with Bootstrap This patch converts the toolbar include file used by catalog detail pages (detail.pl, MARCdetail.pl, etc.) replacing YUI button and menu code with Bootstrap. Minor change to staff client CSS fixes issue with language footer. Minor change to doc-head-close.inc corrects error in logic for handling cart and lists js discovered in testing. To test, view any page which uses cat-toolbar.inc. Buttons and menus should look correct and work correctly. Functions to test include: New record New item New subscription New child record Edit record Edit items Edit items in a batch Delete items in a batch Attach item Edit as new (duplicate) Replace record via Z39.50 Delete record Delete all items Save (various formats) Add to cart Add to list Print Place hold (including with search-to-hold active). Testing should be done by users with varying permissions including with and without: CAN_user_serials_create_subscription CAN_user_editcatalogue_edit_catalogue CAN_user_editcatalogue_edit_items CAN_user_tools_items_batchmod CAN_user_tools_items_batchdel Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: All buttons tested. Works as described. No Errors. Looks good. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #3)
However, one remark (because I don't know if it is wanted): the div#toolbar has a margin-top: 10px; added by the .btn-toolbar. So the toolbar is 10px under its previous position.
Owen, If is not wanted, we can redefine the margin-top property for div#toolbar ( margin-top: 0;). Could be done in a followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9617 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org